DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ting Xu <ting.xu@intel.com>, <dev@dpdk.org>
Cc: <qi.z.zhang@intel.com>, <qiming.yang@intel.com>, <junfeng.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ice: enable protocol agnostic flow offloading in RSS
Date: Wed, 3 Nov 2021 14:13:24 +0000	[thread overview]
Message-ID: <abdad0b0-d434-bc50-94fc-3054ab33dda8@intel.com> (raw)
In-Reply-To: <20211102014943.19726-3-ting.xu@intel.com>

On 11/2/2021 1:49 AM, Ting Xu wrote:
> +static int
> +ice_hash_rem_raw_cfg(struct ice_adapter *ad,
> +			struct ice_parser_profile *prof,
> +		    u16 vsi_handle)
> +{
> +	struct ice_hw *hw = &ad->hw;
> +	int ptg, ret;
> +	u16 vsig;
> +	u64 id;
> +
> +	id = (u64)ice_find_first_bit(prof->ptypes, 0xFFFF);
> +
> +	ptg = hw->blk[ICE_BLK_RSS].xlt1.t[id];
> +
> +	memset(&ad->rss_prof_info[ptg], 0,
> +		sizeof(struct ice_rss_prof_info));
> +
> +	/* check if vsig is already removed */
> +	ret = ice_vsig_find_vsi(hw, ICE_BLK_RSS,
> +		ice_get_hw_vsi_num(hw, vsi_handle), &vsig);
> +	if (!ret && vsig) {
> +		ret = ice_rem_prof_id_flow(hw, ICE_BLK_RSS,
> +					   ice_get_hw_vsi_num(hw, vsi__handle),

The set doesn't compile, 'vsi__handle' is not defined.

Most probably it is a typo for 'vsi_handle', but I was reluctant
to fix it in next-net. If the code sent without compiling, there
may be other issues missed, can you please check the set again,
build it, test it and send a new version?

Thanks,
ferruh

  reply	other threads:[~2021-11-03 14:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08  7:09 [dpdk-dev] [PATCH v1 0/2] " Ting Xu
2021-10-08  7:09 ` [dpdk-dev] [PATCH v1 1/2] net/ice: " Ting Xu
2021-10-08  7:09 ` [dpdk-dev] [PATCH v1 2/2] doc: add protocol agnostic flow offloading for RSS hash Ting Xu
2021-11-01 11:02 ` [dpdk-dev] [PATCH v2 0/3] enable protocol agnostic flow offloading in RSS Ting Xu
2021-11-01 11:02   ` [dpdk-dev] [PATCH v2 1/3] net/ice: " Ting Xu
2021-11-01 11:02   ` [dpdk-dev] [PATCH v2 2/3] " Ting Xu
2021-11-01 11:02   ` [dpdk-dev] [PATCH v2 3/3] doc: add protocol agnostic flow offloading for RSS Ting Xu
2021-11-01 11:05 ` [dpdk-dev] [PATCH v2 0/3] enable protocol agnostic flow offloading in RSS Ting Xu
2021-11-01 11:05   ` [dpdk-dev] [PATCH v2 1/3] net/ice/base: support add HW profile for RSS raw flow Ting Xu
2021-11-01 11:05   ` [dpdk-dev] [PATCH v2 2/3] net/ice: enable protocol agnostic flow offloading in RSS Ting Xu
2021-11-01 11:05   ` [dpdk-dev] [PATCH v2 3/3] doc: add protocol agnostic flow offloading for RSS Ting Xu
2021-11-02  1:49 ` [dpdk-dev] [PATCH v3 0/3] enable protocol agnostic flow offloading in RSS Ting Xu
2021-11-02  1:49   ` [dpdk-dev] [PATCH v3 1/3] net/ice/base: support add HW profile for RSS raw flow Ting Xu
2021-11-02  1:49   ` [dpdk-dev] [PATCH v3 2/3] net/ice: enable protocol agnostic flow offloading in RSS Ting Xu
2021-11-03 14:13     ` Ferruh Yigit [this message]
2021-11-04  3:29       ` Xu, Ting
2021-11-02  1:49   ` [dpdk-dev] [PATCH v3 3/3] doc: add protocol agnostic flow offloading for RSS Ting Xu
2021-11-03 12:45   ` [dpdk-dev] [PATCH v3 0/3] enable protocol agnostic flow offloading in RSS Zhang, Qi Z
2021-11-03 14:15     ` Ferruh Yigit
2021-11-04  2:22 ` [dpdk-dev] [PATCH v4 0/2] " Ting Xu
2021-11-04  2:22   ` [dpdk-dev] [PATCH v4 1/2] net/ice/base: support add HW profile for RSS raw flow Ting Xu
2021-11-04  2:22   ` [dpdk-dev] [PATCH v4 2/2] net/ice: enable protocol agnostic flow offloading in RSS Ting Xu
2021-11-04  3:31   ` [dpdk-dev] [PATCH v4 0/2] " Zhang, Qi Z
2021-11-05 13:09   ` Thomas Monjalon
2021-11-05 13:18     ` Xu, Ting
2021-11-05 13:23       ` Thomas Monjalon
2021-11-05 14:53         ` Xu, Ting
2021-11-08  2:44           ` Zhang, Qi Z
2021-11-08 19:47             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abdad0b0-d434-bc50-94fc-3054ab33dda8@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=junfeng.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=ting.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).