From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 556E6A0C53; Wed, 3 Nov 2021 15:13:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 130D6426E1; Wed, 3 Nov 2021 15:13:37 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0901141134 for ; Wed, 3 Nov 2021 15:13:34 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="228951510" X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="228951510" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 07:13:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="541698623" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 03 Nov 2021 07:13:33 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 07:13:33 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 07:13:32 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 3 Nov 2021 07:13:32 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 3 Nov 2021 07:13:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FfTBblM9HyG7V+XkX8zqBIKZN3dkz4gaPUecUq8GgDkSbarUFVEKDJxCfeNiFuy3SB0NcyTYv2HBOzOgaG1tDDMiUnv+v4P1Oe/gsBrXC3pDHMrxVPXbukPaNq6GKbIgut3zSmvvB7aZSbcvc05hkN3qF4ubQlOKr5P2Itqbc4qBIqAaOrVqWNaymcOfjf+9x/mJB/rhkIiOtOZZUA99lRQ+kv8a4u7gydKs8B6HiASQoVveMSO+F1CBGTedwZ5js+Mj1Hp7bjsUistnCFs0b3D0YLEbKZXGjxFpj18m+yBMcfid0tnrl/+aYlq5McsRdqi1A199Mt9j4GLu41xtuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y+RiyOwfEpsoOGzyeyrDM5Y1LJLcBFyugVt+37tJv2c=; b=DxcJEliF9CZhpF3Wv9Zcu5QKDs94yBPZsemHHJtTQmk/QYhzAuCkcIlnoBJeNkJqZhfwGmq9nmtJRkijWaPJ7fY+hxdB3BX2PZi+Eii/s2ZTcmHtFBZr2uT4wUvcylVWhT3lFLhEhHP8btsKyR50hbdlm29JnslE8lrZ7Vsflonyi2rTQabDSCnAIDBJngoS2C6dYmJGtWAGKYaSKPOKW2IS7BnXXoLt+izMzETVD/p4Mk0ZoTybk8uMswUr4ehTEB5emNcE/ZQ1b5n5b3uPddEO6YXWyphmojYSx21JaFzN6TPAoGesJ+7wtt/vk3sLNx39GbO9mMImLRCBuhKayw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y+RiyOwfEpsoOGzyeyrDM5Y1LJLcBFyugVt+37tJv2c=; b=TmeQRrBKFZ71+VXPh9SadhtG3Iti6Q5f8/vCvdjfKRzXgifNYFAwahUEkswMvsUXM1mF9aqPeN329N5nIEb+aRRt/iMbHkAYIXuQ7HWZ2+3yPvC1jBBT53waRTWtFkeyzCc6Gz35pnrUbcymUUn+I0t4n9FnZ1Fx3oIMvmcXUy8= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5914.namprd11.prod.outlook.com (2603:10b6:510:138::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 3 Nov 2021 14:13:29 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Wed, 3 Nov 2021 14:13:29 +0000 Message-ID: Date: Wed, 3 Nov 2021 14:13:24 +0000 Content-Language: en-US To: Ting Xu , CC: , , References: <20211008070934.6956-1-ting.xu@intel.com> <20211102014943.19726-1-ting.xu@intel.com> <20211102014943.19726-3-ting.xu@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211102014943.19726-3-ting.xu@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0382.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::9) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0382.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17 via Frontend Transport; Wed, 3 Nov 2021 14:13:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 276fbc7f-f1b2-41af-2a75-08d99ed41c2c X-MS-TrafficTypeDiagnostic: PH7PR11MB5914: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vxpZ4+a7Vv1KcfCNWx7+dCxQ5nL7vKfvqy3Q7jU2dv6Ruxi8y7vQmRL0CMRhoYHnCKVXnWX6yH+uxc+gjXcnTBx5PCNqCaNeilxI6LG6P918d92H/z6TuV0qZa5MMj/T0LNSvbj0Ctjk+crUjenEzqPA2aJAAKtoMXIPu2hbCl61mJQR+RjUhP0DgmAmgFdyucO48GgpUGuGIiDuOReEMJMjO0CIMZs2QP+ZvMrfUP0c2SZNaL/LhXX5RIuSW/hcp3l73n0dkb7oDe6pUg1CCFOPAWFqRy5sBRGrpdt50KFrM2CFHOZiYDAcihZtzMknsTyMmP57EiwvLWYhf3ClnxMQ1qwYbvnGR2p4zxyE62H6SxZsV7PMTZzc7ppj/SqIXhmyDLpwRegvg3inKw0OGr+mGfqgbRDWImZocOd0ed1a3nQhBJhF1XR6F548qCr0+ThKPnOeV3BXIKfAB1LqEKvyZ1YAqhr2niUgmmz2+UVxc5GMBSOe+QTClRTgHIMACuJFdI1K9p/IfxtLlyvx3noGuqB5MIN7mAEHY52PEDWA8ABMGF8wpfNLJo7DuwnY0/4IBiWOzk9fEqGs8EyKKRpVh7vWc70Kw5MlB9O3mXUeF5Ro4yApcVbBjfMNaUUpBG8ZR6CNBWPqGZPfxbcQ/0tZMFOUnY+nkzwNps9L1Now3kJ0+qDaY/sxKT5NzMGvDmv2017rUi0fLK5DBoMAKA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(956004)(2906002)(6486002)(82960400001)(107886003)(2616005)(66946007)(4744005)(5660300002)(86362001)(53546011)(16576012)(44832011)(66476007)(36756003)(4326008)(8676002)(31686004)(8936002)(316002)(26005)(31696002)(508600001)(38100700002)(66556008)(186003)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SE9CSFRSUFlMY3ZjL1BWOFZjQTQxZkJScm5VRTVaWjV3bFA0eThMczNlNStR?= =?utf-8?B?Zncyd1JVZXRUd2NkZU52VTF0aWpwcUl1YkpBdHBFdjJZeWEycjJrTVhEZjRa?= =?utf-8?B?K3JjcTZCUmE0dTVJU2JIaEc1RkFQMThqMUdueUpobHB3ZHVLbW1YL0lSbHJM?= =?utf-8?B?MXh0aDdzOU5NendkYkRpZHZZRGEwT2NOdEhaeDlicEd0MDR1K0JIbUhKajZQ?= =?utf-8?B?NENwdm1rS0pmR0hwL05UQW00bFlIdCtTYmZFOTJlT3htOEk1QXUzMWthMzYr?= =?utf-8?B?WndsTytrT3RZbDE0OWxhYlYyUjNrUURqaFVqV1l0OWFqREcxZnI3OFhiWlJt?= =?utf-8?B?bHFoSWJGR2IzTEo1TnhlRlZaSTdabm95TnVSNG1Fd0RZNjdXT3N5cnhFL1lk?= =?utf-8?B?TXQrMjRjQ1BMa2l0SGdXSzRXSnF6Z005ekVPalRsaWkydmFrOUtxT25CWWw4?= =?utf-8?B?YXl1VGpwSmJRZkRCd3VkY2lyNmg2THFBbkVLV1FUVTRMN1lxYm9UY3dBVzF0?= =?utf-8?B?QURCWkNDb0svTFJ0ZVJvSzBZcU5FSGE0Skp2SUtjWTRpUzIwUnRjRTRvcEY1?= =?utf-8?B?M204U0VoeWZaR1BVeEN2VW5pbnVDQkVORGhEZ3hOOGxCeUF1WCtWL1JueE1y?= =?utf-8?B?U3pUTldXMkxYUmd4WTA4WDZXMzZnSFZ3NTVDTTdQdkpYdVJKL0tFUkZUcjUv?= =?utf-8?B?b2hJNXV3TXVRZ0grSitDazAzcDRJWDl4L05aWWVCcDRoMksxYk9zd2ViUDVD?= =?utf-8?B?aitvNU5CSzUvS1czVm5HNzR3UUkvcVRPVzRVc2o1ek9KK0ZpYWRSVFV4RGZt?= =?utf-8?B?Q3FxV1VvLzVRUjVKWjg0SHFRdHdhbFV0N3VremVWS1EvQVRZUW0xbzQ1Y1My?= =?utf-8?B?K2ZWRTg0U1NiUDNlb1ZyWnhNT0Q2OEp4SWFWeW55enNKeElIZHdLdnZER1dx?= =?utf-8?B?UXN6djNySVJxWnZVa1NYWnVGWERuTEhvT3RtdmV2Mm5UUXU4Z0dVOHJZc2w3?= =?utf-8?B?bmZZcXJ2bERIRXgyM1ExOGlCdUVIQ1krLy9yMzlSQmsrcnM5Ym9DTHBIQW9j?= =?utf-8?B?VHRoYXNUVzFCaGhyUzNqOEVFazVUd3gvdis0Q25mLzgyN1Q4SXNYeDYyZ2Q3?= =?utf-8?B?ZHZ1T1dFcWsxLzV6Ylo4MElCQzFJRzN1dXZybWViWVRJNGYyY2ZjRWMzZGlp?= =?utf-8?B?QTIrSzllb21wc2lBVUNBS2t5Ylk2K3Q5MS9oWDdXc1MxMTZzd2tiTjRJNHhj?= =?utf-8?B?eTNEVXlHRG9jTCtiM2hwOFdpQXZGdlJxQkU0aEtsbUtkTmpuSWhhTGMvRVQ4?= =?utf-8?B?SUpEb1lPQ01yVlNlQjVJdlRNUVhRa2xSUDFSYjVyUHJDcUljbmhtTmVFMFVW?= =?utf-8?B?RW1EdWJOVlRkZ0YzSzFIUmd1bUkwbnBrWC9UZGFCYzJacTRyaytZeXlKQUpt?= =?utf-8?B?QnF1c0xXTGJRdUN5bWptZGg1TzhydjBiNVR5YkR3OHpUSjI2WjhXdndCaXU0?= =?utf-8?B?eUVvQ1lUell2Tm1SSUVLRERNSXdOMVplUlFjNTJkSmMzYldhSjVlelp5S2No?= =?utf-8?B?UExGS2dvZXBCcENSM052OHNQSHJPeTNraytQZm11TjdEZnA4WHJ4d3hDcUV6?= =?utf-8?B?QmFyVFRVL0VrT2hhbUxac0hSZStLL0FIQ25vTGFwTURYMmdjR1hyOFBEVzFs?= =?utf-8?B?Q056K3NwOUpLUldEN29SVzkxSXU5WGNlUVE3WkFyeHNXK3VRUlhTOWpnL1hj?= =?utf-8?B?clZEMi84aGRrSDNTUVhtcWVUN2NaODFldmFqT21lTWNKdVZ5bnJIOTRJRUFP?= =?utf-8?B?QWNvMEtzRWxQcE9GK2laeW9SL2I2b0NsNTV6S25oUnNNYUtUeFdEanFoVldR?= =?utf-8?B?aTNmbVBRVjhsWWpBaE9uUFNYM1VCeVkyUnNEbVFINWQzS3Q5QkJKV0ZnU1RZ?= =?utf-8?B?eHM2YW1xYm92dXVTRGJsaWw4UGRNd2h5UElYcDhzVnFMYys0ODdqR0Z4NU9k?= =?utf-8?B?T1Q4MXNRdHBWNnA1TmtidjVTdXVjbnB5Y3UzaXp1c2lQV0Flbk81UUNWdUl1?= =?utf-8?B?VmJFOE9UUTJZNWJqUlJ6bkI3ZjZtVzFqak13cUVncTZsekJ1UlYvQjhCZUFr?= =?utf-8?B?a1plMUphVmdhL1JtcU9YempoVjR2UHRSUVpnMzU0cjhqTzNDTGo0d0E4LzlH?= =?utf-8?Q?9mOpsJPjFqMp1L33JCGhfc0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 276fbc7f-f1b2-41af-2a75-08d99ed41c2c X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 14:13:29.5196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tRpAT/hYJnvjLX4Dh85rYmeFyWrvqW8+zkjQ0AznbV3qmR9fIZmr4uHFuY0b7raZwT4ETiE8POy5pqeGzhfipA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5914 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ice: enable protocol agnostic flow offloading in RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2021 1:49 AM, Ting Xu wrote: > +static int > +ice_hash_rem_raw_cfg(struct ice_adapter *ad, > + struct ice_parser_profile *prof, > + u16 vsi_handle) > +{ > + struct ice_hw *hw = &ad->hw; > + int ptg, ret; > + u16 vsig; > + u64 id; > + > + id = (u64)ice_find_first_bit(prof->ptypes, 0xFFFF); > + > + ptg = hw->blk[ICE_BLK_RSS].xlt1.t[id]; > + > + memset(&ad->rss_prof_info[ptg], 0, > + sizeof(struct ice_rss_prof_info)); > + > + /* check if vsig is already removed */ > + ret = ice_vsig_find_vsi(hw, ICE_BLK_RSS, > + ice_get_hw_vsi_num(hw, vsi_handle), &vsig); > + if (!ret && vsig) { > + ret = ice_rem_prof_id_flow(hw, ICE_BLK_RSS, > + ice_get_hw_vsi_num(hw, vsi__handle), The set doesn't compile, 'vsi__handle' is not defined. Most probably it is a typo for 'vsi_handle', but I was reluctant to fix it in next-net. If the code sent without compiling, there may be other issues missed, can you please check the set again, build it, test it and send a new version? Thanks, ferruh