From: Kevin Traynor <ktraynor@redhat.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ciara Loftus <ciara.loftus@intel.com>,
dev@dpdk.org, "Zhang, Qi Z" <qi.z.zhang@intel.com>,
shibin.koikkara.reeny@intel.com
Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com,
David Marchand <david.marchand@redhat.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0
Date: Thu, 23 Mar 2023 10:23:47 +0000 [thread overview]
Message-ID: <abe7b2e3-86f3-37f1-98ad-4711ea21603f@redhat.com> (raw)
In-Reply-To: <1f1c1d68-7fdf-5ce4-2ba5-4a5340dcbc2f@redhat.com>
+cc John
For better context, this part of the discussion starts here:
http://inbox.dpdk.org/dev/d718d0fe-09a2-8840-e8a4-dd41b732b391@redhat.com/
On 16/03/2023 13:31, Kevin Traynor wrote:
> On 15/03/2023 11:47, Kevin Traynor wrote:
>> On 21/12/2022 09:28, Kevin Traynor wrote:
>>> On 21/12/2022 06:09, Andrew Rybchenko wrote:
>>>> Hi Kevin,
>>>>
>>>> On 12/20/22 17:05, Kevin Traynor wrote:
>>>>> On 24/06/2022 11:23, Ciara Loftus wrote:
>>>>>> libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd
>>>>>> functions. Use meson to detect if libbpf >= v0.7.0 is linked and if
>>>>>> so, use
>>>>>> the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach
>>>>>> and bpf_xdp_detach which are available to use since libbpf v0.7.0.
>>>>>>
>>>>>> Also prevent linking with libbpf versions > v0.8.0.
>>>>>>
>>>>>> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
>>>>>
>>>>> Hi Andrew/Qi (assuming Ciara is still out of office),
>>>>>
>>>>> I am seeing a similar issue [1] on 21.11 branch with Fedora 37
>>>>> (libbpf-0.8.0-2.fc37.x86_64 and libxdp-1.2.6-1.fc37.x86_64).
>>>>>
>>>>> This patch alone won't apply as there are other dependencies. Looking at
>>>>> the commits in main branch, it seems like I could take all these [2] to
>>>>> resolve the issue. With these cherry-picked the build warnings on Fedora
>>>>> 37 are removed.
>>>>>
>>>>> It's a bit late to take these for DPDK 21.11.3 as I intend to release
>>>>> later today/tomorrow, so it can be resolved for DPDK 21.11.4.
>>>>>
>>>>> Do the commits below look ok for backport? Main branch might be able to
>>>>> demand user uses new libbpf/libxdp versions etc, but with stable we
>>>>> never want to break the users existing setup when they upgrade from
>>>>> 2X.11.n to 2X.11.n+1.
>>
>> N.B. ^^^^
>>
>>>>>
>>>>> Let me know what you think?
>>>>
>>>> IMO these patches are to to be backported to stable branch.
>>>
>>> Thanks Andrew.
>>>
>>>> However, af_xdp maintainers opinion is more important here.
>>>>
>>>
>>> Qi, what do you think?
>>>
>>
>> Hi Qi/Ciara, this issue is still present approaching 21.11.4.
>>
>> What is your opinion on backporting these patches? Please especially
>> note the paragraph above wrt users not being required to upgrade libbpf.
>>
>
> +Shibin, following discussion in DPDK release meeting.
>
>> thanks,
>> Kevin.
>>
>>>>>
>>>>> thanks,
>>>>> Kevin.
>>>>>
>>>>> [1] https://paste.centos.org/view/e4eec764
>>>>> [2]
>>>>> 1eb1846b1a net/af_xdp: make compatible with libbpf 0.8.0
>>>>> 5ff3dbe6ce net/af_xdp: add log on XDP program removal failures
>>>>> 0ed0bc3834 net/af_xdp: avoid version-based check for program load
>>>>> e024c7e838 net/af_xdp: avoid version-based check for shared UMEM
>>>>> f76dc44ded net/af_xdp: make clear which libxdp version is required
>>>>> 50b855fc47 net/af_xdp: move XDP library presence flag setting
>>>>>
>>>>
>>>
>>
>
next prev parent reply other threads:[~2023-03-23 10:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 10:23 Ciara Loftus
2022-06-24 11:45 ` Andrew Rybchenko
2022-06-27 14:17 ` Loftus, Ciara
2022-06-27 14:50 ` Andrew Rybchenko
2022-06-27 15:24 ` Loftus, Ciara
2022-06-28 9:15 ` Andrew Rybchenko
2022-06-28 10:07 ` Loftus, Ciara
2022-07-21 12:16 ` Loftus, Ciara
2022-06-28 12:18 ` [PATCH v2] " Ciara Loftus
2022-10-05 9:50 ` [PATCH v3 0/6] " Andrew Rybchenko
2022-10-05 9:50 ` [PATCH v3] mempool: fix get objects from mempool with cache Andrew Rybchenko
2022-10-05 9:56 ` Andrew Rybchenko
2022-10-05 9:50 ` [PATCH v3 1/6] net/af_xdp: move XDP library presence flag to right branch Andrew Rybchenko
2022-10-05 9:50 ` [PATCH v3 2/6] net/af_xdp: make it clear which libxdp version is required Andrew Rybchenko
2022-10-05 9:50 ` [PATCH v3 3/6] net/af_xdp: avoid version-based check for shared UMEM Andrew Rybchenko
2022-10-05 9:50 ` [PATCH v3 4/6] net/af_xdp: avoid version-based check for program load mech Andrew Rybchenko
2022-10-05 9:50 ` [PATCH v3 5/6] net/af_xdp: log errors on XDP program removal failures Andrew Rybchenko
2022-10-05 9:50 ` [PATCH v3 6/6] net/af_xdp: make compatible with libbpf v0.8.0 Andrew Rybchenko
2022-10-06 6:26 ` [PATCH v4 0/6] " Andrew Rybchenko
2022-10-06 6:26 ` [PATCH v4 1/6] net/af_xdp: move XDP library presence flag to right branch Andrew Rybchenko
2022-10-06 6:26 ` [PATCH v4 2/6] net/af_xdp: make it clear which libxdp version is required Andrew Rybchenko
2022-10-06 6:26 ` [PATCH v4 3/6] net/af_xdp: avoid version-based check for shared UMEM Andrew Rybchenko
2022-10-06 6:26 ` [PATCH v4 4/6] net/af_xdp: avoid version-based check for program load mech Andrew Rybchenko
2022-10-06 6:26 ` [PATCH v4 5/6] net/af_xdp: log errors on XDP program removal failures Andrew Rybchenko
2022-10-06 6:26 ` [PATCH v4 6/6] net/af_xdp: make compatible with libbpf v0.8.0 Andrew Rybchenko
2022-10-07 17:19 ` Ferruh Yigit
2022-10-07 17:28 ` Ferruh Yigit
2022-10-07 17:40 ` [PATCH v4 0/6] " Ferruh Yigit
2022-12-20 14:05 ` [PATCH] " Kevin Traynor
2022-12-21 6:09 ` Andrew Rybchenko
2022-12-21 9:28 ` Kevin Traynor
2023-03-15 11:47 ` Kevin Traynor
2023-03-16 13:31 ` Kevin Traynor
2023-03-23 10:23 ` Kevin Traynor [this message]
2023-04-04 15:51 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe7b2e3-86f3-37f1-98ad-4711ea21603f@redhat.com \
--to=ktraynor@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=ciara.loftus@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=john.mcnamara@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=shibin.koikkara.reeny@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).