From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6D55427E7; Thu, 23 Mar 2023 11:23:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 720BB40E09; Thu, 23 Mar 2023 11:23:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C098B4021D for ; Thu, 23 Mar 2023 11:23:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679567034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cq8V1Hud/Uo+QoYRGve7w9uFscaXl/rNzK5t8l2/n94=; b=dJnT4HhiPBpaXKeV/QALxIkoS3hGnNEFyX5vdNKilZ/2AgKw1mQg40eGsvUJwyZqOdV8oD CU1ix8leF51q1p9mrSm4j/XrOKD76TiHOQgi8jYYm249OQOdk5sG9jrUcnmL1cGr5MCPuw q9fuAvbqmt45XELpFgspa4qlvwCFUXk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-YBRNka0cO1O12aDg3st-Ig-1; Thu, 23 Mar 2023 06:23:50 -0400 X-MC-Unique: YBRNka0cO1O12aDg3st-Ig-1 Received: by mail-wr1-f71.google.com with SMTP id y4-20020adfc7c4000000b002d633dc129aso1360115wrg.0 for ; Thu, 23 Mar 2023 03:23:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679567029; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cq8V1Hud/Uo+QoYRGve7w9uFscaXl/rNzK5t8l2/n94=; b=WCB80Smh5Rqt+UnbAf+oYjYDKChslBBt4QXXkbChrZrvjV67MTmjDZN/9GC7qrtDuH T9dm3umayJmRvW28tXWCXl+tojy38aX6jgv8tXbuXLBKXazNUzuevDLHvQq0Pfy6j3eE EZfPHq0FtETqd3KTB/ggpsOTExP1bBPLzyzUusGcRQCL7bOJk3pAT/VKEPIdUTWsJYBE bp7DqDAo9wEHhNw/juS8mVL4NWEIO+aLSP+G2qN1SNXqc3Ya71cAxuSmLd91ZoWWiEnc O5FaR3JYpLe4nNzh2ARa2d9DfbEQdF9voShQ+oeTyA0Su5O5sEH9IQ531Px0yjNZTHED 3nEQ== X-Gm-Message-State: AO0yUKXuI1CVSiX80Tpl3CkfnaXy3TRD7eXKUzV5Mm/mFJMlhpWCUu9e OKrUL7M6m4uZw+7LWUKKdzTFZlvZzq2rDyPt6FK5fUEOQS67t60gHw0BWhXz9CGIEk22GfK2wQ+ PXZs= X-Received: by 2002:a1c:f303:0:b0:3ed:a5a2:145 with SMTP id q3-20020a1cf303000000b003eda5a20145mr1942234wmq.6.1679567029762; Thu, 23 Mar 2023 03:23:49 -0700 (PDT) X-Google-Smtp-Source: AK7set8MY/fD02hWPj0jWc0EYubrgZFpPM1e9kKoSiVteBv1vJAE/dIVRZZ0tODyFgUMef7jU3RoBg== X-Received: by 2002:a1c:f303:0:b0:3ed:a5a2:145 with SMTP id q3-20020a1cf303000000b003eda5a20145mr1942219wmq.6.1679567029430; Thu, 23 Mar 2023 03:23:49 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id 26-20020a05600c231a00b003dc522dd25esm1445928wmo.30.2023.03.23.03.23.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 03:23:48 -0700 (PDT) Message-ID: Date: Thu, 23 Mar 2023 10:23:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Kevin Traynor To: Andrew Rybchenko , Ciara Loftus , dev@dpdk.org, "Zhang, Qi Z" , shibin.koikkara.reeny@intel.com Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com, David Marchand , "Mcnamara, John" References: <20220624102354.1516606-1-ciara.loftus@intel.com> <0fcfe78a-72c6-788d-867e-0ff554ba5004@oktetlabs.ru> <29f03d86-bc81-c39f-76b1-bb51b9999cfb@redhat.com> <1f1c1d68-7fdf-5ce4-2ba5-4a5340dcbc2f@redhat.com> Subject: Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0 In-Reply-To: <1f1c1d68-7fdf-5ce4-2ba5-4a5340dcbc2f@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org +cc John For better context, this part of the discussion starts here: http://inbox.dpdk.org/dev/d718d0fe-09a2-8840-e8a4-dd41b732b391@redhat.com/ On 16/03/2023 13:31, Kevin Traynor wrote: > On 15/03/2023 11:47, Kevin Traynor wrote: >> On 21/12/2022 09:28, Kevin Traynor wrote: >>> On 21/12/2022 06:09, Andrew Rybchenko wrote: >>>> Hi Kevin, >>>> >>>> On 12/20/22 17:05, Kevin Traynor wrote: >>>>> On 24/06/2022 11:23, Ciara Loftus wrote: >>>>>> libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd >>>>>> functions. Use meson to detect if libbpf >= v0.7.0 is linked and if >>>>>> so, use >>>>>> the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach >>>>>> and bpf_xdp_detach which are available to use since libbpf v0.7.0. >>>>>> >>>>>> Also prevent linking with libbpf versions > v0.8.0. >>>>>> >>>>>> Signed-off-by: Ciara Loftus >>>>> >>>>> Hi Andrew/Qi (assuming Ciara is still out of office), >>>>> >>>>> I am seeing a similar issue [1] on 21.11 branch with Fedora 37 >>>>> (libbpf-0.8.0-2.fc37.x86_64 and libxdp-1.2.6-1.fc37.x86_64). >>>>> >>>>> This patch alone won't apply as there are other dependencies. Looking at >>>>> the commits in main branch, it seems like I could take all these [2] to >>>>> resolve the issue. With these cherry-picked the build warnings on Fedora >>>>> 37 are removed. >>>>> >>>>> It's a bit late to take these for DPDK 21.11.3 as I intend to release >>>>> later today/tomorrow, so it can be resolved for DPDK 21.11.4. >>>>> >>>>> Do the commits below look ok for backport? Main branch might be able to >>>>> demand user uses new libbpf/libxdp versions etc, but with stable we >>>>> never want to break the users existing setup when they upgrade from >>>>> 2X.11.n to 2X.11.n+1. >> >> N.B. ^^^^ >> >>>>> >>>>> Let me know what you think? >>>> >>>> IMO these patches are to to be backported to stable branch. >>> >>> Thanks Andrew. >>> >>>> However, af_xdp maintainers opinion is more important here. >>>> >>> >>> Qi, what do you think? >>> >> >> Hi Qi/Ciara, this issue is still present approaching 21.11.4. >> >> What is your opinion on backporting these patches? Please especially >> note the paragraph above wrt users not being required to upgrade libbpf. >> > > +Shibin, following discussion in DPDK release meeting. > >> thanks, >> Kevin. >> >>>>> >>>>> thanks, >>>>> Kevin. >>>>> >>>>> [1] https://paste.centos.org/view/e4eec764 >>>>> [2] >>>>> 1eb1846b1a net/af_xdp: make compatible with libbpf 0.8.0 >>>>> 5ff3dbe6ce net/af_xdp: add log on XDP program removal failures >>>>> 0ed0bc3834 net/af_xdp: avoid version-based check for program load >>>>> e024c7e838 net/af_xdp: avoid version-based check for shared UMEM >>>>> f76dc44ded net/af_xdp: make clear which libxdp version is required >>>>> 50b855fc47 net/af_xdp: move XDP library presence flag setting >>>>> >>>> >>> >> >