DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] metrics: promote metrics deinitialize API
@ 2021-09-03 13:08 Harman Kalra
  2021-09-03 13:09 ` Kinsella, Ray
  0 siblings, 1 reply; 3+ messages in thread
From: Harman Kalra @ 2021-09-03 13:08 UTC (permalink / raw)
  To: dev, Ray Kinsella; +Cc: Harman Kalra

Remove experimental flag from rte_metrics_deinit().
This API was introduced in 19.11 release.

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
 lib/metrics/rte_metrics.h | 4 ----
 lib/metrics/version.map   | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/lib/metrics/rte_metrics.h b/lib/metrics/rte_metrics.h
index fbe64ddf2b..c2815a252c 100644
--- a/lib/metrics/rte_metrics.h
+++ b/lib/metrics/rte_metrics.h
@@ -83,9 +83,6 @@ struct rte_metric_value {
 void rte_metrics_init(int socket_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Deinitialize metric module. This function must be called from
  * a primary process after all the metrics usage is over, to
  *  release the shared memory.
@@ -96,7 +93,6 @@ void rte_metrics_init(int socket_id);
  *    (rte_metrics_init() not called)
  *  0 - success
  */
-__rte_experimental
 int rte_metrics_deinit(void);
 
 /**
diff --git a/lib/metrics/version.map b/lib/metrics/version.map
index c86e405971..03bfdff569 100644
--- a/lib/metrics/version.map
+++ b/lib/metrics/version.map
@@ -8,6 +8,7 @@ DPDK_22 {
 	rte_metrics_reg_names;
 	rte_metrics_update_value;
 	rte_metrics_update_values;
+	rte_metrics_deinit;
 
 	local: *;
 };
@@ -15,7 +16,6 @@ DPDK_22 {
 EXPERIMENTAL {
 	global:
 
-	rte_metrics_deinit;
 	rte_metrics_tel_encode_json_format;
 	rte_metrics_tel_reg_all_ethdev;
 	rte_metrics_tel_get_global_stats;
-- 
2.18.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] metrics: promote metrics deinitialize API
  2021-09-03 13:08 [dpdk-dev] [PATCH] metrics: promote metrics deinitialize API Harman Kalra
@ 2021-09-03 13:09 ` Kinsella, Ray
  2021-09-23 17:24   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Kinsella, Ray @ 2021-09-03 13:09 UTC (permalink / raw)
  To: Harman Kalra, dev



On 03/09/2021 14:08, Harman Kalra wrote:
> Remove experimental flag from rte_metrics_deinit().
> This API was introduced in 19.11 release.
> 
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
>  lib/metrics/rte_metrics.h | 4 ----
>  lib/metrics/version.map   | 2 +-
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 

Acked-by: Ray Kinsella <mdr@ashroe.eu>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] metrics: promote metrics deinitialize API
  2021-09-03 13:09 ` Kinsella, Ray
@ 2021-09-23 17:24   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-09-23 17:24 UTC (permalink / raw)
  To: Harman Kalra; +Cc: dev, Kinsella, Ray

03/09/2021 15:09, Kinsella, Ray:
> 
> On 03/09/2021 14:08, Harman Kalra wrote:
> > Remove experimental flag from rte_metrics_deinit().
> > This API was introduced in 19.11 release.
> > 
> > Signed-off-by: Harman Kalra <hkalra@marvell.com>
> 
> Acked-by: Ray Kinsella <mdr@ashroe.eu>

Sorted function in .map in alphabetical order,
applied, thanks.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-23 17:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 13:08 [dpdk-dev] [PATCH] metrics: promote metrics deinitialize API Harman Kalra
2021-09-03 13:09 ` Kinsella, Ray
2021-09-23 17:24   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).