From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1100243BB1; Fri, 1 Mar 2024 02:46:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D01E9402E0; Fri, 1 Mar 2024 02:46:22 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 548ED4025C for ; Fri, 1 Mar 2024 02:46:21 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Tm9qP4nQqz1Q9ZC; Fri, 1 Mar 2024 09:44:01 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 6E3821A016B; Fri, 1 Mar 2024 09:46:18 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 1 Mar 2024 09:46:18 +0800 Subject: Re: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer To: Amit Prakash Shukla , Cheng Jiang , Gowrishankar Muthukrishnan CC: "dev@dpdk.org" , Jerin Jacob , Anoob Joseph , Kevin Laatz , Bruce Richardson , Pavan Nikhilesh Bhagavatula References: <20240108082749.1016345-1-amitprakashs@marvell.com> <20240227192601.3932913-1-amitprakashs@marvell.com> <1e4fe21a-8732-779b-0def-938832bdae2d@huawei.com> From: fengchengwen Message-ID: Date: Fri, 1 Mar 2024 09:46:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Amit, I think this commit will complicated the test, plus futer we may add more test (e.g. fill) I agree Bruce's advise in the [1], let also support "lcore_dma0/1/2", User could provide dma info by two way: 1) lcore_dma=, which seperate each dma with ", ", but a maximum of a certain number is allowed. 2) lcore_dma0/1/2/..., each dma device take one line [1] https://patchwork.dpdk.org/project/dpdk/patch/20231206112952.1588-1-vipin.varghese@amd.com/ Thanks On 2024/2/29 22:03, Amit Prakash Shukla wrote: > Hi Chengwen, > > I liked your suggestion and tried making changes, but encountered parsing issue for CFG files with line greater than CFG_VALUE_LEN=256(current value set). > > There is a discussion on the similar lines in another patch set: https://patchwork.dpdk.org/project/dpdk/patch/20231206112952.1588-1-vipin.varghese@amd.com/. > > I believe this patch can be taken as-is and we can come up with the solution when we can increase the CFG_VALUE_LEN as changing CFG_VALUE_LEN in this release is causing ABI breakage. > > Thanks, > Amit Shukla > >> -----Original Message----- >> From: Amit Prakash Shukla >> Sent: Wednesday, February 28, 2024 3:08 PM >> To: fengchengwen ; Cheng Jiang >> ; Gowrishankar Muthukrishnan >> >> Cc: dev@dpdk.org; Jerin Jacob ; Anoob Joseph >> ; Kevin Laatz ; Bruce >> Richardson ; Pavan Nikhilesh Bhagavatula >> >> Subject: RE: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional >> transfer >> >> Hi Chengwen, >> >> Please see my reply in-line. >> >> Thanks >> Amit Shukla >> >>> -----Original Message----- >>> From: fengchengwen >>> Sent: Wednesday, February 28, 2024 12:34 PM >>> To: Amit Prakash Shukla ; Cheng Jiang >>> ; Gowrishankar Muthukrishnan >>> >>> Cc: dev@dpdk.org; Jerin Jacob ; Anoob Joseph >>> ; Kevin Laatz ; Bruce >>> Richardson ; Pavan Nikhilesh Bhagavatula >>> >>> Subject: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional >>> transfer >>> >>> External Email >>> >>> ---------------------------------------------------------------------- >>> Hi Amit and Gowrishankar, >>> >>> It's nature to support multiple dmadev test in one testcase, and the >>> original framework supports it. >>> But it seem we both complicated it when adding support for non- >> mem2mem >>> dma test. >>> >>> The new added "direction" and "vchan_dev" could treat as the dmadev's >>> private configure, some thing like: >>> >>> >> lcore_dma=lcore10@0000:00:04.2,vchan=0,dir=mem2dev,devtype=pcie,radd >>> r=xxx,coreid=1,pfid=2,vfid=3 >>> >>> then this bi-directional could impl only with config: >>> >>> >> lcore_dma=lcore10@0000:00:04.2,dir=mem2dev,devtype=pcie,raddr=xxx,cor >>> eid=1,pfid=2,vfid=3, >>> >> lcore11@0000:00:04.3,dir=dev2mem,devtype=pcie,raddr=xxx,coreid=1,pfid= >>> 2,vfid=3 >>> so that the lcore10 will do mem2dev with device 0000:00:04.2, while >>> lcore11 will do dev2mem with device 0000:00:04.3. >> >> Thanks for the suggestion. I will make the suggested changes and send the >> next version.