From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 078F3455F1; Sat, 13 Jul 2024 02:17:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D105340655; Sat, 13 Jul 2024 02:17:39 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2044.outbound.protection.outlook.com [40.107.92.44]) by mails.dpdk.org (Postfix) with ESMTP id 4D645402E9 for ; Sat, 13 Jul 2024 02:17:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ujubu350rVaIYoXjyaoHldkkXoYOvURLfv5WQyqeBcOu0eUumnBRRGTjruump2uz6kxfhs+uMI51YaLoAKyl4hk1+uygQJyw/KGdANKMgmOYezFphRXtD9hnXcdjvyZDNaXvDkK2FFu/wIE262hSYL63rdEmVGLTR1AhvKgkXKZ8wW+cP+RobJlyldDDAiUqpGmrYVmTnlAxFrmkyFlI3UmcKRo5CVwvzBYNtz5mD9nyjP2WeqKkcrDjpuIf98UnLcJnGCKCirJ6wO7kAWQpNVO8dtMU2xfTk+Zw6FEsFU+DZV5yBh9FVdggV/K8nA6iZqrZdCf9O4CRAGkorGfK0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PLqYLz5TAT+m27V6OHnO0AOkhIdLUh4Qth2TqNA7Vsc=; b=gG/+HtlAHobKztNTtJIyguCDoj03qzWSFSgLd0UuRSBmP5KB7P9LtobVaiN51Nizg19lto4FRHJq9KP7PlhLerCVnlPfkH6e/km1QlFIK3PW/g/IecNpjAAYHwzlXTHiFVEEV1P4AadtCA7aXvaCLNLBsNgfD7bjhrRKNGdrbuErdnD9bJF43ZL7lbIRboc3CmXMmRe9WcUDn4C79brM0GUSKusdy8/QGgiCbkUxLlt74vs5Pjig8oLArOPmWFH7piUAhT0EmifeJsv0IhRWhZ7JPLTegZS2SZoaHdWNm9oIXEBQGuqNycDASp9Mhu96wah1gAnTDBkL1HMTT4Xp9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLqYLz5TAT+m27V6OHnO0AOkhIdLUh4Qth2TqNA7Vsc=; b=uKq3YdZ9BT2bzl0GoVFqG93lHJwAi7bQgNsmlGO4yMiZH4ov+JMz6FSSfU4WEg5n2/VJIxBCExeC7UVWPqvqNwkEyQ0X6FuV1RoFa7SLCgmLTr6x0+PX9/6BBJ+e+z3a0kcDSfSNw8Nn9zOpqMcBIuUavkFbIelDdQ4RT6z8lqI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ2PR12MB8808.namprd12.prod.outlook.com (2603:10b6:a03:4d0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.24; Sat, 13 Jul 2024 00:17:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7762.020; Sat, 13 Jul 2024 00:17:34 +0000 Message-ID: Date: Sat, 13 Jul 2024 01:17:30 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 06/21] net/ntnic: add basic eth dev ops to ntnic To: Serhii Iliushyk , dev@dpdk.org Cc: mko-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru References: <20240530144929.4127931-1-sil-plv@napatech.com> <20240712154737.1339646-1-sil-plv@napatech.com> <20240712154737.1339646-6-sil-plv@napatech.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240712154737.1339646-6-sil-plv@napatech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7P250CA0021.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:54f::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ2PR12MB8808:EE_ X-MS-Office365-Filtering-Correlation-Id: ca437069-d285-4298-cb54-08dca2d131b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bjZEWEg1NjNVSWkyczFvNTNyTGluN3FKaThFQ0MxMnowbnY2SndUVjcyTXlI?= =?utf-8?B?a2dqN1ZXNnloRDlvNXl4ZEI3TzlocWltcmMxeWxuQlA0eXJ5SnRTVDR6M0tk?= =?utf-8?B?SnltL3hVS1h2Yy9yODduZnc3c251Z05PTjRDWWhyQUhKaDlEZCtpa2NzTXJ6?= =?utf-8?B?OUtpREIrck5IOVk2QjIvaUNvdVpYbjdRT0tFR2lDdjFFNVFGVVVHemNXRGUy?= =?utf-8?B?czNtc2t0YmxObnQ5RE9BbnpnYjBEZE56RVl0MnVVZVpSRkppU1RCY0VWMU9v?= =?utf-8?B?WHNieUFIVXpqQmhycnZqdEF4dU9YbWlDQllXOWlDSU8xOFlwRllKWFg5VTZV?= =?utf-8?B?VEFldjY4a2JqZ3hTZ2tocWlDZUU1ZnJQd1dQWlhaQ2VTZWRXSTI2Y2grN0lj?= =?utf-8?B?ZnVOakZDb3VIdFMyN0NGK1dVUjViUmRTV3lzTVN1TUR0YlozSUprVUxxVHhB?= =?utf-8?B?MVEvQnVESE9YaDNQcDZSekh1S3pYOG1PR00rQ1RlV0pNdVF3d3JyMExUNkFH?= =?utf-8?B?eFJQeWVld0NZT2FaOW1tY2tOaWg2WWYxODQxeThpN2dBM053UG9CL1B1ZkV3?= =?utf-8?B?ZzRaZ2NXcDNSYUs5cDIzYlNwNWMrNVY0N1RaWEZBaUVNWTBUUFJLMzVwbU9G?= =?utf-8?B?Rkg5SG12UlhQZTZBVnM3ZkhlQ1BtWXpSRnh6SkUvTDUrbVM0cElqb1VNYlB3?= =?utf-8?B?c1FPZUhDNXVFY3pVUTA0QlBzOStXUXhGYUtWV25xOEI4Z1NEVGJ1RW93Qy91?= =?utf-8?B?cFhVTDJKajFzRDhiZUsrTzA0NEtTRG9CVjNKMUVlYnJ5UFRyczJOYlkzUGJy?= =?utf-8?B?dExJUklKelMwY3NmS1hqeWxwY05pY1Y1VkVPYWw2Q2tKRlBZQStwTEczS0Ft?= =?utf-8?B?Q1Y3K05VYnNQNmtLTmRRWFRVMStKTGttSi9waEk1VUNMSkhHRDZSZGRGNkp3?= =?utf-8?B?R242LzBpalBmQlhBeW5mdnhrZnhrL0pCT2I2Y3Q5N0tUQ3RlY0N5UkVhRngz?= =?utf-8?B?Qysxb3d5cTNWT2piRkRpak94MmQ3WEE3clVHM1B3WmhKUzM0eWdqSFN0QzFj?= =?utf-8?B?dWROSlVxcUs3OUxCRkVMSEVTT2J1SVdkc0haeFNpc0NGOXppS1U5OThJNGdT?= =?utf-8?B?Slh1Q2RMVTBOenZmS2s2dHlnTjk5ZCs4Nkt2cEtZN3ZOUjhkeUV2SnVpRFpW?= =?utf-8?B?Qno1ZDduYWtkRktzaThaSWNMcGZySDJtQ3h1amNLLzRzelEwSWxjNDdFUmpI?= =?utf-8?B?Z1Uvemt6dFlJeEFuZHZPcGV2RjJQVHdXMjc4bVdwN2doaDR1UnR6am9zMGdC?= =?utf-8?B?dFJIaHhXUE11bXpEaXdtZzV4SWVEUkhDMUdmelJ0K00vZDhhVktZZUFabWg5?= =?utf-8?B?TXREbXBoMEhYYUJaYXN2RzJjRENrbG5pZjR0OFBod2JWSGNGMzNlNzVoZUtM?= =?utf-8?B?d2hoc01USjVYalJuSy9vVXdUYjlHMml1RzdrQ3JPRzV0d3hiM285QmVaZFB4?= =?utf-8?B?RzdoV2xoRkFnRjFrdWwrSERobW9CSGtWaEpxa2lPQkFWYkFSSS9BQVZDSW5H?= =?utf-8?B?T2VBdk45UU1vSGZPYm10Rml2QmFZYnlNOGh0ZWMzSmkva2IzQkZCRS9iMDBO?= =?utf-8?B?YzJuWWFBOXZpdEpzcmEwZmZTOGxhSmM2NFdybGdQWDdHMzlqVHE5WU1sMHZV?= =?utf-8?B?QklERjltckpnRllqK0lBamtVRGhpRGlUdHZVK3IydjRwNG1GeEFLV3VvMGxW?= =?utf-8?B?c28xcWJOWm0rbEFFMlFXVnNOK255aEJFK1BPa1dUUjZXQjQwQU52Q0MyWDlP?= =?utf-8?B?bTM0cit4RjExbVhzVnQ3QT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b05RYngxN0RBTVhvdE5QYm1wWXJXOW9hT2JFRGVVNmpIZmZQcWJPajVLNHFP?= =?utf-8?B?UWdVT285SHNnLzFrY0dFcWpHY09QTm5SRHArckN4WEdZSVhLYmxZTXJTeUgv?= =?utf-8?B?Ri92Z1VUSUZPQzJweS9PejUvK0E1bXplZXlqZkR6Qis3dVVnS1pRK0pSZy8z?= =?utf-8?B?ajhIako0RTVqM3luWEsvdHR5S0NweFR6Zi9LMkw4bkc1Yzh5TjVoSXB1S3ZE?= =?utf-8?B?TWdraFVWWUVvdEhzaVd0N1lyS2JkT3diRzdGVlpNbkhJVU9UQ0M2WUttdTJP?= =?utf-8?B?WHg3VkxMNE51VGh6T1ZldVJDOFhxUVlRU0dKRTZBa2w0NnF5eWpWZElMbkZI?= =?utf-8?B?ZnZqRUtwYVZKNkVPakM2V3JUUFdtSEo1V1RJUEt5Y0ZjbElsdkdTWUN3Y01Y?= =?utf-8?B?UFZIR1Q0WEcvTlVoQXljS2phMEkyTjN2b3hJY2M4NW5wK3E1WVI2bFNWdllR?= =?utf-8?B?VHpSNnNFRzFyVmZ2d21LaEZoajRYNmp0cFJtenFYZ0JQT2NXMVBCVVNocnE3?= =?utf-8?B?cnBjcjNBbFVNMkRZb3M1Qyt5ZmMvWkMvTnEwMERlc0ZVYzFoak1RQjZYaWVh?= =?utf-8?B?Z29pRlJhMnpINCtzODcwRW52Rk15elZ4STRqdjF0aHFLZHB5UlNxekhISkZl?= =?utf-8?B?RzErMFNCVjNEdW1jVkYwcGkwNFhtTGNERys2aWhqR1R1V1FLaXZRSnJ5SEVW?= =?utf-8?B?eVd5eE5KWGtYMjVOU2N6aGN2N3o5bFYvdzVrdS91VGhzVkVESXhMSGozeUxD?= =?utf-8?B?NzNoQ05iMHMvNzBiOTNZdG05aVltLytBaGd2cDB1S3NwcUxoOUNJK1Bja2cx?= =?utf-8?B?eE95cHNVOHpOa1hoZXF3N2tFblFOb2d3dHhlNFFsWHpRNXowSWhJNkc2RHpt?= =?utf-8?B?V3BhOVRWU3JRTXFjTU9VMndoZjl0N25GL0I5enFBU0E4UE9tVEJHa29leksw?= =?utf-8?B?emZkMDg5NDU3ZXhmLzlsR3h0b2M4aW5SMHh2cW1yYWxUcVIxWXlweWpNQmxr?= =?utf-8?B?T1hDV0ZrdzBZS0kxRWw5QjAyV2dpaW5xclJiUHlQRkxmcmdNL2ZDd2hJZDhM?= =?utf-8?B?ZGpXMlQ5cFh3dHlSNWNhSW8zQ2wvK0F0ZWhwQTlnblgwVTUzVXZ4MW1BQU9G?= =?utf-8?B?cE1xUUg3WmNPcUIrZUtwNTFtV2lyeXllYitKTWd5cCs3S08xUTBKemRlQ3RK?= =?utf-8?B?SzBZOHlhRkV5L0xnUUsyNmQvd09BUVFVVGhURXgwcGtFRDQyQ0NoNW44TExC?= =?utf-8?B?bUJNeDIyOU0yR1hBOFA2WjZHenYyeEt2bVhiS3E5UDZmekxmWlVGbStRV0hq?= =?utf-8?B?dGN6RlVwaHlpeHpLcXZEd3JjY3V0bUVhU3dUazgxWFVQZWU5Zmk5cWNHQ1Iv?= =?utf-8?B?YTBiaEJsZ09VbHZLRmhJTkxQR1JSY0hudmFSOWhBeUZSMDIxQkN0Z0hDcEFI?= =?utf-8?B?T3JqNXlPd09uaGFWNkpsVm9GUWdSdklER2lXZVRtRzJHK2dlTHdMUUlvb29r?= =?utf-8?B?S1lUZklXT0Rqck84QWVBTmJGR0ZoQnMycFZRUGFwU25DZ2JMaUF1NEkrOG0w?= =?utf-8?B?R0dlZ3h5cWw3aE5hT0dIcFZMRUw1dEJocWlnbmQrK0JZUWZuRmZ6RHYxZGJ3?= =?utf-8?B?S09EdzNXRUxoRSs0ZWdZcE9ScUlSdENMTUNyNm1laDg0WWU5ditGWDNrRVFy?= =?utf-8?B?RWtnTEZZK0drL21KWnhlOXVIeXgvTEZubkk0dHVIbVRva1Zja1NGdG90eEln?= =?utf-8?B?OEJvUjVmbVd0MkcvMUpMbVY1czhnUGRNZmYrRWRaa3BtZnFzWXB1K1d2M3Z0?= =?utf-8?B?SHd0QmJwNGlaY0s2a1NabFlEY0FaUnkvdm5TMHZkdkUxVDlBZWIyS0l4eUtU?= =?utf-8?B?SndyOURodnY0Zy9LSExGaWVZakJzN0Zzam9BZ2UrRlZndWtpdDJaKzhjNmNa?= =?utf-8?B?TGF3NFBqMHQ1Zkt6ZHhIT3dXNW1JUjVRTGdxZyt6cjJPWHhOWVdmdCtRUDJ4?= =?utf-8?B?ZFVxOEFNSG5Ja09rNks5dk9EYVo2bkU1ZjRWU3ZqWEhZb3hOc05DNnFlL2JD?= =?utf-8?B?YVQybWhkUC9mUGNya1QxUmsxb2gvODVESnQ0SThuSUVWMUQwQUJKRWhJYjJI?= =?utf-8?Q?6rHaD+LxkQNOYK7W023Xlygi4?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca437069-d285-4298-cb54-08dca2d131b7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2024 00:17:34.7591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tdo59Y0E8B20NhKEo0CTAoUE9l/RpV6GoH2j3JDfCZY8DmRtF4V9kaJA2gSrI1VF X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8808 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/12/2024 4:47 PM, Serhii Iliushyk wrote: > Adds support for eth_dev configure, start, stop, close, and infos_get. > The internal structs of ntnic is also added and initialized. > > Signed-off-by: Serhii Iliushyk > --- > v6 > * Replace if_index with n_intf_no > * Unnecessry resources free was fixed > * Fix typo > * Useless vars were removed <...> > + > +static int > +eth_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *dev_info) > +{ > + struct pmd_internals *internals = (struct pmd_internals *)eth_dev->data->dev_private; > + > + dev_info->if_index = internals->n_intf_no; > I commented on this before, but 'if_index' is not a valid field for physical devices, so it is wrong to set it. What is the intention to set this value? <...> > +static int > +eth_dev_stop(struct rte_eth_dev *eth_dev) > +{ > + struct pmd_internals *internals = (struct pmd_internals *)eth_dev->data->dev_private; > + > + NT_LOG_DBGX(DEBUG, NTNIC, "Port %u, %u\n", > + internals->n_intf_no, internals->n_intf_no); > Why same value, 'n_intf_no', logged twice? Btw, log says "Port", and "struct pmd_internals" has 'port_id' field but it prints 'n_intf_no', is this intentionally? "struct pmd_internals" has "int n_intf_no", "uint32_t port", "uint32_t port_id", are these redundant fields? <...> > + > +static struct eth_dev_ops nthw_eth_dev_ops = { > + .dev_configure = eth_dev_configure, > + .dev_start = eth_dev_start, > + .dev_stop = eth_dev_stop, > + .dev_close = eth_dev_close, > + .dev_infos_get = eth_dev_infos_get, > +}; > This struct can be 'const'. <...> > @@ -58,6 +252,31 @@ nthw_pci_dev_init(struct rte_pci_device *pci_dev) > > snprintf(name, sizeof(name), "ntnic%d", n_intf_no); > > + internals = rte_zmalloc_socket(name, sizeof(struct pmd_internals), > + RTE_CACHE_LINE_SIZE, pci_dev->device.numa_node); > + > + if (!internals) { > + NT_LOG_DBGX(ERR, NTNIC, "%s: %s: error=%d\n", > + (pci_dev->name[0] ? pci_dev->name : "NA"), name, -1); > + return -1; > + } > + > + internals->pci_dev = pci_dev; > + internals->n_intf_no = n_intf_no; > + > + /* Setup queue_ids */ > + if (nb_rx_queues > 1) { > + NT_LOG(DBG, NTNIC, > + "(%i) NTNIC configured with Rx multi queues. %i queues\n", > + 0 /*port*/, nb_rx_queues); > What is hardcoded '0' for "(%i) NTNIC ..." And normally number of Rx/Tx queues set by user via 'rte_eth_dev_configure()' API, this initialization has queue numbers hardcoded as '1'. I assume this is for this initial version wher configure support is missing, but just reminding here in any case. > + } > + > + if (nb_tx_queues > 1) { > + NT_LOG(DBG, NTNIC, > + "(%i) NTNIC configured with Tx multi queues. %i queues\n", > + 0 /*port*/, nb_tx_queues); > + } > + > eth_dev = rte_eth_dev_allocate(name); > > if (!eth_dev) { > @@ -66,9 +285,14 @@ nthw_pci_dev_init(struct rte_pci_device *pci_dev) > return -1; > } > > - NT_LOG_DBGX(DEBUG, NTNIC, "eth_dev %p, port_id %u, if_index %u\n", > + NT_LOG_DBGX(DEBUG, NTNIC, "eth_dev %p, port_id %u, n_intf_no %u\n", > Is above change intentional? Why not add the log correct at first place instead of updating it here?