From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0040.outbound.protection.outlook.com [104.47.36.40]) by dpdk.org (Postfix) with ESMTP id BD82D16E for ; Thu, 18 May 2017 16:16:02 +0200 (CEST) Received: from BN3PR03CA0114.namprd03.prod.outlook.com (10.174.66.32) by BN1PR03MB170.namprd03.prod.outlook.com (10.255.200.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Thu, 18 May 2017 14:15:54 +0000 Received: from BN1BFFO11FD045.protection.gbl (2a01:111:f400:7c10::1:157) by BN3PR03CA0114.outlook.office365.com (2603:10b6:400:4::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14 via Frontend Transport; Thu, 18 May 2017 14:15:54 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD045.mail.protection.outlook.com (10.58.145.0) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1075.5 via Frontend Transport; Thu, 18 May 2017 14:15:54 +0000 Received: from [127.0.0.1] (B10814-12.ap.freescale.net [10.232.40.73]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v4IEFjL7015632; Thu, 18 May 2017 07:15:50 -0700 To: Jerin Jacob , References: <20170518084827.13626-1-jerin.jacob@caviumnetworks.com> CC: , , , , From: Hemant Agrawal Message-ID: Date: Thu, 18 May 2017 19:45:44 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170518084827.13626-1-jerin.jacob@caviumnetworks.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131395905546995357; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39850400002)(39400400002)(39410400002)(39860400002)(39840400002)(39450400003)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(24454002)(377454003)(9170700003)(4326008)(65826007)(86362001)(33646002)(575784001)(53546009)(966005)(305945005)(5660300001)(7246003)(7126002)(23746002)(4001350100001)(104016004)(189998001)(36756003)(498600001)(31686004)(106466001)(105606002)(31696002)(8676002)(81166006)(8936002)(47776003)(65956001)(65806001)(53936002)(8656002)(54906002)(2906002)(6306002)(53376002)(38730400002)(6246003)(77096006)(50466002)(356003)(229853002)(120886001)(50986999)(85426001)(230700001)(54356999)(2950100002)(64126003)(76176999)(6666003)(83506001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR03MB170; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD045; 1:Af2xfgZz30M5Hf0vaF8BN6ERf9fDSib4D+qEy2gkHOyq5exAOMMDTpHZzOdmxGeUdU9Zx/pad7MsQhpOwQ+V3SZqCiGArO1XuCzdsa0GesIZqAaL2zRvPmJjdV3SA2Oif7PznsbPJxII7O99tY7wJ9iY9bGYhKi6e44TTCUijHW/lP4Qa7TCxC+MjfWlpB39n89LcOUa/AHgW6HdJeuKAZn4RQtXa0X4iFEmudVb9dTEIEY9qWfsT1v5rhIdVQyU4O/ssy372o7MOZ6ZcE6swTBSw1VhGEjSOb2BXiSbJRY3BUoGt5Tuh9rERg2++lxmoopmFTHn6PCdjGlLNc+hQ6i0djiCdT93pGWKTe+KryeTabm/o7FFqZu8UzI3MnF2IdOguP4700diBVa15I9ePFonSzAbg88bNhHKes20vA6xE/CgagACJ8A6FmvD7hfjz89bTghcTSlYfg6O1a7jbD19g8LuYzq7HsKWKi83i5CtSBy0W8m9aume+TcjOS2unMzgCbbzurcUvM4XXwlYIHWF10mjheM4sfwtkcEOfwBKs+NwoXAZ9ogi/yLHIxy46uBbVdBXnV4pMn+IAmIgPo9B6h6IK8MmxB/WXQRRLJtCXgMKXkpp19NXGpXHO/Or X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PR03MB170: X-MS-Office365-Filtering-Correlation-Id: 85b8cfd8-d28d-423d-653e-08d49df86586 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:BN1PR03MB170; X-Microsoft-Exchange-Diagnostics: 1; BN1PR03MB170; 3:3S0SsKnIxl/lapUrWlSerpU4h9LehPQzxs3UQ6uflXkqv4Ql5kES93PftAtwTJckPEp+/EX1D+AwA8wGwSx5hNTTXLJvSJM6sUPaImG6xW6z5CnNDxQGHMZPemJOOz12zHbglZ8nJADoX6YVPcqVw5SOBzfaaJwAFP24Wvt0vQk7H4R+f+n2jsJrFV/fOI/NjmtYdJo/tYNrBZ8KDxBiI2K/5Cy+rrOHsL2QrkjuGQvBnSsMILKMANyF+EsNTyGPoNKV7iloLyQjQhYSzteY7NxzxL3PVoSeC8cGJtOPNUMlYe5wU9oF1lWkQDPePF4mdtVV3bWdResb0a9cumSncO3Jg1qx7TRVtAg9HY6pddKn2wouhVvSaJrT+9+7XUdLbwrixjDST9/UhhHZHf1QHS+1k56cr+xqySjuE16eGxQzF3f5nDuNIvx3abAogV2y; 25:Nny/l5wihIr+s9xUKsaAiEEmTl8FZFg8CnvD2Lc/KkqdYJQ23Yr95T7ePUopp1IlVBGySzXO3Krmuo82ZUbRPnTF6SZx1MV8K0u1EK7jPUdvHWD9S0zqKMKWfVFmsS3M7qgdbAR0jeJBnMHiA/jWUVMELB4vJbGVdIxQJSppRpTyhL0lAYdw/i5TdXSgjupJlBZwOdzKufDlGWz4+jxVPAC+mjnXOk/KElxMexMD11yj3JKH+4gU9DcgdH/+FcQOvZPOBaYRpuWTXWANz/8WL1eXaVBPSrSusl1Er7TNGg2wuQkzo2Y1cSyrqOlH6Mwg7YV6jCYdJDUOAd+jqmsHmZtg09bpPMLkd1GAsuQTutSB1Eh2wFePWw/xseVsoZ3Q0ZG2fytI0P/Uobc1Cal3gF5zEt3CIJuMxIFclIU50Dqg+GXRc/LSS/dcs9P02RL/OS6KozxAFtR/2s/8ZXTbPj5XabkPLeCo96BJw+VfwFE= X-Microsoft-Exchange-Diagnostics: 1; BN1PR03MB170; 31:0F8W9946yVPU1xgnk3n/j/Xl4QrO/0e3PWLYWiuw0GLbPDRxK8nGSlio3/q/E4I5c0hyejbAgE0H47oID1M+kPsrq5kbsCKChpcugYf3mlqusZ/m0CGh8BAjFyW0FilQtULNPN3qiWzCsNDg7dHlaBk3SBwJKMauKYZKwIPaRXbQO+G4swoBaa1dMwwbkQBLShT/L5rhD/2wXWXmOn/z8/lrPMYYJ3jA92CIB7m6BKxi/fvyZpBlIbQfeV3+bOV36szjQnS8w/YWLuQCRlcC6g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13024025)(13023025)(8121501046)(13018025)(5005006)(13015025)(13017025)(10201501046)(3002001)(93006095)(93001095)(6055026)(6096035)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123556025)(20161123563025)(20161123565025)(20161123559100)(20161123561025); SRVR:BN1PR03MB170; BCL:0; PCL:0; RULEID:(400006); SRVR:BN1PR03MB170; X-Microsoft-Exchange-Diagnostics: 1; BN1PR03MB170; 4:idPfy7qzNTpX9zjpFCOBbBRn63svj4iGAF+vdgmAcwOAfau75qQY9QeX5Pr78Wa1PxfOSOcTnPIMt0kqesphJbWLsTUsIoZ9vnQ2b5unZh8xrpzMapzyxkOxqLg3tNk6x77Hta3vGiEf6aGeQTBmkfos7bSMy0k8jv+lUjNMK7KFHf4eA7mvfXdm4/PW41e1fmK5tinaVr2oiFM3Uaf6HTpuCWvecXJi38XW/mkWMrIAxmCsP22pd4bFSN27bZkN6rMnOZVvQL8JcfY0FnBvfU30df5n3UD8VM322TWKlWIZEUK3InKa9r5XfqneUAuMTo2RVlTLoKi/uAwyLqtgUF7r43PM8s3um+ltLQyA9r0mggHftP4nZHnPDXXsii3PgNHKSBu8pxe1L3yOnc3hfZ5PUugW5RagsqfwO5SgxfYQlHfn9UDI6RAJWS0y9hc2IpnpJy8j70qDFGu1OEvTv87qm73Mk9HtxZRkB2jAPISQK9Z8RA+gzyEegHeNB2yuxBVzU6M14ho9X5+1K25BIhC9WkAGEm+xcW65fl9fjFys+aqZLSAtV3sl0qIF4gYg5KQzZI9/XuAruIG5x5CK+oly2Jm2HJlaBYAkQ38A/Gp9WeUPJxkx/oICKCBN8IPiraiPAQM0LjJJGDC+ym/gP4iTpg1f0W4Ug6pT1mwjC5Ok43fPGMEU0NYDjHz1Mp/SAs8l0qDcEdedz56ENZ9c2kZRvnKq8DNv3kVv9QER3j1iasSIfJDqW4M4Z623OuN0yzIghLaL+Nmm0izVqeRpqUEQZrzKzhrtXQcBXG7o8+0gTjPqgQPq4fNs4b3h9AP1bPOQWsweL4za/q/CxfZUNAf5a9aJJwvhdziz2S+NjRz5+2fnjRBO7XKNNQav/RWp9U/ygN/1kK4iWNlHP0T+EnbETRAa84I9vdIyaPaVicY= X-Forefront-PRVS: 0311124FA9 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN1PR03MB170; 23:zyEm0IdbnN6GilwSXXbUztfzRfTI+09nw5+oTD?= =?Windows-1252?Q?dzRLizaUidCZSj6S67jFESZpLwzJPFol1mjJItocXEwyH6NDUyqBo4D1?= =?Windows-1252?Q?7lYNehbfFuP5nMs6Io9jkLDwQSdA2hSa0zM93qLUr3zTcG2dzKkTtGiM?= =?Windows-1252?Q?i6p3JCXAXtxpr5fAZCdBZPshXFygfx5B+YdZtr2loyMI7IWkdCY8djux?= =?Windows-1252?Q?GAizpd7nK/SYPuhVnuYfU6bwhCmRLGhBdWAwUAlCemMMmPkeUeVqjsBM?= =?Windows-1252?Q?QRrRQpqJ/NLdxmB8vXc1tXOhoxsrhv0x5oq+/XSHJwyKC84cWpHjuKuY?= =?Windows-1252?Q?5J/ISOnVmOt4ExpVRdF/Q+nZLIGLUSGEpytf9D8dj3TjgjJCuIafXirm?= =?Windows-1252?Q?8Zx70qUVLA7G8Z2F9YWe73LfUte19RciCh56iWt8puj/PXqZ4GcI56lP?= =?Windows-1252?Q?sv3czBWmEPu+fp+/iSi+MSVd+02Swic1ZaGwUege731HWDZX2erpCrjc?= =?Windows-1252?Q?zG+6uaNhh+jEDAGxuFwaNrlKSMEW330+47oB2K24jb123n1cQqLtty0W?= =?Windows-1252?Q?mIgi6akPj/0foAoOeAJ26jUk2uNZrSlN/u4MGY7VSN1detppQHQK0BRW?= =?Windows-1252?Q?wYUEF9NEark3AEH+7q2DaoBZH1EdSOzI8dEvtvosS4zUerSJ2Zaa5MVi?= =?Windows-1252?Q?guUp5OHbvQvX9aiY5tnnRKujyPfNUmE5Y4atlWQsKjAjf017cJmePxpO?= =?Windows-1252?Q?2wmPy+szN96aiscG9l2GocGPmKPGKlQvR62riovHr6axLJctgoR3mA8v?= =?Windows-1252?Q?PfSjBNSJvA6ZZDfL9NxheMR6UtUak706W3JpS4zJvw4WWt3mEoGvGrag?= =?Windows-1252?Q?lwqe9rBJ/XGf0zghGWFBvajr+HBpgXSJpCO0WgZdhAhdnXCOnYjahFoO?= =?Windows-1252?Q?sPgdM/9YGpjZMH82Y5phcLcl3kyqign3rRT9cgIsU0mZzea061hUgFSI?= =?Windows-1252?Q?I4EsW828AWyF046U/oDUwXCJ3UFe7mI6mCmpRWHLCaqrUPhtoVNt2yEP?= =?Windows-1252?Q?apbq7txI184Q/o87FhiWWVqcr6y+4YDqZSbTbeKcV8fT4B7mve+bOgNK?= =?Windows-1252?Q?KD+wUMRfHLoE2p7A71zoilKlfcQXpg893sn6EjBPUiEdrxwI+eTHszb+?= =?Windows-1252?Q?/wB0Yvx5SMMrmlcJFQ5XX+rHd8owPuIavh8h7TCz5ytC8Ti6bRUaR5G2?= =?Windows-1252?Q?TldJ7aIOjfiknLs0TDdSu8IzAa8K+tO/n74LrddpxXhbOgtQjgNhip0H?= =?Windows-1252?Q?dmz8peG/4DLe81GWBvoDDgv3uo8rj3cA87IffI91eWGqecTn6igCPLWX?= =?Windows-1252?Q?kKMkTTPpsAJ9Nf9mjwio99/S3COHWXA2Jqpug0ugB0Nj5ZAH2m7kGx1F?= =?Windows-1252?Q?jDooloGpe8UZgWVOH/DiycvVxfSnAbMTEcq86ONqrGt8Ex1JauYkTVKc?= =?Windows-1252?Q?+fUmXfWVNjvyK1CFkoiDL1yq7Tt2dzKAb7VFcb6JgyuKcNg2oUo+r7bd?= =?Windows-1252?Q?S+cTb21ZROkbKpQHkWTR+RQ257FMnW7nQKFTbANHPkXritBt1XDRkUDt?= =?Windows-1252?Q?K9DwGcSixDCdeYi8Zy5sJj2nCW7Rl2XucIaGsOW8Zw65H+0wniJ3GeW+?= =?Windows-1252?Q?A7B/dGfB6/bTPlZvVPK9FqtikJgN8ReTKyON5oB5ju02we5Jhn?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR03MB170; 6:XU9/yzeaVLsid77zmwHidNaNFAomXMmw2MS3WtSod+sm3TiPc9gyPr6y6+wkh/5BQksWmeUUco/ydb0YhvDUbAguX0mIbhxGsoGdoIiB0xYc22Hgj35/HYpQMj2kpxrT/YTfUfll0EI3Vx6oJ+TjC6s3w0x0ceTrY0biNJBFNu0+jgXhqgee/WF2HPPJwCRqF/EhdxYu87esmIGH3ayTgGR+v7EevxVD2q8V0bUy/+J+qO9rS5n+O+qodISjegEsVmZJVDBY6lYmQKSw2MnoDhi5k1ioeKBZmLi2iQ8q61WCWoQwKuWheojhG3yU7EuckQkWEzRFGp9phNO3qY2KMws7QVVntfO0qlpCZlQGBgBpnkBGsqxwwxZ3tsgJK7zAfg/D0EAF+zC2Fiy7JJYBtBHfEGxhNNhOnJMb+5sTluCFyr9i6KCfc8omHMSkfcgAfF07oM1pWde5LcS3NmA7mJHzLpWH786iXpTqdrhVeEUdJnK4wCVPAsLl9S+wta1bBDLFQOdwDA4zpV1hBweuyA==; 5:9jnuMaYfIxN1E7BO+uQBnpfKFGAh+TKfEGiU5NxT4CrSKnKZBDS7tjrEzmUyoV48gBcAzgvOAyLyTNp9TxqYNRBGOA4PR19z8HzQR76aZ8o+Q6ErYfy07V4aWpU859fG+Kgg7hKYoB2MIpwMFM6dCy7A64BUCLt0BynpK8iaF4ddf7pa4IDnSrHZPMkMumhw; 24:j3V9dtodinjA8RIsKc1vEiOM3wlI+fabPaDYk71w5qLQ9GymorsatIEU1gbn6cCxnranINqnkr033Ybh7BNtrhf3cI31mqsambDaN4vB6aM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR03MB170; 7:Os/+Tzs+MuL5hQ0TZZzVkd6nteL636CIR+FCZ2LCl4/AeqVDauHTxrmVFJAw5n6Pc311AqhPHUZp99YOfhQZKwIXGoWsyHjltZgPLvTcEieuNpqeeEWqWuh9G9Dp8FAm9qKKm0qOJ7pIIhvG/yLqP//6WgiUUgh6jf1KWjETqfc/qSxSdrQTnokgEHPI5SyLap/g0S6DAYxUnR0QVqjJdxtGs9vWD5v0vLREK4hi6vCzE3Pq1Cw5Ka7voGCmrc2WxaNZdM2vSaoGdp69cWIR/Z+cQncvTvJ8uPZNo1lZeI9eb1Yg2go0bDZRkHGLAGqzOR17JTyEXsTtnbaAS+4xFw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2017 14:15:54.4499 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB170 Subject: Re: [dpdk-dev] [PATCH] eventdev: define the default value for dequeue timeout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 14:16:03 -0000 On 5/18/2017 2:18 PM, Jerin Jacob wrote: > Defining the value 0 as default value for dequeue timeout > will help the application reduce the configuration setup > if the application is interested only in default > timeout value. > > Signed-off-by: Jerin Jacob > --- > This patch will fix following error found in the event_pipeline RFC application > http://dpdk.org/dev/patchwork/patch/23799/ with event_octeontx HW driver. > > EVENTDEV: rte_event_dev_configure() line 379: dev0 invalid > dequeue_timeout_ns=0 min_dequeue_timeout_ns=853 max_dequeue_timeout_ns=873813 > --- > drivers/event/octeontx/ssovf_evdev.c | 2 ++ > lib/librte_eventdev/rte_eventdev.c | 5 +++-- > lib/librte_eventdev/rte_eventdev.h | 1 + > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c > index c80a44379..5499b1bf7 100644 > --- a/drivers/event/octeontx/ssovf_evdev.c > +++ b/drivers/event/octeontx/ssovf_evdev.c > @@ -194,6 +194,8 @@ ssovf_configure(const struct rte_eventdev *dev) > > ssovf_func_trace(); > deq_tmo_ns = conf->dequeue_timeout_ns; > + if (deq_tmo_ns == 0) > + deq_tmo_ns = edev->min_deq_timeout_ns; '0' should mean don't wait? > > if (conf->event_dev_cfg & RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT) { > edev->is_timeout_deq = 1; > diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c > index 20afc3f0e..8cafffe03 100644 > --- a/lib/librte_eventdev/rte_eventdev.c > +++ b/lib/librte_eventdev/rte_eventdev.c > @@ -369,9 +369,10 @@ rte_event_dev_configure(uint8_t dev_id, > > /* Check dequeue_timeout_ns value is in limit */ > if (!(dev_conf->event_dev_cfg & RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT)) { > - if (dev_conf->dequeue_timeout_ns < info.min_dequeue_timeout_ns > + if (dev_conf->dequeue_timeout_ns && > + (dev_conf->dequeue_timeout_ns < info.min_dequeue_timeout_ns > || dev_conf->dequeue_timeout_ns > > - info.max_dequeue_timeout_ns) { > + info.max_dequeue_timeout_ns)) { > RTE_EDEV_LOG_ERR("dev%d invalid dequeue_timeout_ns=%d" > " min_dequeue_timeout_ns=%d max_dequeue_timeout_ns=%d", > dev_id, dev_conf->dequeue_timeout_ns, > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index 94284337d..f39fbc6b9 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -409,6 +409,7 @@ struct rte_event_dev_config { > * This value should be in the range of *min_dequeue_timeout_ns* and > * *max_dequeue_timeout_ns* which previously provided in > * rte_event_dev_info_get() > + * The value 0 is allowed, in which case, default dequeue timeout used. > * @see RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT > */ > int32_t nb_events_limit; >