From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id EBDD35B38; Tue, 14 May 2019 11:32:47 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 6B47D4000D; Tue, 14 May 2019 11:32:47 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 58F9140003; Tue, 14 May 2019 11:32:47 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 X-Spam-Score: -0.9 Received: from [192.168.1.59] (host-90-232-127-248.mobileonline.telia.com [90.232.127.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id D96A140002; Tue, 14 May 2019 11:32:44 +0200 (CEST) To: dev@dpdk.org Cc: nhorman@tuxdriver.com, stephen@networkplumber.org, david.marchand@redhat.com, bruce.richardson@intel.com, "stable@dpdk.org" References: <20190508181014.7dde7580@xps13> <20190514092046.30808-1-mattias.ronnblom@ericsson.com> <20190514092046.30808-2-mattias.ronnblom@ericsson.com> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: Date: Tue, 14 May 2019 11:32:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190514092046.30808-2-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 May 2019 09:32:48 -0000 On 2019-05-14 11:20, Mattias Rönnblom wrote: > > Bugzilla ID: 114 > Bugzilla ID: 276 > I don't know which, if any, of these bugs you want to address in any stable releases. If fixing bug 276 "rte_rand() bit 31 and 63 are always zero" is enough, then one could either split this patch set in two (w/ only the new rte_rand() going into stable), or develop a smaller fix based on lrand48(). Since the old implementation was an inline function, any fix will require a recompilation. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BD1D4A00E6 for ; Tue, 14 May 2019 11:32:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 03FC85F16; Tue, 14 May 2019 11:32:50 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id EBDD35B38; Tue, 14 May 2019 11:32:47 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 6B47D4000D; Tue, 14 May 2019 11:32:47 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 58F9140003; Tue, 14 May 2019 11:32:47 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 X-Spam-Score: -0.9 Received: from [192.168.1.59] (host-90-232-127-248.mobileonline.telia.com [90.232.127.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id D96A140002; Tue, 14 May 2019 11:32:44 +0200 (CEST) To: dev@dpdk.org Cc: nhorman@tuxdriver.com, stephen@networkplumber.org, david.marchand@redhat.com, bruce.richardson@intel.com, "stable@dpdk.org" References: <20190508181014.7dde7580@xps13> <20190514092046.30808-1-mattias.ronnblom@ericsson.com> <20190514092046.30808-2-mattias.ronnblom@ericsson.com> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: Date: Tue, 14 May 2019 11:32:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190514092046.30808-2-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190514093241.jFBa3eAJmJOb71uHOCJArXX1pFz2flybFeH3Oo5gyEg@z> On 2019-05-14 11:20, Mattias Rönnblom wrote: > > Bugzilla ID: 114 > Bugzilla ID: 276 > I don't know which, if any, of these bugs you want to address in any stable releases. If fixing bug 276 "rte_rand() bit 31 and 63 are always zero" is enough, then one could either split this patch set in two (w/ only the new rte_rand() going into stable), or develop a smaller fix based on lrand48(). Since the old implementation was an inline function, any fix will require a recompilation.