From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 809C2DE3
 for <dev@dpdk.org>; Mon,  8 Oct 2018 10:05:56 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 57D93400076; Mon,  8 Oct 2018 08:05:55 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 8 Oct 2018
 09:05:49 +0100
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
CC: <gaetan.rivet@6wind.com>, <ophirmu@mellanox.com>, <qi.z.zhang@intel.com>, 
 <ferruh.yigit@intel.com>
References: <20180907230958.21402-1-thomas@monjalon.net>
 <20181007220933.4533-1-thomas@monjalon.net>
 <20181007220933.4533-2-thomas@monjalon.net>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <ac89d3bc-ede4-4acb-2318-ffc6cb2bc5e7@solarflare.com>
Date: Mon, 8 Oct 2018 11:05:07 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20181007220933.4533-2-thomas@monjalon.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24142.003
X-TM-AS-Result: No-2.354600-8.000000-10
X-TMASE-MatchedRID: fgYTp5XatxYOwH4pD14DsPHkpkyUphL9uLwbhNl9B5X4JyR+b5tvoOln
 +pgUTqXBuIA/hwcjvFZuTK43U2r81q23CuWprcjSY1bQMCMvmn59LQinZ4QefL6qvLNjDYTwIq9
 5DjCZh0wUGm4zriL0oQtuKBGekqUpm+MB6kaZ2g5vCucFWcjxu6zNTHCRsIqH3eNi1U8Cxo1ZqZ
 HIkKY8EH+ceUmgasVWu9OpLSPpXFlCeJptp1nnkU8b1O32STIWW32FYfw14oWHzGTHoCwyHhlNK
 Sp2rPkW5wiX7RWZGYs2CWDRVNNHuzflzkGcoK72
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--2.354600-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24142.003
X-MDID: 1538985956-piiWDqs1-occ
Subject: Re: [dpdk-dev] [PATCH v3 1/3] drivers/bus: move driver assignment
 to end of probing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Oct 2018 08:05:56 -0000

On 10/8/18 1:09 AM, Thomas Monjalon wrote:
> The PCI mapping requires to know the PCI driver to use,
> even before the probing is done. That's why the PCI driver is
> referenced early inside the PCI device structure. See
> 1d20a073fa5e ("bus/pci: reference driver structure before mapping")
>
> However the rte_driver does not need to be referenced in rte_device
> before the device probing is done.
> By moving back this assignment at the end of the device probing,
> it becomes possible to make clear the status of a rte_device.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>