* [dpdk-dev] [PATCH] net/ring: fix adding MAC addresses
@ 2017-05-26 13:18 Charles (Chas) Williams
2017-05-30 12:45 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Charles (Chas) Williams @ 2017-05-26 13:18 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, Charles (Chas) Williams
When .mac_addr_add() was changed to allow a return code, ring was changed
to return -ENOTSUP. This changes the behavior of the rte_ring driver in
a way that does not maintain backward compatibility. Additionally, if
the intent is to return -ENOTSUP, you could simply not define the stubs.
Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")
Signed-off-by: Chas Williams <ciwillia@brocade.com>
---
drivers/net/ring/rte_eth_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 87d2258..d4dce95 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -230,7 +230,7 @@ eth_mac_addr_add(struct rte_eth_dev *dev __rte_unused,
uint32_t index __rte_unused,
uint32_t vmdq __rte_unused)
{
- return -ENOTSUP;
+ return 0;
}
static void
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ring: fix adding MAC addresses
2017-05-26 13:18 [dpdk-dev] [PATCH] net/ring: fix adding MAC addresses Charles (Chas) Williams
@ 2017-05-30 12:45 ` Ferruh Yigit
2017-05-30 12:49 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-05-30 12:45 UTC (permalink / raw)
To: Charles (Chas) Williams, dev; +Cc: bruce.richardson
On 5/26/2017 2:18 PM, Charles (Chas) Williams wrote:
> When .mac_addr_add() was changed to allow a return code, ring was changed
> to return -ENOTSUP. This changes the behavior of the rte_ring driver in
> a way that does not maintain backward compatibility. Additionally, if
> the intent is to return -ENOTSUP, you could simply not define the stubs.
>
> Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")
>
> Signed-off-by: Chas Williams <ciwillia@brocade.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ring: fix adding MAC addresses
2017-05-30 12:45 ` Ferruh Yigit
@ 2017-05-30 12:49 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-05-30 12:49 UTC (permalink / raw)
To: Charles (Chas) Williams, dev; +Cc: bruce.richardson
On 5/30/2017 1:45 PM, Ferruh Yigit wrote:
> On 5/26/2017 2:18 PM, Charles (Chas) Williams wrote:
>> When .mac_addr_add() was changed to allow a return code, ring was changed
>> to return -ENOTSUP. This changes the behavior of the rte_ring driver in
>> a way that does not maintain backward compatibility. Additionally, if
>> the intent is to return -ENOTSUP, you could simply not define the stubs.
>>
>> Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")
>>
>> Signed-off-by: Chas Williams <ciwillia@brocade.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-30 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-26 13:18 [dpdk-dev] [PATCH] net/ring: fix adding MAC addresses Charles (Chas) Williams
2017-05-30 12:45 ` Ferruh Yigit
2017-05-30 12:49 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).