From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 816972B82 for ; Tue, 30 May 2017 14:49:24 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 May 2017 05:49:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,418,1491289200"; d="scan'208";a="92866059" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 30 May 2017 05:49:19 -0700 From: Ferruh Yigit To: "Charles (Chas) Williams" , dev@dpdk.org Cc: bruce.richardson@intel.com References: <1495804685-26501-1-git-send-email-ciwillia@brocade.com> <18fd544d-1a3c-b4c7-67c8-0b6502b28bf5@intel.com> Message-ID: Date: Tue, 30 May 2017 13:49:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <18fd544d-1a3c-b4c7-67c8-0b6502b28bf5@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ring: fix adding MAC addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2017 12:49:25 -0000 On 5/30/2017 1:45 PM, Ferruh Yigit wrote: > On 5/26/2017 2:18 PM, Charles (Chas) Williams wrote: >> When .mac_addr_add() was changed to allow a return code, ring was changed >> to return -ENOTSUP. This changes the behavior of the rte_ring driver in >> a way that does not maintain backward compatibility. Additionally, if >> the intent is to return -ENOTSUP, you could simply not define the stubs. >> >> Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address") >> >> Signed-off-by: Chas Williams > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.