From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75EFC42B71; Mon, 22 May 2023 14:43:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06CEB40EE7; Mon, 22 May 2023 14:43:55 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 000A140EE5 for ; Mon, 22 May 2023 14:43:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684759433; x=1716295433; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=sYNpukLzPrPgouuqjJgSTNHKhqZM+mrWPJiRP9rIeMs=; b=fjIBoZXWBqn92vSuWCpxVOy24IoyLKj1BS1VMPC1ATn1nA+W9YyEPWvG HYDJSOoDprYNO/nx0NwlQmxtG4GxRIOJTeOHqZ2jYhcoPriykwzqo59eS Dq5aBXihOFVLA+HPESUyxcIXi85hO6JqWkAkMfNQqdWkWLa9k9lD23/zV aOMUHySqPb03ub6CjP+jCIxDvSPSWzZ1HwKtOYmQSRej2z6PM1jGO1NyE UHc++gkbiLBQkd0UFG2KBhGIoxVDzYq0miiIp6bCqAd0fI8G7xBhTEagI oW9MF6zz7wPc0BXqCvx0Fnib91dBiG7I2Ghp2HcPMiEE/bm8nbg7xj5R1 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="381135549" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="381135549" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 05:43:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="697630837" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="697630837" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 22 May 2023 05:43:49 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 22 May 2023 05:43:47 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 22 May 2023 05:43:46 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 22 May 2023 05:43:46 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 22 May 2023 05:43:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TdrRmAmacetHd3+8VXCucCJHJSx7Uz4Xx/6eY4h3hRzyKgo7m69IfY4DOJmKZzvaTO3YUoiilTcB1fwzbxIz7XInhMg/PqFQmJ9lyziFiv0+WFpyaByom2VuMM6kQrktEKm+Z+9iN/pKAwLQmHehZZCJyFfYQ19qDdb6KyrVZtxNxryovUkYAB4QAN2nbLGLNKGLNrL4en/LRUFE9CXf7A/F80siUzIJwsnEJqYAZkSAH2o5fPXRo80JP16CYDbsL5Ttx5VRtBpFVs5BWEHjyJnomhRVAAQfYy/xU2GjeodqCY5CTd70cPNTdWXPZ4N1TE/63aJ2OWhlOyhG/vO13w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZJSawFgkMupJ9kq30S/PLNgHPvKHmArmp+pUTIZGks=; b=ht5BcSzfVUeMxnvqLC+NM4oF5+ltEV4kuV97OSflkCSCYUul9idmzn+9Ift3h/n7iaUjeM8+SZsYBZOQEcrCPLeOZ95NYVdE1H2lKm5Eoh2KSDATrkt4yY5giMQrMHKMEQmdu5ye00ua8PXbfaupXzGPmVUsRFmj2FwLy3p2/GLmRHzdd8R3jficOoyMMFTqgQ5cDm7Py0tNusckwRzoL6/mCLT3OB35EyPhodpa4ZDabazdRTcXKFUVztM1/HJDpj1C0hBszhSDE6y5VLeRp9ZvTJOw+a7ZL/6ue2lgsFLiZL2fMoL/KCginH+7E+SeFmpLIxPU6FWb2yuaxBOEdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by SN7PR11MB7437.namprd11.prod.outlook.com (2603:10b6:806:348::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Mon, 22 May 2023 12:43:44 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%5]) with mapi id 15.20.6411.028; Mon, 22 May 2023 12:43:44 +0000 Message-ID: Date: Mon, 22 May 2023 13:43:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [External] Re: [PATCH] eal: fix eal init may failed when too much continuous memsegs under legacy mode Content-Language: en-US To: Fengnan Chang , Thomas Monjalon CC: , Lin Li References: <20230516122108.38617-1-changfengnan@bytedance.com> From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB8P191CA0021.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::31) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|SN7PR11MB7437:EE_ X-MS-Office365-Filtering-Correlation-Id: a63aa502-a675-4314-6a6c-08db5ac22dcc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +SPWC6r0dvGh4eGdmSTNs4nReqGUomQYWDMjAbchPiK4xr4wDnayvhcUdPnimqPxYXEx3errs32IRZLEMLoLlOMr+cNJZuvWLKplq9YYo8k6+B7bzlKaQALHS1iFqROrL5LF+ycHE3glbzDOoY3j4s49kFvotbi5on8v2XT6/XjcgYyLcwj1/md+vz1PWaKtbjFIY6CZTVRe8lQi6YNfwmAxnvR8+TB/F/L3zthQiB3vmXDX38zxnquW7EFNXPAGJYm/ZUJHPbRKNNvTAnBnedPXJjZ0a1+kd9pCj8h1TSTRoSZ1uzPSSsv61Z/f6hI/YzTVFjqUjWvIFq8H1OPJdDa6+s3xCCJ5HKGBbsw2mO+MCRzA5L4A9OWxRMvei/+IXRuZKr7+qcGg0El7s2tPjGfDs/WCj6j27pEeD418mO9ePQDVZU0N/gLlbfqwURLnf7+5pjQb4rS6/YCK7Ut8qxGi6sDFNd1RVsld0d6KTLrGi87VdoONZuRgbpUPnauw53DzBh7F5c2J1ngfjfUkNGmNL5p6BA9keKvPemECSFPvzPDaeN9g+UKl92hKM9qUdQUKyjv8FcsGr9YBebL/ZZ6EoAUZOCy3TUz7TkI5v2+5UwaCeZip2KdQJUGD6h8mIohTFDtg8wlhr+qHC/qtlw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(346002)(366004)(39860400002)(136003)(376002)(451199021)(6666004)(478600001)(31686004)(66556008)(6512007)(6506007)(26005)(53546011)(66476007)(4326008)(316002)(41300700001)(66946007)(110136005)(6486002)(8676002)(8936002)(5660300002)(31696002)(86362001)(2906002)(83380400001)(38100700002)(2616005)(186003)(36756003)(82960400001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGpCOUh5NUx3K1hwLzgwK2orTnk3TFpETDB5R1FwWElScFhEYXpmaE1xTEpi?= =?utf-8?B?UnpQdU13SXk5dnpQRGVSUmMxa3N5a3NIK3lGVHBlQXVuaWhqMWFYTWNRREE4?= =?utf-8?B?Nml1QnRPMHk0aWlQUkJTa0drVEN4SVZuR3JoN2tjNHdjT3dmR0JodmV1OVM2?= =?utf-8?B?aDlIeE96WnEwWkdJTWcwS3VuVTJibEJzR2REeEpTWEJ5V2RPOGFTVEFka3BV?= =?utf-8?B?U2ZWTWpMaWk5eENTcnBJOUZPa3ZOUktCanEyWjBIWFdGaElSL25TeUt3VlB5?= =?utf-8?B?ajNYcFMrd3FFdHFhSEsxY296TUZBdC9RS21uY1BHdFo4RUhiTEM1VWJuZ0Jm?= =?utf-8?B?dkNDK05hRHRzUTIreHUrcXJVOXoyUlJSTmxzb0Fxd0JkVVBjOXUreWEzN3JN?= =?utf-8?B?bHN1bjBJcTJSeFZJZkZNY1JaQzhLQ0pYdFZ1WFlNbHVkMjdmQmxEelVVakxT?= =?utf-8?B?dzRCdXVxS3EyQjUwRFRYSlFDc1E4ZHNKVTZBYitrTkk2WC8vMnlvcVZ1MUY4?= =?utf-8?B?M3JuZVYyandMSS83TmVuZk9nbENPWkZjQVZuTGw5NmZtd1cyclBVUm1uTjVQ?= =?utf-8?B?cXRDVTgvbGhyY3h0dGI4dUhIdFJUMjg1MHhCMGpETnh2TUNFVWxFdkhvc20z?= =?utf-8?B?dHV4M29oKzdhTkNxbjhoU3FJZTR6b1dyNXlLVTI5TTN1QVgyTHl3RUxjU0Vp?= =?utf-8?B?U2R0YWNtbndRYWxKTEZjbFVtcWdRSHBIU2F5ZE04Z3ZFaWg0ejI4aVBXWVlk?= =?utf-8?B?bmhMM2tMUzNKMnpmU2JPeUN4QlNTRXovZUlmNlNTd3BNenVDNyszWUswRUcy?= =?utf-8?B?a0szNm1QT2N5bUppSjdNR3Q1RnZZcERGd0tmT2U4QitxQjJUUkFHNlMvYTZZ?= =?utf-8?B?MkNtd25paGU5ZFFOd3g1cGppTUhZN0ZCSVBpeHRJZjNEVnY0QWZ4RWc1a04v?= =?utf-8?B?T3hkeElnTnJ6MC9MVTVKY0pTQld0RzIxMmZoYkpJaFBOWkdTR3RXRWFPbHpM?= =?utf-8?B?L1BHeDhpc2tLMXRwNnROM2Z2eUNvUzQ0a095dzhHVG1sd2Z6STlTYVZhdXJU?= =?utf-8?B?Ylhxc3RCSWFQWnBkSHozc29kbm1yUFdzQmhhdi9DeGtwN2F1eHdndzZjTFFE?= =?utf-8?B?b0pCZ09nTlFCckVDOWExR1Vjclo2dUdrdk9FK21LU2ZNcjBybXBjcS9DZVhh?= =?utf-8?B?YTBSRm5vRUVUOG56Z1hvMXFia1pBRnJxVmVRWUppQlljd0szSXRVaDlQSk43?= =?utf-8?B?LzNLZFIxakI1KzUzbWZKeXJSMzhiT2NiaU1NbStvVmdlY3hJTWdUN3FDZGFz?= =?utf-8?B?OHlOVm91U25VZ1BaMk1LVWdsZU4reFg2Mjl5b25zWE54cEN6ZnFialBsTFpC?= =?utf-8?B?dWtLVUc5OC9qM3YxYzNFR29mSHB0ekJUdmVidlZSSEhnbjRGQjZ0TlpsaHp0?= =?utf-8?B?aTh5Mkx0TzcvZWg3d0xOc1MyL2xBZlI3alR2amN0eVd3eFJIQWdmSHlFeXp6?= =?utf-8?B?c0lRTXBtSFBSVW0xOVFsT3BQeG5URlpKYkVQdEwrRTFsN0I4Ym5ycnErNHJ0?= =?utf-8?B?dmZMck9pVHQ0R0xKbTdPczV2TnRZbkNaOVFPekV6ZWVXM21QN0x0ZzFvSzZE?= =?utf-8?B?d0M5cEpMUFBNVUovMUxqUHFxOEk2UjdybUtWL2xFWk5LckJERHluOTlJQk5D?= =?utf-8?B?TUZyUklYek5hU05EVHZId0ovdzZJWi9rdTRIOEVsR3RNWnBUZFJhOVhRSHZF?= =?utf-8?B?SmkrTUJBbXpXZVVDUlBhWVJHNGNYdEJwUE1UQlhqUjY3QkJkRFVuUmxYWVA3?= =?utf-8?B?dTlKbHhmOXNtcm9Ubjh0OGhmMjBtSGRqcnVNWUhQVXpSWDNUL09nM0FreHFq?= =?utf-8?B?VlRFemVSU2lQOStWN1kwdVZYUlRCUWhDS1o1WmtJTjNLZU1Xb1k5MG1wUXlF?= =?utf-8?B?MXFIWUlzMUtKVXhkd2NZUC9CK05mTUpSUDI0bGp5a01yL25oOVZrWkRSNnFX?= =?utf-8?B?TnNqRHcvR05XbGx4UWNXSmN5UUhFUnlyVXI1K1RiM1ZIV1ZQQ2lXZVZYZk9n?= =?utf-8?B?Z3lLcmtqSEtBMHBJL08wbzl3dllFT08rMXRHN3pxZGUvNTlWWmJkZXBFUm1M?= =?utf-8?B?VnlKQmhEaHRoMldmTitNUzBkcVhKRUM3UFRWejBWaG1qbmFWUlB5Uk8xaXRp?= =?utf-8?B?S2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: a63aa502-a675-4314-6a6c-08db5ac22dcc X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 12:43:44.4449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +8tAGZnkcsgVP29AeAmK50fgG0jpSOtvwCXSDTNWJTwPf+YrpxWMhEB+05Z78br0uNP6vYfW9RiSar7w7K1D52hD1/KSfSSk8GEvhnjn7vs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7437 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/22/2023 1:09 PM, Fengnan Chang wrote: > Burakov, Anatoly 于2023年5月20日周六 23:03写道： >> >> Hi, >> >> On 5/16/2023 1:21 PM, Fengnan Chang wrote: >>> Under legacy mode, if the number of continuous memsegs greater >>> than RTE_MAX_MEMSEG_PER_LIST, eal init will failed even though >>> another memseg list is empty, because only one memseg list used >>> to check in remap_needed_hugepages. >>> >>> For example: >>> hugepage configure: >>> 20480 >>> 13370 >>> 7110 >>> >>> startup log: >>> EAL: Detected memory type: socket_id:0 hugepage_sz:2097152 >>> EAL: Detected memory type: socket_id:1 hugepage_sz:2097152 >>> EAL: Creating 4 segment lists: n_segs:8192 socket_id:0 hugepage_sz:2097152 >>> EAL: Creating 4 segment lists: n_segs:8192 socket_id:1 hugepage_sz:2097152 >>> EAL: Requesting 13370 pages of size 2MB from socket 0 >>> EAL: Requesting 7110 pages of size 2MB from socket 1 >>> EAL: Attempting to map 14220M on socket 1 >>> EAL: Allocated 14220M on socket 1 >>> EAL: Attempting to map 26740M on socket 0 >>> EAL: Could not find space for memseg. Please increase 32768 and/or 65536 in >>> configuration. >> >> Unrelated, but this is probably a wrong message, this should've called >> out the config options to change, not their values. Sounds like a log >> message needs fixing somewhere... > > In the older version, the log is: > EAL: Could not find space for memseg. Please increase > CONFIG_RTE_MAX_MEMSEG_PER_TYPE and/or CONFIG_RTE_MAX_MEM_PER_TYPE in > configuration. > Maybe it's better ? > It was better indeed, but this seems to have to do with the fact that RTE_STR doesn't treat valid macros like a string, it expands them. So, e.g. `RTE_STR(INVALID_MACRO)` gets translated to `INVALID_MACRO` string, while `RTE_STR(RTE_MAX_LCORE)` gets translated to whatever actual value `RTE_MAX_LCORE` has (128 in my case). Using `_RTE_STR` in place of `RTE_STR` fixes the issue, but i'm not sure if it's the right solution, as `_RTE_STR` is prefixed with an underscore, which implies it's not to be used directly. +Thomas thoughts? -- Thanks, Anatoly