From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BD4AA0556; Thu, 20 Feb 2020 11:13:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD1711BFB5; Thu, 20 Feb 2020 11:13:47 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 6580B1BFAE for ; Thu, 20 Feb 2020 11:13:46 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id t3so3919918wru.7 for ; Thu, 20 Feb 2020 02:13:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=UJcSCDOft9/+6iA5NOQgYF3DmcfiD+iMQSUZFYcWcd8=; b=Fig7XNvy8CRMGnxTBOWyqOjWIBPVtyLyUOaYONm9LFvQxwrIzs3hclTsyOcmMxrbB2 k12qVLohLF+1zs9Dy5c6Wd6veWDKzu6O/e6QS9GSG49HsQVM41RUfIjaVOBlcyHK5Dmw sKsUWtL6cMe5brxdvre8j+JzfCXEsPdEd3LGKOaduYIpMic3m/ai16KoR6QKMC0Dbv+y 8KCCaMRnkTl+9oYcVtIeTKobVPA/Gpw7FYiGJMaTU6tkGdBiBHAR++6B6gAi5rI0MjLp wj0SZpHnH84FR0uSGGXu/+l05PxKj7iHXMDF5z9v95/iQjQbO2roHR5r5c90kgY/9lCh oPwg== X-Gm-Message-State: APjAAAW3V2vuyM+9wlTg8UCsEX/BsUEs+L/489J5tqeK/QAUTz8YIgM2 cUsRhr3i/NQIu7NDdLrEURMVedm9uJU= X-Google-Smtp-Source: APXvYqwyUxDN7HNa14XiCJtIR/NhN/5nvKtn90X1rtlpDecsQamaSNZESDWrxALK63m9YvIO8PXD/A== X-Received: by 2002:adf:facc:: with SMTP id a12mr13604076wrs.100.1582193626041; Thu, 20 Feb 2020 02:13:46 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id n8sm3717339wrx.42.2020.02.20.02.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 02:13:44 -0800 (PST) Message-ID: From: Luca Boccassi To: Ruslan Babayev , dev@dpdk.org Cc: "Richardson, Bruce" Date: Thu, 20 Feb 2020 10:13:44 +0000 In-Reply-To: <20200219191326.35842-1-ruslan@babayev.com> References: <20200219191326.35842-1-ruslan@babayev.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: add combined libs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-02-19 at 11:13 -0800, Ruslan Babayev wrote: > Add combined libdpdk.a and libdpdk.so libs for Meson similar to how > it's done for Make builds >=20 > Signed-off-by: Ruslan Babayev < > ruslan@babayev.com > > > --- > buildtools/group-libs.sh | 2 ++ > buildtools/meson.build | 1 + > meson.build | 17 +++++++++++++++++ > 3 files changed, 20 insertions(+) > create mode 100755 buildtools/group-libs.sh >=20 > diff --git a/buildtools/group-libs.sh b/buildtools/group-libs.sh > new file mode 100755 > index 000000000..b6e4c1c35 > --- /dev/null > +++ b/buildtools/group-libs.sh > @@ -0,0 +1,2 @@ > +#!/bin/sh > +echo 'GROUP (' $(echo $* | xargs -n1 basename | sort | xargs) ')' > diff --git a/buildtools/meson.build b/buildtools/meson.build > index 9812917e5..eac8bc4ff 100644 > --- a/buildtools/meson.build > +++ b/buildtools/meson.build > @@ -6,6 +6,7 @@ subdir('pmdinfogen') > pkgconf =3D find_program('pkg-config', 'pkgconf', required: false) > pmdinfo =3D find_program('gen-pmdinfo-cfile.sh') > list_dir_globs =3D find_program('list-dir-globs.py') > +group_libs =3D find_program('group-libs.sh') > check_experimental_syms =3D find_program('check-experimental-syms.sh') > ldflags_ibverbs_static =3D find_program('options-ibverbs-static.sh') > =20 > diff --git a/meson.build b/meson.build > index b7ae9c8d9..eb6974d35 100644 > --- a/meson.build > +++ b/meson.build > @@ -61,6 +61,23 @@ configure_file(output: build_cfg, > install_dir: join_paths(get_option('includedir'), > get_option('include_subdir_arch'))) > =20 > + > +custom_target('group_shared_libs', > + input: dpdk_libraries, > + output: 'libdpdk.so', > + capture: true, > + install: true, > + install_dir: get_option('libdir'), > + command: [group_libs, '@INPUT@']) > + > +custom_target('group_static_libs', > + input: dpdk_static_libraries + dpdk_drivers, > + output: 'libdpdk.a', > + capture: true, > + install: true, > + install_dir: get_option('libdir'), > + command: [group_libs, '@INPUT@']) > + > # for static builds, include the drivers as libs and we need to > "whole-archive" > # them. > dpdk_drivers =3D ['-Wl,--whole-archive'] + dpdk_drivers + ['-Wl,--no- > whole-archive'] Hi, As far as I'm aware all usage of the old hacky linker script can be replaced with pkg-config, and that's why it was left behind. Same for the static archive. Is there any use case that pkg-config doesn't cover? --=20 Kind regards, Luca Boccassi