From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7901C39EA for ; Thu, 21 Apr 2016 13:48:10 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP; 21 Apr 2016 04:48:09 -0700 Message-Id: Date: 21 Apr 2016 04:48:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,512,1455004800"; d="scan'208";a="963460575" Received: from pczapiex-mobl.ger.corp.intel.com (HELO Sent) ([10.217.248.212]) by fmsmga002.fm.intel.com with SMTP; 21 Apr 2016 04:48:04 -0700 Received: by Sent (sSMTP sendmail emulation); Thu, 21 Apr 2016 13:48:03 +0200 From: Michal Jastrzebski To: cristian.dumitrescu@intel.com, roy.fan.zhang@intel.com, jasvinder.singh@intel.com Cc: dev@dpdk.org, Slawomir Mrozowicz Subject: [dpdk-dev] [PATCH v2] examples/qos_sched: fix negative loop bound X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2016 11:48:10 -0000 Fix issue reported by Coverity. Date: Thu, 21 Apr 2016 13:47:35 +0200 Message-Id: <1461239256-8104-4-git-send-email-michalx.k.jastrzebski@intel.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski@intel.com> References: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski@intel.com> From: Slawomir Mrozowicz Coverity ID 30704: Negative loop bound negative_returns: Using unsigned variable n_tokens in a loop exit condition. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Slawomir Mrozowicz --- examples/qos_sched/args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c index 3e7fd08..7a98e5c 100644 --- a/examples/qos_sched/args.c +++ b/examples/qos_sched/args.c @@ -162,7 +162,7 @@ static int app_parse_opt_vals(const char *conf_str, char separator, uint32_t n_vals, uint32_t *opt_vals) { char *string; - uint32_t i, n_tokens; + int i, n_tokens; char *tokens[MAX_OPT_VALUES]; if (conf_str == NULL || opt_vals == NULL || n_vals == 0 || n_vals > MAX_OPT_VALUES) -- 1.9.1