DPDK patches and discussions
 help / color / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, dev@dpdk.org, zhihong.wang@intel.com
Cc: stephen@networkplumber.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 20.02 v2] net/virtio-user: do not close tap when disabling queue pairs
Date: Wed, 15 Jan 2020 12:18:50 +0100
Message-ID: <acbaa4eb-2c42-470c-da9f-7a710fd89b50@redhat.com> (raw)
In-Reply-To: <20191125081440.136906-1-tiwei.bie@intel.com>



On 11/25/19 9:14 AM, Tiwei Bie wrote:
> Do not close the tap fds when disabling queue pairs, instead,
> we just need to unbind the backend. Otherwise, tap port can be
> destroyed unexpectedly.
> 
> Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
> Cc: stable@dpdk.org
> 
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> v2:
> - Squash attach_queue/detach_queue into one routine (Stephen);
> - Use initializer instead of memset (Stephen);
> - Drop the cast to void * (Stephen);
> 
>  drivers/net/virtio/virtio_user/vhost_kernel.c | 34 +++++++++++++++----
>  .../net/virtio/virtio_user/vhost_kernel_tap.c | 34 ++++++++++++-------
>  .../net/virtio/virtio_user/vhost_kernel_tap.h |  8 +++++
>  drivers/net/virtio/virtio_user/vhost_user.c   |  4 +++
>  .../net/virtio/virtio_user/virtio_user_dev.c  |  5 ++-
>  .../net/virtio/virtio_user/virtio_user_dev.h  |  1 +
>  6 files changed, 65 insertions(+), 21 deletions(-)

Applied to dpdk-next-virtio/master

Thanks,
Maxime


      parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19  6:29 [dpdk-dev] [PATCH 20.02] " Tiwei Bie
2019-11-19 16:36 ` Stephen Hemminger
2019-11-20  2:46   ` Tiwei Bie
2019-11-25  8:14 ` [dpdk-dev] [PATCH 20.02 v2] " Tiwei Bie
2020-01-14  9:16   ` Maxime Coquelin
2020-01-15 11:18   ` Maxime Coquelin [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acbaa4eb-2c42-470c-da9f-7a710fd89b50@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox