From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7564A0547; Fri, 9 Apr 2021 16:37:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9550414106B; Fri, 9 Apr 2021 16:37:46 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id A95124014D for ; Fri, 9 Apr 2021 16:37:44 +0200 (CEST) IronPort-SDR: 0NOl7DYiR1+mMMjS9hkW82wcyptDVH5BUgQnw1RR8aUZYupUGwLvqPaXy8PIZhJkBUk3Xbmwn5 5Nvn3vNE51Ag== X-IronPort-AV: E=McAfee;i="6000,8403,9949"; a="180902357" X-IronPort-AV: E=Sophos;i="5.82,209,1613462400"; d="scan'208";a="180902357" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 07:37:43 -0700 IronPort-SDR: mRm8jXeZHffMjZdmLzAoJ7Z7a93/0HdRYynjbRZSQweTRx3m3uceg/0dlVlCleWzJSMojZEqn1 uLvxbLC5XKhA== X-IronPort-AV: E=Sophos;i="5.82,209,1613462400"; d="scan'208";a="422752665" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.203.45]) ([10.213.203.45]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 07:37:42 -0700 To: Jiawen Wu , dev@dpdk.org References: <20210406093048.2923172-1-jiawenwu@trustnetic.com> <20210406093048.2923172-3-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 9 Apr 2021 15:37:41 +0100 MIME-Version: 1.0 In-Reply-To: <20210406093048.2923172-3-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 2/6] net/ngbe: add device IDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/6/2021 10:30 AM, Jiawen Wu wrote: > Add device IDs for Wangxun 1Gb NICs, and register rte_ngbe_pmd. > > Signed-off-by: Jiawen Wu <...> > +static struct rte_pci_driver rte_ngbe_pmd = { > + .id_table = pci_id_ngbe_map, > + .drv_flags = RTE_PCI_DRV_NEED_MAPPING | > + RTE_PCI_DRV_INTR_LSC, > +}; > + > +RTE_PMD_REGISTER_PCI(net_ngbe, rte_ngbe_pmd); > +RTE_PMD_REGISTER_PCI_TABLE(net_ngbe, pci_id_ngbe_map); At this stage driver->probe() will be called if matched device found, it is unlikely that the code will be run at this stage, but anyway to not leave the code in a state that it will for sure crash, can you add the 'probe()'/'remove()' functions here even if it is empty and just returns?