* [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
@ 2019-04-24 15:26 Anatoly Burakov
2019-04-24 15:26 ` Anatoly Burakov
2019-05-09 17:50 ` Ferruh Yigit
0 siblings, 2 replies; 10+ messages in thread
From: Anatoly Burakov @ 2019-04-24 15:26 UTC (permalink / raw)
To: dev
In no-shconf mode, there is no need to clean runtime directory
because it's not created in the first place.
Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 30138b638..59497d04a 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
* whether we are primary or secondary process, but we cannot remove
* primary process' files because secondary should be able to run even
* if primary process is dead.
+ *
+ * In no_shconf mode, no runtime directory is created in the first
+ * place, so no cleanup needed.
*/
- if (eal_clean_runtime_dir() < 0) {
+ if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
rte_eal_init_alert("Cannot clear runtime directory\n");
return -1;
}
--
2.17.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
2019-04-24 15:26 [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode Anatoly Burakov
@ 2019-04-24 15:26 ` Anatoly Burakov
2019-05-09 17:50 ` Ferruh Yigit
1 sibling, 0 replies; 10+ messages in thread
From: Anatoly Burakov @ 2019-04-24 15:26 UTC (permalink / raw)
To: dev
In no-shconf mode, there is no need to clean runtime directory
because it's not created in the first place.
Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 30138b638..59497d04a 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
* whether we are primary or secondary process, but we cannot remove
* primary process' files because secondary should be able to run even
* if primary process is dead.
+ *
+ * In no_shconf mode, no runtime directory is created in the first
+ * place, so no cleanup needed.
*/
- if (eal_clean_runtime_dir() < 0) {
+ if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
rte_eal_init_alert("Cannot clear runtime directory\n");
return -1;
}
--
2.17.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
2019-04-24 15:26 [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode Anatoly Burakov
2019-04-24 15:26 ` Anatoly Burakov
@ 2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50 ` Ferruh Yigit
1 sibling, 2 replies; 10+ messages in thread
From: Ferruh Yigit @ 2019-05-09 17:50 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, dpdk-stable
On 4/24/2019 4:26 PM, Anatoly Burakov wrote:
> In no-shconf mode, there is no need to clean runtime directory
> because it's not created in the first place.
>
> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Is this for 18.11.x LTS?
cc'ed the stable mail list assuming that is the case.
Is this valid for 19.05 too?
> ---
> lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index 30138b638..59497d04a 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
> * whether we are primary or secondary process, but we cannot remove
> * primary process' files because secondary should be able to run even
> * if primary process is dead.
> + *
> + * In no_shconf mode, no runtime directory is created in the first
> + * place, so no cleanup needed.
> */
> - if (eal_clean_runtime_dir() < 0) {
> + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
> rte_eal_init_alert("Cannot clear runtime directory\n");
> return -1;
> }
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
2019-05-09 17:50 ` Ferruh Yigit
@ 2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50 ` Ferruh Yigit
1 sibling, 0 replies; 10+ messages in thread
From: Ferruh Yigit @ 2019-05-09 17:50 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, dpdk-stable
On 4/24/2019 4:26 PM, Anatoly Burakov wrote:
> In no-shconf mode, there is no need to clean runtime directory
> because it's not created in the first place.
>
> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Is this for 18.11.x LTS?
cc'ed the stable mail list assuming that is the case.
Is this valid for 19.05 too?
> ---
> lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index 30138b638..59497d04a 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
> * whether we are primary or secondary process, but we cannot remove
> * primary process' files because secondary should be able to run even
> * if primary process is dead.
> + *
> + * In no_shconf mode, no runtime directory is created in the first
> + * place, so no cleanup needed.
> */
> - if (eal_clean_runtime_dir() < 0) {
> + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
> rte_eal_init_alert("Cannot clear runtime directory\n");
> return -1;
> }
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50 ` Ferruh Yigit
@ 2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 18:16 ` Kevin Traynor
1 sibling, 2 replies; 10+ messages in thread
From: Ferruh Yigit @ 2019-05-09 17:50 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, dpdk-stable, Kevin Traynor
On 5/9/2019 6:50 PM, Ferruh Yigit wrote:
> On 4/24/2019 4:26 PM, Anatoly Burakov wrote:
>> In no-shconf mode, there is no need to clean runtime directory
>> because it's not created in the first place.
>>
>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Is this for 18.11.x LTS?
> cc'ed the stable mail list assuming that is the case.
+Kevin
>
> Is this valid for 19.05 too?
>
>> ---
>> lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
>> index 30138b638..59497d04a 100644
>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
>> * whether we are primary or secondary process, but we cannot remove
>> * primary process' files because secondary should be able to run even
>> * if primary process is dead.
>> + *
>> + * In no_shconf mode, no runtime directory is created in the first
>> + * place, so no cleanup needed.
>> */
>> - if (eal_clean_runtime_dir() < 0) {
>> + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
>> rte_eal_init_alert("Cannot clear runtime directory\n");
>> return -1;
>> }
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
2019-05-09 17:50 ` Ferruh Yigit
@ 2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 18:16 ` Kevin Traynor
1 sibling, 0 replies; 10+ messages in thread
From: Ferruh Yigit @ 2019-05-09 17:50 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, dpdk-stable, Kevin Traynor
On 5/9/2019 6:50 PM, Ferruh Yigit wrote:
> On 4/24/2019 4:26 PM, Anatoly Burakov wrote:
>> In no-shconf mode, there is no need to clean runtime directory
>> because it's not created in the first place.
>>
>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Is this for 18.11.x LTS?
> cc'ed the stable mail list assuming that is the case.
+Kevin
>
> Is this valid for 19.05 too?
>
>> ---
>> lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
>> index 30138b638..59497d04a 100644
>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
>> * whether we are primary or secondary process, but we cannot remove
>> * primary process' files because secondary should be able to run even
>> * if primary process is dead.
>> + *
>> + * In no_shconf mode, no runtime directory is created in the first
>> + * place, so no cleanup needed.
>> */
>> - if (eal_clean_runtime_dir() < 0) {
>> + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
>> rte_eal_init_alert("Cannot clear runtime directory\n");
>> return -1;
>> }
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50 ` Ferruh Yigit
@ 2019-05-09 18:16 ` Kevin Traynor
2019-05-09 18:16 ` Kevin Traynor
2019-05-10 10:53 ` Burakov, Anatoly
1 sibling, 2 replies; 10+ messages in thread
From: Kevin Traynor @ 2019-05-09 18:16 UTC (permalink / raw)
To: Ferruh Yigit, Anatoly Burakov; +Cc: dev, dpdk-stable
On 09/05/2019 18:50, Ferruh Yigit wrote:
> On 5/9/2019 6:50 PM, Ferruh Yigit wrote:
>> On 4/24/2019 4:26 PM, Anatoly Burakov wrote:
>>> In no-shconf mode, there is no need to clean runtime directory
>>> because it's not created in the first place.
>>>
>>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
>>>
>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>
>> Is this for 18.11.x LTS?
>> cc'ed the stable mail list assuming that is the case.
>
> +Kevin
>
>>
>> Is this valid for 19.05 too?
>>
It's already applied on 18.11 branch. The same change is also in master
courtesy of the referenced upstream commit below, so this one not needed
for master. Thanks for checking.
commit 4c1ef6dff7230f08f90427355741f56d2faf5884
Author: Anatoly Burakov <anatoly.burakov@intel.com>
Date: Wed Apr 24 16:26:10 2019 +0100
eal: fix cleanup in no-shconf mode
[ upstream commit 307315d4577462943d0fcb2e6b8c8f35f90698d7 ]
>>> ---
>>> lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
>>> index 30138b638..59497d04a 100644
>>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>>> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
>>> * whether we are primary or secondary process, but we cannot remove
>>> * primary process' files because secondary should be able to run even
>>> * if primary process is dead.
>>> + *
>>> + * In no_shconf mode, no runtime directory is created in the first
>>> + * place, so no cleanup needed.
>>> */
>>> - if (eal_clean_runtime_dir() < 0) {
>>> + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
>>> rte_eal_init_alert("Cannot clear runtime directory\n");
>>> return -1;
>>> }
>>>
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
2019-05-09 18:16 ` Kevin Traynor
@ 2019-05-09 18:16 ` Kevin Traynor
2019-05-10 10:53 ` Burakov, Anatoly
1 sibling, 0 replies; 10+ messages in thread
From: Kevin Traynor @ 2019-05-09 18:16 UTC (permalink / raw)
To: Ferruh Yigit, Anatoly Burakov; +Cc: dev, dpdk-stable
On 09/05/2019 18:50, Ferruh Yigit wrote:
> On 5/9/2019 6:50 PM, Ferruh Yigit wrote:
>> On 4/24/2019 4:26 PM, Anatoly Burakov wrote:
>>> In no-shconf mode, there is no need to clean runtime directory
>>> because it's not created in the first place.
>>>
>>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
>>>
>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>
>> Is this for 18.11.x LTS?
>> cc'ed the stable mail list assuming that is the case.
>
> +Kevin
>
>>
>> Is this valid for 19.05 too?
>>
It's already applied on 18.11 branch. The same change is also in master
courtesy of the referenced upstream commit below, so this one not needed
for master. Thanks for checking.
commit 4c1ef6dff7230f08f90427355741f56d2faf5884
Author: Anatoly Burakov <anatoly.burakov@intel.com>
Date: Wed Apr 24 16:26:10 2019 +0100
eal: fix cleanup in no-shconf mode
[ upstream commit 307315d4577462943d0fcb2e6b8c8f35f90698d7 ]
>>> ---
>>> lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
>>> index 30138b638..59497d04a 100644
>>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>>> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
>>> * whether we are primary or secondary process, but we cannot remove
>>> * primary process' files because secondary should be able to run even
>>> * if primary process is dead.
>>> + *
>>> + * In no_shconf mode, no runtime directory is created in the first
>>> + * place, so no cleanup needed.
>>> */
>>> - if (eal_clean_runtime_dir() < 0) {
>>> + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
>>> rte_eal_init_alert("Cannot clear runtime directory\n");
>>> return -1;
>>> }
>>>
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
2019-05-09 18:16 ` Kevin Traynor
2019-05-09 18:16 ` Kevin Traynor
@ 2019-05-10 10:53 ` Burakov, Anatoly
2019-05-10 10:53 ` Burakov, Anatoly
1 sibling, 1 reply; 10+ messages in thread
From: Burakov, Anatoly @ 2019-05-10 10:53 UTC (permalink / raw)
To: Kevin Traynor, Ferruh Yigit; +Cc: dev, dpdk-stable
On 09-May-19 7:16 PM, Kevin Traynor wrote:
> On 09/05/2019 18:50, Ferruh Yigit wrote:
>> On 5/9/2019 6:50 PM, Ferruh Yigit wrote:
>>> On 4/24/2019 4:26 PM, Anatoly Burakov wrote:
>>>> In no-shconf mode, there is no need to clean runtime directory
>>>> because it's not created in the first place.
>>>>
>>>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
>>>>
>>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>>
>>> Is this for 18.11.x LTS?
>>> cc'ed the stable mail list assuming that is the case.
>>
>> +Kevin
>>
>>>
>>> Is this valid for 19.05 too?
>>>
>
> It's already applied on 18.11 branch. The same change is also in master
> courtesy of the referenced upstream commit below, so this one not needed
> for master. Thanks for checking.
>
> commit 4c1ef6dff7230f08f90427355741f56d2faf5884
> Author: Anatoly Burakov <anatoly.burakov@intel.com>
> Date: Wed Apr 24 16:26:10 2019 +0100
>
> eal: fix cleanup in no-shconf mode
>
> [ upstream commit 307315d4577462943d0fcb2e6b8c8f35f90698d7 ]
>
Yes, this was already applied at master. It was rolled into another fix,
which i admittedly shouldn't have done, i don't know what i was
thinking. This is only for 18.11 stable.
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
2019-05-10 10:53 ` Burakov, Anatoly
@ 2019-05-10 10:53 ` Burakov, Anatoly
0 siblings, 0 replies; 10+ messages in thread
From: Burakov, Anatoly @ 2019-05-10 10:53 UTC (permalink / raw)
To: Kevin Traynor, Ferruh Yigit; +Cc: dev, dpdk-stable
On 09-May-19 7:16 PM, Kevin Traynor wrote:
> On 09/05/2019 18:50, Ferruh Yigit wrote:
>> On 5/9/2019 6:50 PM, Ferruh Yigit wrote:
>>> On 4/24/2019 4:26 PM, Anatoly Burakov wrote:
>>>> In no-shconf mode, there is no need to clean runtime directory
>>>> because it's not created in the first place.
>>>>
>>>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
>>>>
>>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>>
>>> Is this for 18.11.x LTS?
>>> cc'ed the stable mail list assuming that is the case.
>>
>> +Kevin
>>
>>>
>>> Is this valid for 19.05 too?
>>>
>
> It's already applied on 18.11 branch. The same change is also in master
> courtesy of the referenced upstream commit below, so this one not needed
> for master. Thanks for checking.
>
> commit 4c1ef6dff7230f08f90427355741f56d2faf5884
> Author: Anatoly Burakov <anatoly.burakov@intel.com>
> Date: Wed Apr 24 16:26:10 2019 +0100
>
> eal: fix cleanup in no-shconf mode
>
> [ upstream commit 307315d4577462943d0fcb2e6b8c8f35f90698d7 ]
>
Yes, this was already applied at master. It was rolled into another fix,
which i admittedly shouldn't have done, i don't know what i was
thinking. This is only for 18.11 stable.
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-05-10 10:53 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24 15:26 [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode Anatoly Burakov
2019-04-24 15:26 ` Anatoly Burakov
2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 18:16 ` Kevin Traynor
2019-05-09 18:16 ` Kevin Traynor
2019-05-10 10:53 ` Burakov, Anatoly
2019-05-10 10:53 ` Burakov, Anatoly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).