From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 12D822BB1 for ; Wed, 1 Mar 2017 11:15:13 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30F69675; Wed, 1 Mar 2017 10:15:14 +0000 (UTC) Received: from [10.36.116.153] (ovpn-116-153.ams2.redhat.com [10.36.116.153]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v21AF98T005305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Mar 2017 05:15:11 -0500 To: Yuanhan Liu , Thomas Monjalon References: <20170123211340.22570-1-bmcfall@redhat.com> <20170127183800.27466-1-bmcfall@redhat.com> <20170127183800.27466-4-bmcfall@redhat.com> <1641551.cy8vlj4stG@xps13> <20170228064155.GM18844@yliu-dev.sh.intel.com> Cc: Billy McFall , wenzhuo.lu@intel.com, olivier.matz@6wind.com, dev@dpdk.org From: Maxime Coquelin Message-ID: Date: Wed, 1 Mar 2017 11:15:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170228064155.GM18844@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 01 Mar 2017 10:15:14 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v5 3/3] net/vhost: vHost support to free consumed buffers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 10:15:14 -0000 On 02/28/2017 07:41 AM, Yuanhan Liu wrote: > On Mon, Feb 27, 2017 at 02:50:54PM +0100, Thomas Monjalon wrote: >> 2017-01-27 13:38, Billy McFall: >>> Add support to the vHostdriver for the new API to force free consumed >>> buffers on Tx ring. vHost does not cache the mbufs so there is no work >>> to do. >>> >>> Signed-off-by: Billy McFall >> >> Yuanhan, Maxime, do you agree with this empty function? > > For this particular (vhost) implementation, I think it's okay. Agree with Yuanhan, it looks good for vhost case: Acked-by: Maxime Coquelin Thanks, Maxime