From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A31957D4E for ; Thu, 7 Sep 2017 15:00:11 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BDAD880F90; Thu, 7 Sep 2017 13:00:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BDAD880F90 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=maxime.coquelin@redhat.com Received: from [10.36.112.11] (unknown [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1C34117D59; Thu, 7 Sep 2017 13:00:00 +0000 (UTC) To: Yuanhan Liu Cc: dev@dpdk.org, jfreiman@redhat.com, tiwei.bie@intel.com, mst@redhat.com, vkaplans@redhat.com, jasowang@redhat.com References: <20170831095023.21037-1-maxime.coquelin@redhat.com> <20170831095023.21037-2-maxime.coquelin@redhat.com> <20170907115448.GA9736@yliu-home> From: Maxime Coquelin Message-ID: Date: Thu, 7 Sep 2017 14:59:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170907115448.GA9736@yliu-home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 07 Sep 2017 13:00:10 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 01/21] Revert "vhost: workaround MQ fails to startup" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 13:00:11 -0000 Hi Yuanhan, On 09/07/2017 01:54 PM, Yuanhan Liu wrote: > On Thu, Aug 31, 2017 at 11:50:03AM +0200, Maxime Coquelin wrote: >> This reverts commit 04d81227960b5c1cf2f11f492100979ead20c526. >> >> As agreed when this workaround was introduced, it can be reverted >> as Qemu v2.10 that fixes the issue is now out. > > First of all, I'm very sorry for being so late on review! > > I didn't quite remember we have come an agreement on that. > I think my > old concern still counts: how do you handle the combo like DPDK v17.11 > and QEMU v2.7-2.9 (assume we take this patch in DPDK v17.11) ? > > Note that it's not a trivial bug, it's a fatal bug that freezes QEMU, > IIRC IIRC, I also raised the concern initially but after having listed the possible solutions, I thought we agreed there were no trivial way to detect the bug in Qemu and so we would re-enable it once upstream Qemu got fixed. Note that we're talking about upstream here, which should not be used in production. Distro's Qemu v2.7/v2.9 should be fixed, as RHEL-7.4 has been. Any thougths? Maxime > --yliu > >> The reply-ack feature is required for vhost-user IOMMU support. >> >> Signed-off-by: Maxime Coquelin