From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DF32A04DB; Wed, 14 Oct 2020 19:45:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D43311D8EF; Wed, 14 Oct 2020 19:45:16 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A0DA51D6DB for ; Wed, 14 Oct 2020 19:45:15 +0200 (CEST) IronPort-SDR: tOAQ7kdRtZvq4eY101W/MvI4f5TnSWvfYi+BLep6NTBU1ibY9kRBXqNOb9IjhcorR3IBS9ljQ5 s8G/wZ+PC4og== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="166276361" X-IronPort-AV: E=Sophos;i="5.77,375,1596524400"; d="scan'208";a="166276361" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 10:45:10 -0700 IronPort-SDR: qs66kINHT50VVb+k1ln/dGZYKtNE9JnzDjAYP8pt2Qvsxqt2aJMOF2rkmalAa/iDheyvv8LvnM ZYVD6xGk9Yqw== X-IronPort-AV: E=Sophos;i="5.77,375,1596524400"; d="scan'208";a="463966837" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.212.224]) ([10.213.212.224]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 10:45:08 -0700 To: Andrew Rybchenko , Chas Williams , "Min Hu (Connor)" Cc: dev@dpdk.org, Ivan Ilchenko References: <1602682146-4722-1-git-send-email-arybchenko@solarflare.com> <1602682146-4722-6-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Wed, 14 Oct 2020 18:45:05 +0100 MIME-Version: 1.0 In-Reply-To: <1602682146-4722-6-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 05/11] net/bonding: check eth dev stop status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/2020 2:29 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_dev_stop() return value was changed from void to int, > so this patch modify usage of this function across net/bonding > according to new return type. > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko <...> > index 1c404b2edd..6cb03d40d7 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1694,7 +1694,12 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > struct bond_dev_private *internals = bonded_eth_dev->data->dev_private; > > /* Stop slave */ > - rte_eth_dev_stop(slave_eth_dev->data->port_id); > + errval = rte_eth_dev_stop(slave_eth_dev->data->port_id); > + if (errval != 0) { > + RTE_BOND_LOG(ERR, "rte_eth_dev_stop: port %u, err (%d)", > + slave_eth_dev->data->port_id, errval); > + return errval; > + } The 'return' part of this patch seems removed in 11/11, better to not return at first place in this patch.