From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 207F42B91 for ; Fri, 8 Mar 2019 11:01:16 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 105CA2D7F5; Fri, 8 Mar 2019 10:01:15 +0000 (UTC) Received: from [10.36.112.64] (ovpn-112-64.ams2.redhat.com [10.36.112.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA15A5D788; Fri, 8 Mar 2019 10:01:13 +0000 (UTC) To: "Stojaczyk, Dariusz" , "dev@dpdk.org" , "Liu, Changpeng" , "Bie, Tiwei" , "i.maximets@samsung.com" References: <20190228153134.31865-1-maxime.coquelin@redhat.com> <20190228153134.31865-3-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: Date: Fri, 8 Mar 2019 11:01:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 08 Mar 2019 10:01:15 +0000 (UTC) Subject: Re: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 10:01:16 -0000 On 3/8/19 10:18 AM, Stojaczyk, Dariusz wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin >> Sent: Thursday, February 28, 2019 4:32 PM >> To: dev@dpdk.org; Liu, Changpeng ; Bie, Tiwei >> ; i.maximets@samsung.com >> Cc: Maxime Coquelin >> Subject: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by >> external backend >> >> External backends may have specific requests to handle, and so >> we don't want the vhost-user lib to handle these requests as >> errors. >> >> This patch also changes the experimental API by introducing >> RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-user lib >> can report an error if a message is handled neither by >> the vhost-user library nor by the external backend. >> >> The logic changes a bit so that if the callback returns >> with ERR, OK or REPLY, it is considered the message >> is handled by the external backend so it won't be >> handled by the vhost-user library. >> It is still possible for an external backend to listen >> to requests that have to be handled by the vhost-user >> library like SET_MEM_TABLE, but the callback have to >> return NOT_HANDLED in that case. >> >> Suggested-by: Ilya Maximets >> Signed-off-by: Maxime Coquelin >> --- > > Besides the fall-through compilation issue, > > Tested-by: Darek Stojaczyk > > Thanks! > Great, thanks Darek. I was waiting for your feedback, I'll post v1 early next week. Maxime