From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7785FA0567; Fri, 13 Mar 2020 05:41:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BDF761BF97; Fri, 13 Mar 2020 05:41:10 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BBB471AFF; Fri, 13 Mar 2020 05:41:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 21:41:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,547,1574150400"; d="scan'208,217";a="232295532" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 12 Mar 2020 21:41:07 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Mar 2020 21:41:07 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Mar 2020 12:40:52 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Fri, 13 Mar 2020 12:40:52 +0800 From: "Li, Xiaoyun" To: Zhike Wang , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable adminq operation Thread-Index: AQHVzAsjAe/BRUyilUC69er87G21N6hGN1XA Date: Fri, 13 Mar 2020 04:40:51 +0000 Message-ID: References: <1579137597-14076-1-git-send-email-wangzhike@jd.com> In-Reply-To: <1579137597-14076-1-git-send-email-wangzhike@jd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable adminq operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi This issue is already fixed in 20.02 with base code update of the following= commit. commit 37b091c75b13d2f26359be9b77adbc33c55a7581 Author: Xiaolong Ye Date: Mon Jan 13 10:39:31 2020 +0800 net/i40e/base: extend PHY access AQ command Currently FW use MDIO I/F number corresponded with current PF for PHY access. This code allow to specify used MDIO I/F number. Signed-off-by: Piotr Azarewicz Signed-off-by: Xiaolong Ye Acked-by: Qi Zhang Acked-by: Beilei Xing beilei.xing@intel.com But it makes sense to back port this to stable release so it can work with = dpdk version <=3D19.11. Still some comments inline. > -----Original Message----- > From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Zhike Wang > Sent: Thursday, January 16, 2020 09:20 > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > stable@dpdk.org; Zhike Wang > Subject: [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable > adminq operation > > X722 SFPs have different flavors, eg I40E_DEV_ID_SFP_X722 > /I40E_DEV_ID_SFP_I_X722. So instead we use mac.type to judge whether it i= s > X722 or not. > Please be careful about your commit log. If you use mac.type =3D=3D X722, t= hen that's not just X722 SFP but all X722 devices. You can just say something like X722 doesn't support adminq operation so di= sable it. > Fixes: 9efa8d28b ("net/i40e: fix SFP X722 with FW4.16") Please follow the DPDK community code style. Fix line needs commit id of 12= bit. In this case, should be: Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 with = FW4.16") And since this fix makes sense for <=3D19.11, please add this line: Cc: sta= ble@dpdk.org > Signed-off-by: Zhike Wang > > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 5999c96..85ccb76 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1443,7 +1443,7 @@ static inline void i40e_config_automask(struct > i40e_pf *pf) > return -EIO; > } > /* Firmware of SFP x722 does not support adminq option */ > - if (hw->device_id =3D=3D I40E_DEV_ID_SFP_X722) > + if (hw->mac.type =3D=3D I40E_MAC_X722) > hw->flags &=3D ~I40E_HW_FLAG_802_1AD_CAPABLE; > > PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d > eetrack %04x", > -- > 1.8.3.1 >