From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31D74A0547; Wed, 27 Oct 2021 05:25:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB4CB40E0F; Wed, 27 Oct 2021 05:25:02 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id D877640DDA; Wed, 27 Oct 2021 05:25:00 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="227520898" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="227520898" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 20:24:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="722998599" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 26 Oct 2021 20:24:59 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 20:24:58 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 11:24:51 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Wed, 27 Oct 2021 11:24:51 +0800 From: "Zhang, Qi Z" To: "Yu, DapengX" , "Yang, Qiming" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v5] net/ice: simplify the use of DCF device reset Thread-Index: AQHXyk9OTKXKSBFYhEi1UWxySoqDnKvmLjBg Date: Wed, 27 Oct 2021 03:24:51 +0000 Message-ID: References: <20211026084401.1681489-1-dapengx.yu@intel.com> <20211026095308.1759784-1-dapengx.yu@intel.com> In-Reply-To: <20211026095308.1759784-1-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] net/ice: simplify the use of DCF device reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yu, DapengX > Sent: Tuesday, October 26, 2021 5:53 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [PATCH v5] net/ice: simplify the use of DCF device reset It's a workaround, so rename to=20 "workaround DCF reset failure" >=20 > From: Dapeng Yu >=20 > After DCF is reset by PF, the DCF device un-initialization cannot functio= n > normally since the kernel may not clean up resource. >=20 > This patch detects the reset flag, which is set by PF on DCF reset, if th= e flag is > true, reset hw to trigger an additional DCF enable/disable cycle which he= lps to > work around the issue that kernel driver may not clean up resource during > previous reset. Reword to After DCF is reset by PF, the DCF device un-initialization cannot function normally, ignore the failure does not help since the kernel does not clean up resource. The patch workaround the issue by triggering an additional DCF enable/ disable cycle when a passive reset is detected. >=20 > Fixes: 1a86f4dbdf42 ("net/ice: support DCF device reset") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi