From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.hunt@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id C822F7CB6
 for <dev@dpdk.org>; Mon, 25 Sep 2017 11:44:45 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga105.fm.intel.com with ESMTP; 25 Sep 2017 02:44:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,435,1500966000"; d="scan'208";a="1223308576"
Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.44])
 ([10.237.220.44])
 by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2017 02:44:43 -0700
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Marjanovic, Nemanja" <nemanja.marjanovic@intel.com>,
 "Sexton, Rory" <rory.sexton@intel.com>
References: <1503676941-80981-1-git-send-email-david.hunt@intel.com>
 <1503676941-80981-11-git-send-email-david.hunt@intel.com>
 <9BB6961774997848B5B42BEC655768F810E7C858@SHSMSX103.ccr.corp.intel.com>
From: "Hunt, David" <david.hunt@intel.com>
Message-ID: <ad8fe22a-e7cb-f5d8-62d0-c3e90495aa6e@intel.com>
Date: Mon, 25 Sep 2017 10:44:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <9BB6961774997848B5B42BEC655768F810E7C858@SHSMSX103.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v1 10/10] net/i40e: set register for no drop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Sep 2017 09:44:46 -0000



On 25/9/2017 3:50 AM, Wu, Jingjing wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
>> Sent: Saturday, August 26, 2017 12:02 AM
>> To: dev@dpdk.org
>> Cc: Hunt, David <david.hunt@intel.com>; Marjanovic, Nemanja
>> <nemanja.marjanovic@intel.com>; Sexton, Rory <rory.sexton@intel.com>
>> Subject: [dpdk-dev] [PATCH v1 10/10] net/i40e: set register for no drop
>>
>> See the XL710 controller datasheet for more information on this register
>>
>> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
>> Signed-off-by: Rory Sexton <rory.sexton@intel.com>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>>   drivers/net/i40e/i40e_ethdev.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index d9806fc..24b713e 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -1156,7 +1156,7 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)
>>   	 * in firmware in the future.
>>   	 */
>>   	i40e_configure_registers(hw);
>> -
>> +	I40E_WRITE_REG(hw, I40E_PRTDCB_TC2PFC, 0xff);
> What is the relationship with VM power manager?
>
> And about no-drop setting, it is the responsibility of flow control, please check http://www.dpdk.org/dev/patchwork/patch/19449/
>
>
> Thanks
> Jingjing

Hi Jingjing,
    Yes, we've removed this now. It's left to flow control. Will be 
removed from next patch set.
Rgds,
Dave.