* [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print
@ 2017-04-14 1:16 Wenzhuo Lu
2017-04-14 10:49 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Wenzhuo Lu @ 2017-04-14 1:16 UTC (permalink / raw)
To: dev; +Cc: Wenzhuo Lu
When receiving the unsupported AQ messages, it's taken as
an error. It's not appropriate and triggers too much
unnecessary print.
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 9eb1a65..1773e05 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -5774,7 +5774,7 @@ struct i40e_vsi *
RTE_ETH_EVENT_INTR_LSC, NULL);
break;
default:
- PMD_DRV_LOG(ERR, "Request %u is not supported yet",
+ PMD_DRV_LOG(DEBUG, "Request %u is not supported yet",
opcode);
break;
}
--
1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print
2017-04-14 1:16 [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print Wenzhuo Lu
@ 2017-04-14 10:49 ` Ferruh Yigit
2017-04-14 15:53 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2017-04-14 10:49 UTC (permalink / raw)
To: Wenzhuo Lu, dev
On 4/14/2017 2:16 AM, Wenzhuo Lu wrote:
> When receiving the unsupported AQ messages, it's taken as
> an error. It's not appropriate and triggers too much
> unnecessary print.
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print
2017-04-14 10:49 ` Ferruh Yigit
@ 2017-04-14 15:53 ` Ferruh Yigit
2017-04-17 2:58 ` Lu, Wenzhuo
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2017-04-14 15:53 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu; +Cc: dev
On 4/14/2017 11:49 AM, Ferruh Yigit wrote:
> On 4/14/2017 2:16 AM, Wenzhuo Lu wrote:
>> When receiving the unsupported AQ messages, it's taken as
>> an error. It's not appropriate and triggers too much
>> unnecessary print.
>>
>> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
Hi Wenzhuo, Jingjing,
Another i40e log print, in WARNING level:
i40e_update_default_filter_setting(): Cannot remove the default macvlan
filter
I am getting this one always.
If this is produced always, what do you think downgrade this one too? Or
remove completely perhaps?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print
2017-04-14 15:53 ` Ferruh Yigit
@ 2017-04-17 2:58 ` Lu, Wenzhuo
0 siblings, 0 replies; 4+ messages in thread
From: Lu, Wenzhuo @ 2017-04-17 2:58 UTC (permalink / raw)
To: Yigit, Ferruh, Wu, Jingjing; +Cc: dev
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, April 14, 2017 11:54 PM
> To: Lu, Wenzhuo; Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print
>
> On 4/14/2017 11:49 AM, Ferruh Yigit wrote:
> > On 4/14/2017 2:16 AM, Wenzhuo Lu wrote:
> >> When receiving the unsupported AQ messages, it's taken as an error.
> >> It's not appropriate and triggers too much unnecessary print.
> >>
> >> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> >
> > Applied to dpdk-next-net/master, thanks.
>
> Hi Wenzhuo, Jingjing,
>
> Another i40e log print, in WARNING level:
>
> i40e_update_default_filter_setting(): Cannot remove the default macvlan
> filter
>
> I am getting this one always.
>
> If this is produced always, what do you think downgrade this one too? Or
> remove completely perhaps?
Checked the comment in the code, it's expected that it will fail in some scenarios. So I'll send a patch to downgrade it to "debug".
>
> Thanks,
> ferruh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-17 2:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-14 1:16 [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print Wenzhuo Lu
2017-04-14 10:49 ` Ferruh Yigit
2017-04-14 15:53 ` Ferruh Yigit
2017-04-17 2:58 ` Lu, Wenzhuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).