From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id EB5F57CB6 for ; Thu, 26 Apr 2018 16:21:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 07:21:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,330,1520924400"; d="scan'208";a="44804917" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.42]) ([10.237.221.42]) by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2018 07:21:25 -0700 To: "Ananyev, Konstantin" , "Doherty, Declan" , "dev@dpdk.org" Cc: Adrien Mazarguil , Thomas Monjalon , Shahaf Shuler , "Horton, Remy" References: <20180416130605.6509-1-declan.doherty@intel.com> <20180426104105.18342-1-declan.doherty@intel.com> <20180426104105.18342-7-declan.doherty@intel.com> <2601191342CEEE43887BDE71AB977258AEBD049D@IRSMSX102.ger.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: Date: Thu, 26 Apr 2018 15:21:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB977258AEBD049D@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 14:21:30 -0000 On 4/26/2018 1:03 PM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: Doherty, Declan >> Sent: Thursday, April 26, 2018 11:41 AM >> To: dev@dpdk.org >> Cc: Adrien Mazarguil ; Yigit, Ferruh ; Thomas Monjalon ; >> Shahaf Shuler ; Ananyev, Konstantin ; Horton, Remy ; >> Doherty, Declan >> Subject: [dpdk-dev][PATCH v8 6/9] ethdev: add common devargs parser >> >> From: Remy Horton >> >> Introduces a new structure, rte_eth_devargs, to support generic >> ethdev arguments common across NET PMDs, with a new API >> rte_eth_devargs_parse API to support PMD parsing these arguments. The >> patch add support for a representor argument passed with passed with >> the EAL -w option. The representor parameter allows the user to specify >> which representor ports to initialise on a device. >> >> The argument supports passing a single representor port, a list of >> port values or a range of port values. >> >> -w BDF,representor=1 # create representor port 1 on pci device BDF >> -w BDF,representor=[1,2,5,6,10] # create representor ports in list >> -w BDF,representor=[0-31] # create representor ports in range >> >> Signed-off-by: Remy Horton >> Signed-off-by: Declan Doherty >> --- >> doc/guides/prog_guide/poll_mode_drv.rst | 19 ++++ >> lib/Makefile | 1 + >> lib/librte_ether/rte_ethdev.c | 182 ++++++++++++++++++++++++++++++++ >> lib/librte_ether/rte_ethdev_driver.h | 30 ++++++ >> lib/librte_ether/rte_ethdev_version.map | 1 + >> 5 files changed, 233 insertions(+) >> >> diff --git a/doc/guides/prog_guide/poll_mode_drv.rst b/doc/guides/prog_guide/poll_mode_drv.rst >> index e5d01874e..09a93baec 100644 >> --- a/doc/guides/prog_guide/poll_mode_drv.rst >> +++ b/doc/guides/prog_guide/poll_mode_drv.rst >> @@ -345,6 +345,25 @@ Ethernet Device API >> >> The Ethernet device API exported by the Ethernet PMDs is described in the *DPDK API Reference*. >> >> +Ethernet Device Standard Device Arguments >> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> + >> +Standard Ethernet device arguments allow for a set of commonly used arguments/ >> +parameters which are applicable to all Ethernet devices to be available to for >> +specification of specific device and for passing common configuration >> +parameters to those ports. >> + >> +* ``representor`` for a device which supports the creation of representor ports >> + this argument allows user to specify which switch ports to enable port >> + representors for.:: >> + >> + -w BDBF,representor=0 >> + -w BDBF,representor=[0,4,6,9] >> + -w BDBF,representor=[0-31] >> + >> +Note: PMDs are not required to support the standard device arguments and users >> +should consult the relevant PMD documentation to see support devargs. >> + >> Extended Statistics API >> ~~~~~~~~~~~~~~~~~~~~~~~ >> >> diff --git a/lib/Makefile b/lib/Makefile >> index 965be6c8d..536775e59 100644 >> --- a/lib/Makefile >> +++ b/lib/Makefile >> @@ -21,6 +21,7 @@ DEPDIRS-librte_cmdline := librte_eal >> DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += librte_ether >> DEPDIRS-librte_ether := librte_net librte_eal librte_mempool librte_ring >> DEPDIRS-librte_ether += librte_mbuf >> +DEPDIRS-librte_ether += librte_kvargs >> DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += librte_bbdev >> DEPDIRS-librte_bbdev := librte_eal librte_mempool librte_mbuf >> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += librte_cryptodev >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >> index 621f8af7f..cb85d8bb7 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++ b/lib/librte_ether/rte_ethdev.c >> @@ -34,6 +34,7 @@ >> #include >> #include >> #include >> ++#include >> >> #include "rte_ether.h" >> #include "rte_ethdev.h" >> @@ -4101,6 +4102,187 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, const char *pool) >> return (*dev->dev_ops->pool_ops_supported)(dev, pool); >> } >> >> +typedef int (*rte_eth_devargs_callback_t)(char *str, void *data); >> + >> +static int >> +rte_eth_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in) >> +{ > > I still think that if you'd like to extend rte_kvarrgs to be able to parse something like: "key=[val1,val2,...,valn]", > you have to make it generic kvargs ability and put it into librte_kvargs, not try to introduce your own new parser here. > Imagine that in addition to your 'port=[val1,val2, ..valn]' devargs string would contain some extra (let say device specific) > parameters. > What would happen, when PMD will try to use rte_kvargs_parse() on such string? > My understanding - it would fail, correct? > > As an alternative - as I remember rte_kvargs allows you to have multiple identical key, i.e: "key=val1,key=val2,...,key=valn". > Why not to use that way, if you don't want to introduce extra code in rte_kvargs? Hi Declan, Remy, I will continue with existing patchset, for the sake of the rc1, can you please address these comments as incremental updates to the set? >> +static int >> +rte_eth_devargs_process_range(char *str, uint16_t *list, uint16_t *len_list, >> + const uint16_t max_list) >> +{ >> + uint16_t lo, hi, val; >> + int result; >> + >> + result = sscanf(str, "%hu-%hu", &lo, &hi); >> + if (result == 1) { >> + if (*len_list >= max_list) >> + return -ENOMEM; >> + list[(*len_list)++] = lo; >> + } else if (result == 2) { >> + if (lo >= hi || lo > RTE_MAX_ETHPORTS || hi > RTE_MAX_ETHPORTS) > > lo > RTE_MAX_ETHPORTS is redundant here. Same here, thanks.