From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 07DAF2C60 for ; Wed, 7 Dec 2016 15:29:54 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP; 07 Dec 2016 06:29:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="39810102" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga005.jf.intel.com with ESMTP; 07 Dec 2016 06:29:52 -0800 To: Wenzhuo Lu , dev@dpdk.org References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-13-git-send-email-wenzhuo.lu@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 7 Dec 2016 14:29:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481081535-37448-13-git-send-email-wenzhuo.lu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 12/32] net/i40e: set VF MAC from PF support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 14:29:55 -0000 On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > Support setting VF MAC address from PF. > User can call the API on PF to set a specific > VF's MAC address. > > This will reset the VF. > > Signed-off-by: Ferruh Yigit > --- <...> > > +/** > + * Set the VF MAC address. > + * > + * This will reset the vf. It may be good if I add a comment that this also will remove all existing mac filters. Same to commit log perhaps. > + * > + * @param port > + * The port identifier of the Ethernet device. > + * @param vf_id > + * VF id. > + * @param mac_addr > + * VF MAC address. > + * @return > + * - (0) if successful. > + * - (-ENODEV) if *port* invalid. > + * - (-EINVAL) if *vf* or *mac_addr* is invalid. > + */ > +int rte_pmd_i40e_set_vf_mac_addr(uint8_t port, uint16_t vf_id, > + struct ether_addr *mac_addr); > + <...>