From: Kevin Traynor <ktraynor@redhat.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/kasumi: fix gcc 10 fno-common error
Date: Wed, 6 May 2020 10:45:41 +0100 [thread overview]
Message-ID: <ade1873d-ea64-9679-0d9d-571f0dad7d81@redhat.com> (raw)
In-Reply-To: <SN6PR11MB31013F5EC0F0B1242C119B0684A70@SN6PR11MB3101.namprd11.prod.outlook.com>
On 05/05/2020 18:22, De Lara Guarch, Pablo wrote:
> Hi Kevin,
>
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, May 5, 2020 1:55 PM
>> To: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Cc: david.marchand@redhat.com; Kevin Traynor <ktraynor@redhat.com>
>> Subject: [PATCH] crypto/kasumi: fix gcc 10 fno-common error
>>
>> gcc 10 defaults to fno-common and it reports:
>>
>> crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
>> multiple definition of `rte_kasumi_pmd_ops';
>> crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here
>>
>> Fix by making rte_kasumi_pmd_ops extern in the header file.
>>
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
> Patch looks good, but you are missing fixes line and CC stable, right?
> Apart from that:
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
Thanks Pablo, sent v2 with the tags and your ack.
next prev parent reply other threads:[~2020-05-06 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 12:54 Kevin Traynor
2020-05-05 17:22 ` De Lara Guarch, Pablo
2020-05-06 9:45 ` Kevin Traynor [this message]
2020-05-06 9:45 ` [dpdk-dev] [PATCH v2] " Kevin Traynor
2020-05-09 22:01 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ade1873d-ea64-9679-0d9d-571f0dad7d81@redhat.com \
--to=ktraynor@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).