From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94FA7A04C5; Thu, 14 Nov 2019 17:24:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 685762BAF; Thu, 14 Nov 2019 17:24:02 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0B8502BA8; Thu, 14 Nov 2019 17:24:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2019 08:23:54 -0800 X-IronPort-AV: E=Sophos;i="5.68,304,1569308400"; d="scan'208";a="195084817" Received: from dhunt5-mobl4.ger.corp.intel.com (HELO [10.237.221.4]) ([10.237.221.4]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 14 Nov 2019 08:23:52 -0800 To: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Cc: dev@dpdk.org, alan.carew@intel.com, liang.j.ma@intel.com, stable@dpdk.org References: <20191114141036.31317-1-mattias.ronnblom@ericsson.com> From: "Hunt, David" Message-ID: Date: Thu, 14 Nov 2019 16:23:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20191114141036.31317-1-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Mattias, On 14/11/2019 14:10, Mattias Rönnblom wrote: > Calling pstate's or acpi's rte_power_freq_up() when on the highest > non-turbo frequency results in an error, if turbo is disabled. The > error is in the form of a return code and a RTE_LOG() entry on the ERR > level. > > According to the API documentation, the frequency is scaled up > "according to the available frequencies". In case turbo is disabled, > that frequency is not available. This patch's rte_power_freq_up() > behaviour is also consistent with how rte_power_freq_max() is > implemented (i.e. the highest non-turbo frequency is set, in case > turbo is disabled). > > Fixes: 445c6528b55f ("power: common interface for guest and host") > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > Cc: stable@dpdk.org > > Signed-off-by: Mattias Rönnblom > --- Thanks for the patch, I can repeat the issue without the patch, and after applying the patch, I no longer get the error message. So: Tested-by: David Hunt It might be worth clarifying in the commit message that "turbo disabled"actually means "turbo enabled in the bios, but disabled via the power library", but that's  a small point. Acked-By: David Hunt