From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 24B5023D; Mon, 18 Dec 2017 11:36:11 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 5005DB40077; Mon, 18 Dec 2017 10:36:09 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 18 Dec 2017 10:36:02 +0000 To: Olivier Matz , , Thomas Monjalon CC: Laurent Hardy , References: <20171214171531.10506-1-olivier.matz@6wind.com> From: Andrew Rybchenko Message-ID: Date: Mon, 18 Dec 2017 13:35:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171214171531.10506-1-olivier.matz@6wind.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23536.003 X-TM-AS-Result: No--11.125100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1513593370-Nl0SXkRF+aJx Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix setting of MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 10:36:11 -0000 On 12/14/2017 08:15 PM, Olivier Matz wrote: > From: Laurent Hardy > > When a new mac address is set, it is saved in dev->data->mac_addrs > before the ethdev handler is called. > > First, it is inconsistent with the other ethdev functions > rte_eth_dev_mac_addr_remove() and rte_eth_dev_mac_addr_add(). > > Moreover, it prevents the drivers from wrongly comparing the old address > and the new one, like it's done in i40evf driver: > > if (is_same_ether_addr(mac_addr, dev->data->mac_addrs)) > return; > > Fixes: 943c2d899a0c ("net/i40e: set VF MAC from VF") > Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") > Cc: stable@dpdk.org > > Signed-off-by: Laurent Hardy > --- > lib/librte_ether/rte_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index 4f492e3db..297c02a54 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -2643,11 +2643,11 @@ rte_eth_dev_default_mac_addr_set(uint16_t port_id, struct ether_addr *addr) > dev = &rte_eth_devices[port_id]; > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->mac_addr_set, -ENOTSUP); > > + (*dev->dev_ops->mac_addr_set)(dev, addr); > + > /* Update default address in NIC data structure */ > ether_addr_copy(addr, &dev->data->mac_addrs[0]); > > - (*dev->dev_ops->mac_addr_set)(dev, addr); > - > return 0; > } NACK, unfortunately it will break net/sfc in one of branches when a new MAC is set using restart. It relies on the fact that a new MAC is already available in device data.