DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Long Li <longli@microsoft.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: "longli@linuxonhyperv.com" <longli@linuxonhyperv.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	David Marchand <david.marchand@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Ajay Sharma <sharmaajay@microsoft.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Luca Boccassi <bluca@debian.org>,
	Qi Z Zhang <qi.z.zhang@intel.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
	Olivier Matz <olivier.matz@6wind.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	"techboard@dpdk.org" <techboard@dpdk.org>
Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath
Date: Fri, 3 Mar 2023 13:54:23 +0000	[thread overview]
Message-ID: <adfc636a-ea46-7783-983d-724df81bbdb1@amd.com> (raw)
In-Reply-To: <PH7PR21MB326371786C14F5C10EDF51BCCEB39@PH7PR21MB3263.namprd21.prod.outlook.com>

On 3/3/2023 2:16 AM, Long Li wrote:
>> Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath
>>
>> On Thu, 23 Feb 2023 10:09:17 -0800
>> Stephen Hemminger <stephen@networkplumber.org> wrote:
>>
>>> On Thu, 23 Feb 2023 14:07:25 +0000
>>> Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>>>
>>>> Overall I am not sure if anyone is interested in driver datapath
>>>> logs other than driver developers themselves.
>>>>
>>>> For datapath logging I think there are two concerns,
>>>> 1) It should not eat *any* cycles unless explicitly enabled
>>>> 2) Capability of enable/disable them because of massive amount of
>>>> log it can generate
>>>>
>>>>
>>>> Currently there are two existing approaches for driver datapath logging:
>>>> i)  Controlled by 'RTE_ETHDEV_DEBUG_RX/TX' compile time flag,
>>>>     when enabled 'rte_log()' is used with Rx/Tx specific log type.
>>>> ii) 'RTE_LOG_DP' ', compile time control per logtype via
>>>>     'RTE_LOG_DP_LEVEL',
>>>>      when enabled 'rte_log()' is used with PMD logtype.
>>>>
>>>>
>>>> In (ii), need to re-compile code when you need to increase the log
>>>> verbosity, and it leaks to production code as mentioned above.
>>>>
>>>> For (i), developer compiles once enabling debug, later can fine
>>>> grain log level dynamically. This is more DPDK developer focused approach.
>>>>
>>>>
>>>> [1]
>>>> According above, what do you think to retire 'RTE_LOG_DP', (at least
>>>> within ethdev datapath), and chose (i) as preferred datapath logging?
>>>
>>> I agree, the current tx/rx logging is a mess.
>>> Each driver is different, each driver has to have something to enable
>>> it; and it really isn't useful beyond the driver developer.
>>>
>>> Using tracing seems like a much better option. Could we agree on a
>>> common set of trace points for drivers and fix all drivers to use the same
>> thing.
>>> Probably will cause some upset among driver developers:
>>> "where did my nice printf's go, now I have to learn tracing"
>>> but DPDK has a good facility here, lets use it.
>>>
>>> My proposal would be:
>>> 	- agree on common set of trace points
>>> 	- apply to all drivers
>>> 	- remove RTE_LOG_DP()
>>> 	- remove per driver RX/TX options
>>> 	- side effect, more uses of RTE_LOGTYPE_PMD go away.
>>
>> Here is an example of using tracepoints instead.
>> Compile tested for example only.
>>
>> Note: using tracepoints it is possible to keep some of the tracepoints even if
>> fastpath is not enabled.  Things like running out of Tx or Mbuf is not something
>> that is perf critical; but would be good for application to see.
> 
> Thank you for the example.
> 
> I sent another patch converting data path logs (mana) to trace points.
> 

Hi Long,

Thanks for the effort, you were quick on this while discussion is going on.

Although tracepoint is a good feature, I am not sure if it can fully
replace the logging.
I think usage is slightly different, trace is missing custom human
readable message, which can be very helpful for end user.

And overall, it is a high level decision to switch logging to trace, it
is inconsistent to switch only single driver, perhaps techboard (cc'ed)
can discuss this.

Until such consensus reached, I think driver should continue with logging.



And for the logging, I suggest option (i) above, I was hoping more
comments but since it is missing I hope this can be discussed in
techboard for a conclusion.



  reply	other threads:[~2023-03-03 13:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 20:42 longli
2023-02-23 14:07 ` Ferruh Yigit
2023-02-23 18:09   ` Stephen Hemminger
2023-02-24 17:51     ` Stephen Hemminger
2023-03-03  2:16       ` Long Li
2023-03-03 13:54         ` Ferruh Yigit [this message]
2023-03-03 19:04           ` Long Li
2023-03-04  1:15             ` Ferruh Yigit
2023-04-28  1:29               ` Long Li
2023-04-28 10:23                 ` Ferruh Yigit
2023-04-28 17:52                   ` Long Li
2023-03-04  0:16           ` Stephen Hemminger
2023-05-02 15:45 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adfc636a-ea46-7783-983d-724df81bbdb1@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=longli@linuxonhyperv.com \
    --cc=longli@microsoft.com \
    --cc=olivier.matz@6wind.com \
    --cc=qi.z.zhang@intel.com \
    --cc=sharmaajay@microsoft.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).