From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 03E4542544;
	Fri,  8 Sep 2023 10:01:34 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AD81A40274;
	Fri,  8 Sep 2023 10:01:33 +0200 (CEST)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by mails.dpdk.org (Postfix) with ESMTP id 39CD140042
 for <dev@dpdk.org>; Fri,  8 Sep 2023 10:01:31 +0200 (CEST)
Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.56])
 by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RhpRZ0K5gz1M90f;
 Fri,  8 Sep 2023 15:59:38 +0800 (CST)
Received: from [10.67.121.175] (10.67.121.175) by
 kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.31; Fri, 8 Sep 2023 16:01:27 +0800
Message-ID: <adff2961-f63b-d155-0f04-b264841bd120@huawei.com>
Date: Fri, 8 Sep 2023 16:01:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 3/5] app/proc-info: fix never show RSS info
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 Vipin Varghese <vipin.varghese@amd.com>, "Mcnamara, John"
 <john.mcnamara@intel.com>
CC: "lihuisong@huawei.com" <lihuisong@huawei.com>
References: <20230826074607.16771-1-haijie1@huawei.com>
 <20230904072851.7384-1-haijie1@huawei.com>
 <20230904072851.7384-4-haijie1@huawei.com>
 <BYAPR11MB3366201B44487235D6D86678FFE8A@BYAPR11MB3366.namprd11.prod.outlook.com>
From: Jie Hai <haijie1@huawei.com>
In-Reply-To: <BYAPR11MB3366201B44487235D6D86678FFE8A@BYAPR11MB3366.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.175]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 kwepemi500020.china.huawei.com (7.221.188.8)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi, Pattan, Reshma

On 2023/9/6 0:29, Pattan, Reshma wrote:
> 
> 
>> -----Original Message-----
>> +		uint8_t *rss_key;
> 
> Instead of pointer can you just take key of type below, so u no need to do dynamic memory allocation using malloc and free .
>   
> Ex: uint8_t hash_key[RSS_HASH_KEY_LENGTH];
> 
> And then do below ?
> rss_conf.rss_key = hash_key;
> .

Thanks for your review, will fix it in next version.

Thanks,
Jie Hai