From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0051.outbound.protection.outlook.com [104.47.42.51]) by dpdk.org (Postfix) with ESMTP id 122E63777; Wed, 5 Apr 2017 11:50:46 +0200 (CEST) Received: from DM2PR03CA0024.namprd03.prod.outlook.com (10.141.96.23) by BLUPR03MB277.namprd03.prod.outlook.com (10.255.213.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Wed, 5 Apr 2017 09:50:46 +0000 Received: from BY2FFO11FD025.protection.gbl (2a01:111:f400:7c0c::179) by DM2PR03CA0024.outlook.office365.com (2a01:111:e400:2428::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17 via Frontend Transport; Wed, 5 Apr 2017 09:50:44 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD025.mail.protection.outlook.com (10.1.15.214) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1005.5 via Frontend Transport; Wed, 5 Apr 2017 09:50:44 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v359ofcs016066; Wed, 5 Apr 2017 02:50:42 -0700 To: Santosh Shukla References: <1491382264-23489-1-git-send-email-santosh.shukla@caviumnetworks.com> CC: , , , From: Shreyansh Jain Message-ID: Date: Wed, 5 Apr 2017 15:27:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491382264-23489-1-git-send-email-santosh.shukla@caviumnetworks.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131358594447222183; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39850400002)(39860400002)(39400400002)(39410400002)(39840400002)(39380400002)(39450400003)(2980300002)(1110001)(1109001)(339900001)(24454002)(199003)(189002)(377454003)(9170700003)(110136004)(8676002)(65826007)(54906002)(81166006)(53936002)(189998001)(38730400002)(229853002)(50466002)(65956001)(8936002)(36756003)(65806001)(230700001)(83506001)(85426001)(47776003)(33646002)(356003)(8656002)(6916009)(105606002)(2906002)(4001350100001)(6666003)(23746002)(50986999)(2950100002)(76176999)(54356999)(86362001)(4326008)(31696002)(5660300001)(64126003)(305945005)(6246003)(106466001)(77096006)(104016004)(31686004); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB277; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD025; 1:0S/2HLuaQJKU8ZC4ptAQKcprwS0kU25ay24vP29noIB9jPzLYk3/h1Ao6OK0heSoitWGXSUzuspCLNwSVS9DQZcrUbDv6Og8P4a3t5qmpu0JdLWlSOf5rPtRp8PLCMEH033UjJLtd24RTB0PK3kM97bs1zBchsobXCs0BqsAF0oiV5rD/ca1DV7D3m8jkrWTOL8OoJO7e/c1rTF1HVOkNvuzVGZDS6NFdW/FFEN95rss+LwYlQSFrP8JUbacpVUJjOOOCwTB6QxCQ9reAucVX8G4dzpGZiEndudThEG+Tsd8kHTvOLxRTkHTDxbohQQK5pLZ/O2h8YeiXVxJxUoVuZeVrAw7+L/uWEBmbVf5IFyBKLxWRz0jW+HrTF1luAwFpsH+t/VPgB2+vmLiHidL9Uy/QzrQKG5js4aX4kDs/FazV6HBbPZh5dx4mmGc3NO/CTDyhVZi/BjwR0Nbi15u2ZKKu8cSftvgU2RQN5DW7kVAnrSrhbFWfxtpFdl2PPmb5ZDkxqPO+tBNLbumEBVwXeDgjBnr8cUR9qvlKjh2usSWLq8tFQwj1V1VYRLPupQlyh65UqZ3iIcuRIqEFC6ueUIyQDkFVi5AVGgonuAzX5k= X-MS-Office365-Filtering-Correlation-Id: a3d18e68-80cf-4762-4447-08d47c093aad X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:BLUPR03MB277; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB277; 3:G6F9/6f4yKbyOygwkLRt37ursTgodfzI5QMhBL7A60dBcJCXW6myPbOaPXZ1qs0oBnQdeqa4Do8Xx1yfKLeRaPlmG6lDml0eoQMUoekDsGxLmRXYaCmTqWEowY8UGxphrtUI9x7IEg9F7I/RjBoGrlteZcJY4p4EOcsQbQKEzw6QV0Q9duESMXo9xAC1zvKUovCoA3l2hV4lceK8HNoFXtrcnOLKTREl51tFGaPxUT1s04qmRVBdmlFYVqmXc/2MkU8LniV7fGWFDZwyRjPF3mfCjTBGmYZ2F2eqW1rpps6Nb+YVsmLAg0NUE8TRnrz94J1mXAOuIJZpENoyjfgPSjhoU6nhXxLtt1f6ISy2Hu4eFzxYbIWD273d+FJgN7yvKh7GVuCIZOjk1fMsWSxtsINVJVsoepyqECPtJhP9As7himpsmILmkp3jF1w66TgZ; 25:brVBkVq/21YZYOpXuo8Nkx3e5GBkyUbXn29bMTdiqWbiPUYdWxJC7soXx2ZGa/FTGbLXNS4MA1cS2mhhDI4qVdJThK2QdEtZKK26nrCPdIf9BF/loCY4DPgJUm/6Kg26LOeBQ2nEEWf8p8vi8WkFQv0JFXU67o5cc5gq445DU8PRvWNc0P+5rqElyTNZTvijg1xXopEYPo2WAjUjbc29ygxNbkizb0iBZ0kvpBEs3nTaVUJUSgWatrplvpCIYx4fwnSCl6KanmnAS+x7Jv70HbTJXNWGRjqdZhZJzzTfCZIU70qXB8dzbbrB0RybiSIgPt0c78a8UJJ1B7n7TGNM1y7uARQyUt4t3Xa9pV0nb8nWQfKB/hu7eobEJoXQwV9uv+97iEylGMBLotK8AFYtxFRfeY6Dz9h9Arp5YGrd3zwbnC9UMc7iotikUT0hi4i8mT1gcHtlgZU/CsqZW2XhxQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB277; 31:7zQ7r6LoTvj5iEuD/eJAz7ZDTwDt4sCbfTg9tnDnXLB4dEmn+glqmqG2NUw74zJ4IEarLDTefWuOinMvGqGiQh/p+CZbyj7RRmQ0N0eS6XF6CPuWyL5gG1XoxpAc7xxw+Qks9f/Hxbc7b7sdUmgJgBVJe9Z3jXYxy6k+60DpEmsPkJbnRe68HLBq107PQRya7iuQDZ8KqHQWbNWCIjtWeta3Ca4q8BA49MdPvbu6QL6Ruuwn5nYKb1fwowFXcBny5R+mRV3xUDw9x6V4WwgKzg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13024025)(13023025)(13018025)(8121501046)(5005006)(13015025)(13017025)(3002001)(93006095)(93001095)(10201501046)(6055026)(6096035)(20161123561025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259075)(20161123565025)(20161123556025)(20161123563025); SRVR:BLUPR03MB277; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR03MB277; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB277; 4:OnujP4ugh/GNU4ULjWXQEUybKX46RbwZe/yS1mSZ9bO5lFHBpeC3tINk5HMWvp/dBwlZnEJc1LVFla+POj+EVrQ20wgh0PkFDxwvm6qlDSHnNcrHcUbb/MruffUR7FltcKM9MY70fNk3dNRPkO9EpZPbo3h4P1p/mAiD/e53RZy1UgPM/6IK/rsOOE2x/i854yR0MmKYA1CpV04Rk9zeyohsaIWcWS6Mj0eCfPf5QrI3/dwFlbT9/d/WqKvR/Rar2UUnvhcIW6XdOlaSZZSdgbxancqY6Gg71Bz9+H1ZsU+qIzYyKiK+DXmzsxT63uu58I4WgeUNXf4j1fVMk707KHl6BmbQRK7EIv95STYfwSqs+4Z+SVNnK3r5Y4XWcLyXth9CdRF0/MOhT1ZrOv4FZWxI/sZfnJmJW+H6Z1VMqY7weu6zT8oru+mkszUzs9psTNeY1X+q0iLPM+FYf2gPi3w7mmkZ6XdgUjoJT/Y4Bn/U+qAiX5W19Fqxj2OgCVe1mYUB3z7o7a6gZkAsf2/WrKuMECt1lDZ3+cnik+palykAFjPSF9Du+g77nYNVb9dgySWsumBg3Gcpi4kmSaiPnu9F4Fln8iWwRVJt56NsZ1cq9d7vuN6MhIVdla3FokgwJXqMufD3/uj8d7HjwdDcHIPA1MFCxCNSmW1rMYsEBA/qbPTCHtLGaEFbv4jk+2Zz6Ao54L2jvm+urQ54YJ8E2hBeosNoOGQlhbHNeBkKort1bsCtBL02YX66KnimKvGCwhAgDb47tqThBHkUxdnDOaFHvgzoCLm/H+goGTPevBQI0RukW/oL9mgxeB5wj5MoROj1ITtcRiDzLWrDAfNKJ9hmlpeff8fNYevFaYOFeb8lvuSvP+51P5mt+MmxW8TgYXHfdpfCRSTdUM7G6ezSPH24r0YaJ2nJqs4m0L3iX0c= X-Forefront-PRVS: 0268246AE7 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR03MB277; 23:5MTujzY5qJzEbBMp+m92wQWal6JvGcyubo7hWf?= =?Windows-1252?Q?H7YwBclJlYSo3ixVabKxOXAgkzMqc0vGKDIkkx18q1Pdl0Nh5actp4ax?= =?Windows-1252?Q?+CY918K7tBDq4VqS2tPfdzAZ/Pjqhq40Q/Y1OooxUswU293OsuLK8VaG?= =?Windows-1252?Q?ljcREzfo8mDyJoxyJiPlfz02ulNuD/rQ5kISe1B9LXqj5WXzuTjmgtR6?= =?Windows-1252?Q?9rirgHue5R3rBAsrFjl62S+kGecAv0fpc9L6eFQcK+o8RajC4PRAvpAh?= =?Windows-1252?Q?2+oIof/3Gf1IonVvkHny36uocgIxCv1r9iEJWe7H4nRCwvqvCOUtUnee?= =?Windows-1252?Q?kq0Xd4QmLyfMT7Xn7aTGaLPrgTYMK0PEvyde3WA4VFOSBLKkDEt8T/v/?= =?Windows-1252?Q?4Tyc7cuZqhwUB2VCcL4b3GbqJGUh0OUgAYoPEaQ0bb9tspU9VChSHcLA?= =?Windows-1252?Q?YaH5B/cHtx4lKjeFxeML10dj7x0lutExpqMHsp/EL5mPq87R+yJbRnab?= =?Windows-1252?Q?lPArm6TeVOChEKX6LbLqm9cTHAKhnyXhRea3MvcuE1+YCeRpc0OgAbnK?= =?Windows-1252?Q?gNbbFaFHOa+kizZf7wFJoQZTN36JbK/tlHUjh5OUsbPswQh4Xv8k9FlV?= =?Windows-1252?Q?2MYWoPi5n4NoUMxItsHfruZknGQirjK4qYf/SYtppzwbZ2wqoKhV51SU?= =?Windows-1252?Q?ocZUWOFDXEQNp6eny5k6wvbtO2RUJIdDVhauu9pbfpVr/ZBuZGQ80FYU?= =?Windows-1252?Q?1ZLB7YD8cNaleNhwvATgHAbnyfGNL/xDHWxnWZyl4rAQ7c7QOEqY8QiR?= =?Windows-1252?Q?AI6FOhhZv1MPJ8UbBGBUu5roR+In/MDDmMEMFqz8g72mqamnq/tIFzUU?= =?Windows-1252?Q?swY9dDEdnPgJDP8/YH4iRpEHiXjgh4u7K3lr/Jbl3Z1wgl+v2TRUWUfu?= =?Windows-1252?Q?bLanRU3THwKECpaZAjl8wsU7ODnj3EQNo9ixvzEqxVFGQpySo1jpzDgZ?= =?Windows-1252?Q?tr6/Yil7ue8UNIkoE4qbsjDpOHi7LuXRiaYFTHUsW0GEAhclIqHrPz7j?= =?Windows-1252?Q?eP6CowDmFzYH7a7CbrgUs61lC+lihz8XmDd8fZkrq6Y8TWFXgjabsupC?= =?Windows-1252?Q?kobJa15dlwG5QdJIfCd5wDY4imA04Ov6BehgIWz0xg/UjU/d41ux6HgH?= =?Windows-1252?Q?lKXdqCRf6nA+/7ziW2KIhBdFcYh2vuJK6yIjIb5POmfsd1WbvEuojGQ1?= =?Windows-1252?Q?ggKRAV8Zz3fy444v6qkSxAf4Fon9npe1IIthiLr6o1EoBq9tFoJy7I0k?= =?Windows-1252?Q?pbqGtztvemZ38P69jo5TV+4NWzbcKLbs5nUhunjxV5L1YYBjx0sxbvDj?= =?Windows-1252?Q?pf76TS7woNjGQFob3ckjNA2eJu09eWIHu9upeu3JxJ1jc+5EKMzdFo2E?= =?Windows-1252?Q?TYDTOXswNvdd1UiiFKdnQlCIm4m0Ic+I8nvyWicqVy3lTgxtMLzHH07u?= =?Windows-1252?Q?Vxj2vLCx7hlH3uVNRiBrdnNHmXB0W3J+1cUieW9geFRA4LjOdctsovlP?= =?Windows-1252?Q?Pc1uuCXxTacNIhss2Qr8rEzPemEhm2iheV?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB277; 6:8BnpJgo3GDnxdnPJ2Ej/JyXSMYRJpOqPHsj0Yah70pdPsJ+j4ibJE1wQVB7sC+b0HpNzKC+Iao3ur3Ut2V2/gamuTyuTRr9TB913oYFeD8e/zkqSW2h7qTuHQJQ7xAOpo6IMZS4bKGikoUKOuSyd06PnY0X/yVNQITjQYlLTzhjml0pc0SjPx5oap86T0JLpdmAu3uhQbTRKkILhmgoc6pzCG+VmwdUzojviuGIW0BuBXBTawrBICWa/Ez3a1vBuYJyJtDWQ5/P0pQjAw5FByySBrQUHD/RRiP1lfz8C6OfaiTbX/swXAOeKDsMHsLoPrEQI5tniUbAFp6OAZwHXjAvwEa/brYXSdS+yw27VQivTaJ9z5UArgR54ASz4S2WlxFhLz2MU2rD7j46Y7eHe5g==; 5:fXdo3ntJQbDSgZIhkf0Ioy6LYcKiPvIsM+VfhAn5XKQPvgu/T7iKWp2kDdIPjbmngcx0ABRGI36Yuur4g61T0IuyFQs2Lf3R4D4lVbyYLKaZIRCuu2jjet+97QArOoTlTTjNIvgVoo+SMXRbn4+b7sM6uDPOrk4wv6bxZvkhFXqb/Wk8RWiidkWIFTHTgefw; 24:bxBscjUTt8WF200QWkIHCPlHrLJNQzUTd08ZMiQ3Ei25zg7OaKPLuYnognmSZ//CwpjvyKDkRjFGsTOM4Dcc+3scZTpk1w0cQyXFRKah2hA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB277; 7:EXySawmrtZH3pNbNuatlE0WNCvoniZ6xTQsDdD8iA9vYp0UBgKBOH6ffTcDhHKK2mOCnL6RI4wWSxCVbfISqzvSMmFiT3Td4f7V5SlWzPECnPVC+SSGlPp72HhsGtNT/+Nj5zukl0hx0Ntkx47rbiRlJcJtN8RzCjAxDieo2/KFlAwjBR61Ie+T2PfKZ7mUKS4NNKpe8IJ9l85W7UH4pwU5QMo6z4r7ZRmjQp+k8puPUB4sfPZiag7ny+rInQaQTZic2Sr2xZ7SJtP+q7p0oY/RMYnilURnfbK9XaHB6vWUpNnsX7T+3KpIGALJ91HU1lmkR6DwHc7Plg9asmS7lcA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2017 09:50:44.5194 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB277 Subject: Re: [dpdk-dev] [PATCH 1/2] test/mempool_perf: Free mempool on exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 09:50:47 -0000 Hello Santosh, On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote: > Mempool_perf test not freeing pool memory. > > Cc: stable@dpdk.org > Signed-off-by: Santosh Shukla > --- > test/test/test_mempool_perf.c | 31 +++++++++++++++++++------------ > 1 file changed, 19 insertions(+), 12 deletions(-) > > diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c > index ebf1721..3c45971 100644 > --- a/test/test/test_mempool_perf.c > +++ b/test/test/test_mempool_perf.c > @@ -312,6 +312,8 @@ struct mempool_test_stats { > static int > test_mempool_perf(void) > { > + int ret = -1; > + > rte_atomic32_init(&synchro); > > /* create a mempool (without cache) */ > @@ -322,7 +324,7 @@ struct mempool_test_stats { Can you check why the patch is showing "struct mempool_test_stats" as the context? I tried creating this patch and it shows "test_mempool_perf(void)" as context. off the topic, does it matter to maintainers if context is not correct? > my_obj_init, NULL, > SOCKET_ID_ANY, 0); > if (mp_nocache == NULL) > - return -1; > + goto err; > > /* create a mempool (with cache) */ > if (mp_cache == NULL) [...] > +err: > + rte_mempool_free(mp_cache); > + rte_mempool_free(mp_nocache); > + return ret; > } > > REGISTER_TEST_COMMAND(mempool_perf_autotest, test_mempool_perf); > Other than that: Acked-by: Shreyansh Jain