From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C76F4A0548;
	Tue, 31 May 2022 17:15:53 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B783D4067B;
	Tue, 31 May 2022 17:15:53 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 88A1340143
 for <dev@dpdk.org>; Tue, 31 May 2022 17:15:52 +0200 (CEST)
Received: from [192.168.1.38] (unknown [188.170.81.145])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 6ABC086;
 Tue, 31 May 2022 18:15:51 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 6ABC086
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1654010152;
 bh=YDa9cM0JWZGL/Xy9udI31yqRqYYSYwazbcOY5cIWJBA=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=fwLiiO3LCPeInat9r3A0hvAqzxFQWb0iAqRKkb33ao7qw4dU19wDOily/P2yHp2Vs
 590uy0c6KCbHGlpFu0nf+wk37vxxtA8ZEidYiBYELBycucg8vUHMvCRxKVGrxE8DNj
 F3ArILm9nN34IzhQ8qywD5D8zns7oeusVGLB7xGg=
Message-ID: <ae0d9366-8ad2-9350-baad-b5ea8290cf42@oktetlabs.ru>
Date: Tue, 31 May 2022 18:15:50 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2 1/2] app/testpmd: mark most cmdline symbols as static
Content-Language: en-US
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
 Xiaoyun Li <xiaoyun.li@intel.com>, Aman Singh <aman.deep.singh@intel.com>,
 Yuying Zhang <yuying.zhang@intel.com>, Ori Kam <orika@nvidia.com>
References: <20220513075718.18674-1-david.marchand@redhat.com>
 <20220524200642.1322115-1-david.marchand@redhat.com>
 <20220524200642.1322115-2-david.marchand@redhat.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20220524200642.1322115-2-david.marchand@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 5/24/22 23:06, David Marchand wrote:
> All those symbols don't need to be global, plus it was hiding unused
> code such as:
> - cmd_set_conntrack_dir_set and cmd_set_conntrack_dir_conntrack in
>    cmdline.c,
> - cmd_create_port_meter_g_action, cmd_create_port_meter_r_action,
>    cmd_create_port_meter_y_action in cmdline_mtr.c,
> 
> Mark those symbols as static.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>