From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 43C2B1B4C6 for ; Thu, 27 Sep 2018 15:33:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2018 06:33:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,310,1534834800"; d="scan'208";a="73417980" Received: from mtcoatex-mobl.ger.corp.intel.com (HELO [10.252.3.51]) ([10.252.3.51]) by fmsmga007.fm.intel.com with ESMTP; 27 Sep 2018 06:28:13 -0700 To: Paul Luse References: <20180921162557.48249-1-paul.e.luse@intel.com> Cc: dev@dpdk.org, Anatoly Burakov From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Thu, 27 Sep 2018 14:28:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180921162557.48249-1-paul.e.luse@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 13:33:25 -0000 On 9/21/2018 5:25 PM, Paul Luse wrote: > From: paul luse > > This patch fixes an issue caught with ASAN where a vdev_scan() > to a secondary bus was failing to free some memory. > > Signed-off-by: paul luse (carry from Anatoly's ack from other thread) Acked-by: Anatoly Burakov Acked-by: Ferruh Yigit @Anatoly, what do you think about: diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h index e114dcbdc..e1a554f5a 100644 --- a/lib/librte_eal/common/include/rte_eal.h +++ b/lib/librte_eal/common/include/rte_eal.h @@ -309,7 +309,7 @@ rte_mp_sendmsg(struct rte_mp_msg *msg); * This function sends a request message to the peer process, and will * block until receiving reply message from the peer process. * - * @note The caller is responsible to free reply->replies. + * @note The caller is responsible to free reply->msgs. * * @param req * The req argument contains the customized request message.