From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 868D8436E2; Wed, 13 Dec 2023 14:20:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29604402ED; Wed, 13 Dec 2023 14:20:22 +0100 (CET) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 0D20B4021D for ; Wed, 13 Dec 2023 14:20:21 +0100 (CET) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 9FA15BB50 for ; Wed, 13 Dec 2023 14:20:20 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 92F94BF32; Wed, 13 Dec 2023 14:20:20 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.6 X-Spam-Score: -1.5 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 23E53C123; Wed, 13 Dec 2023 14:20:19 +0100 (CET) Message-ID: Date: Wed, 13 Dec 2023 14:20:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/9] eventdev: clarify all-types flag documentation To: Bruce Richardson , dev@dpdk.org Cc: jerinj@marvell.com References: <20231120172606.505579-1-bruce.richardson@intel.com> <20231212113223.31147-1-bruce.richardson@intel.com> <20231212113223.31147-3-bruce.richardson@intel.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20231212113223.31147-3-bruce.richardson@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023-12-12 12:32, Bruce Richardson wrote: > Rather than requiring that any device advertising the > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag support all of atomic, ordered > and parallel scheduling, we can redefine the field so that it basically > means that you don't need to specify the queue scheduling type at config > time. Instead all types of supported events can be sent to all queues. > > Suggested-by: Mattias Rönnblom Please use . > Signed-off-by: Bruce Richardson > Acked-by: Jerin Jacob > --- > lib/eventdev/rte_eventdev.h | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index d48957362c..35865f017f 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -250,11 +250,22 @@ struct rte_event; > * @see rte_event_dequeue_burst() > */ > #define RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES (1ULL << 3) > -/**< Event device is capable of enqueuing events of any type to any queue. > +/**< Event device is capable of accepting enqueued events, of any type > + * advertised as supported by the device, to all destination queues. > + * > + * When this capability is set, the "schedule_type" field of the > + * rte_event_queue_conf structure is ignored when a queue is being configured. > + * Instead the the "sched_type" field of each event enqueued is used to "The the" -> "the". > + * select the scheduling to be performed on that event. > + * > * If this capability is not set, the queue only supports events of the > - * *RTE_SCHED_TYPE_* type that it was created with. > + * *RTE_SCHED_TYPE_* type specified in the rte_event_queue_conf structure > + * at time of configuration. > * > - * @see RTE_SCHED_TYPE_* values > + * @see RTE_SCHED_TYPE_ATOMIC > + * @see RTE_SCHED_TYPE_ORDERED > + * @see RTE_SCHED_TYPE_PARALLEL > + * @see rte_event_queue_conf.schedule_type > */ > #define RTE_EVENT_DEV_CAP_BURST_MODE (1ULL << 4) > /**< Event device is capable of operating in burst mode for enqueue(forward,