From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0634CA0555; Thu, 9 Jun 2022 16:02:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD80940689; Thu, 9 Jun 2022 16:02:40 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2049.outbound.protection.outlook.com [40.107.243.49]) by mails.dpdk.org (Postfix) with ESMTP id 9260840220 for ; Thu, 9 Jun 2022 16:02:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UaGYbIULy6fXIxyDFxNjvrPR7Nm2/Y1TDTjXwz+bsdZ6lBeZk61ZWpb4JV7nLZCHS6NugTxKnTObXFR8pdL06LSn4gFiuwOOtVaEkt+mNGXioOwfpW3Ui+auVfWKR7VONfaYlrky7cpmk3fjVEi8s/8+o/Gc6NDLDNlx+crKbgiDeJWBrDD/pJctSqnJWGx0CzJzRTa52E01IPPbjwZBodupn+SrCc9czN4FPdAxL2fKv/Es0iBJfV4cjIA6ApxpMhaJbPqQGwOZRlQ/azRp7WdBCCBoZbROU1R1NZF3L8S4gciFlOMWOiCfvCVf4NNrPPw8KjM5pd6mgKg7a+OsMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MFU2uAVvNti7Yga9AQj5lYWwoJy7xDcLQsZKLxtK4wY=; b=Krmns15zQKQsFZRlrKCYSr1B/TYOYL8U4x7YINzZP/CIiwViICYe0dAkQZMBqm6ruumYKhGz7M7gFNelDeWt2GEBYSaMlr9OASvCB0L1hGw2y6faRp9lGDcj+YjmM1v6Q5i5xDL5ucOm+mUmblt2TpsMr8/TqzNRvQ8Y1EuEZHUBWnYmkokKL4fCkKBwY/DNj5mYjI0ACmkXuQ5aHr+ODsz6Ts4LjFWWfYRpZKad1U81NLY4GPxA9ixRICfULjvDtTXYB1IBj7pF6uUx+wYQKrfFbVD1+EQCzoHcGdKkkBlMOY7WTmxjDT1uHif6oUPZzPH2OUDgamG0wl3uPgQz8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=chelsio.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MFU2uAVvNti7Yga9AQj5lYWwoJy7xDcLQsZKLxtK4wY=; b=VwW8OrYkO2nTp5kAgeJS2ibG9uVbQ+WAxP8HzlGqheJuvrKBGD6fLy9XwE9l3svEr+Zn9n7pkfi59XLmWcT187KXX88OWdfochKZehlgHt7HfcDTa663V9fvj8/jVG7EUKhFUUjxq9B1BJ+ApNLLe7IFcUz728lyPsaGS+dITeI= Received: from SN6PR05CA0021.namprd05.prod.outlook.com (2603:10b6:805:de::34) by DM6PR02MB4716.namprd02.prod.outlook.com (2603:10b6:5:ff::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Thu, 9 Jun 2022 14:02:37 +0000 Received: from SN1NAM02FT0009.eop-nam02.prod.protection.outlook.com (2603:10b6:805:de:cafe::85) by SN6PR05CA0021.outlook.office365.com (2603:10b6:805:de::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.7 via Frontend Transport; Thu, 9 Jun 2022 14:02:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0009.mail.protection.outlook.com (10.97.4.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5332.12 via Frontend Transport; Thu, 9 Jun 2022 14:02:37 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 9 Jun 2022 15:02:35 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 9 Jun 2022 15:02:35 +0100 Envelope-to: rahul.lakkireddy@chelsio.com, daxuex.gao@intel.com, dev@dpdk.org Received: from [10.71.117.247] (port=49638) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nzIk7-00009e-Kb; Thu, 09 Jun 2022 15:02:35 +0100 Message-ID: Date: Thu, 9 Jun 2022 15:02:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] net/cxgbe: fix warnings when using optimization=1 flag Content-Language: en-US To: Rahul Lakkireddy CC: , References: <155c777425bc32c4d287373cd711825f8de9bcf2.1654764457.git.rahul.lakkireddy@chelsio.com> From: Ferruh Yigit In-Reply-To: <155c777425bc32c4d287373cd711825f8de9bcf2.1654764457.git.rahul.lakkireddy@chelsio.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a885bd6b-ad1a-4e6a-1123-08da4a20b5aa X-MS-TrafficTypeDiagnostic: DM6PR02MB4716:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YiplIjx1Igw/OAKqWFmouRL5uqcDiUiOY8UGlgWgQqMFaEGx+dnfwC1T3h2R/jv5rMrVdMy3tpQDinzmCb4RcJzoXgjB59RiO2oMhGxYoMqpoq4/IsoCEUW+f1kzm/jYTbSVHF7PPptX6pCXYY4uaD6uGizsgct8eVNufui5FsHci3JxMTPC1wfByWLJPWRZ8NyFq91W+Ke53VUNBIbwdQrFnkKUQXa0t6IS032mScJmU/wnyuhv2eiZJUjWvk7A/byhdx/Im/IDcMo+b7jFQJa05I3E5rb/c2vM3ooQ7PwgVWZzgWB5t+PAC6bUbLvmQWZF0TwIR4aNpqZ4jliPNoPM3btzMoX5BpQyMmI9ippw8LXwglNuYXQ1uE4gCiLXe/et44egNMcLYIB3ChODGlVT1ZlFzt+EE48mUNYxNErdzjq6Y1TETsYUKGVSy+vPpCIpPsjwWpo/lGe8lwmOpczQaVEbXBWwz0hZy0UGdiBh4/6JoUw3fCOq8IQzmlZOCblL0ViEKdxrYqNuXZ3T6PAPS33zkLmDkOwkXHfCCKrjYrHChrQuiRr2iXDAD0v75C/+Wn6QaCvR8QKPajiB1yP9UdcYbM+8ORE9SwxBVE3p2GMlCtB9WECe/9q4/K6g+PE8Q3Pkbfk/BeeOjnbsJoRPeENPOaC+jEshruHzDUZJRYnLC0Xq2P9cLRKKzHyc9RBKVWBgW6NUeoHfUpW6MtCmk83Ed0YVzkv3vgfHUWY= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(83380400001)(9786002)(44832011)(8936002)(2616005)(356005)(40460700003)(54906003)(70586007)(5660300002)(6916009)(2906002)(316002)(31696002)(8676002)(70206006)(508600001)(82310400005)(4326008)(186003)(47076005)(36756003)(336012)(7636003)(53546011)(36860700001)(26005)(31686004)(426003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2022 14:02:37.0764 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a885bd6b-ad1a-4e6a-1123-08da4a20b5aa X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0009.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4716 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/9/2022 9:49 AM, Rahul Lakkireddy wrote: > Initialize maddr and mtype to fix following warnings when > using optimization=1 compilation flag. > > In file included from ../drivers/net/cxgbe/base/common.h:13, > from ../drivers/net/cxgbe/cxgbe_main.c:37: > ../drivers/net/cxgbe/cxgbe_main.c: In function ‘cxgbe_probe’: > ../drivers/net/cxgbe/base/t4fw_interface.h:656:7: warning: ‘maddr’ may be used uninitialized in this function [-Wmaybe-uninitialized] > ((x) << S_FW_CAPS_CONFIG_CMD_MEMADDR64K_CF) > ^~ > ../drivers/net/cxgbe/cxgbe_main.c:1111:40: note: ‘maddr’ was declared here > u32 finiver, finicsum, cfcsum, mtype, maddr, param, val; > ^~~~~ > In file included from ../drivers/net/cxgbe/base/common.h:13, > from ../drivers/net/cxgbe/cxgbe_main.c:37: > ../drivers/net/cxgbe/base/t4fw_interface.h:648:7: warning: ‘mtype’ may be used uninitialized in this function [-Wmaybe-uninitialized] > ((x) << S_FW_CAPS_CONFIG_CMD_MEMTYPE_CF) > ^~ > ../drivers/net/cxgbe/cxgbe_main.c:1111:33: note: ‘mtype’ was declared here > u32 finiver, finicsum, cfcsum, mtype, maddr, param, val; > ^~~~~ > Bugzilla ID: 1029 > Fixes: 6d7d651bbc15 ("net/cxgbe: read firmware configuration file from filesystem") > > Reported-by: Daxue Gao > Signed-off-by: Rahul Lakkireddy Applied to dpdk-next-net/main, thanks.