From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.hunt@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1412E376C for <dev@dpdk.org>; Mon, 4 Sep 2017 16:15:47 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 07:15:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="896947794" Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.50]) ([10.237.220.50]) by FMSMGA003.fm.intel.com with ESMTP; 04 Sep 2017 07:15:45 -0700 To: Zhiyong Yang <zhiyong.yang@intel.com>, dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, keith.wiles@intel.com, stephen@networkplumber.org References: <20170809084203.17562-1-zhiyong.yang@intel.com> <20170904055734.21354-1-zhiyong.yang@intel.com> <20170904055734.21354-3-zhiyong.yang@intel.com> From: "Hunt, David" <david.hunt@intel.com> Message-ID: <ae5d7903-0bfa-fb85-1f09-a2e83cea13eb@intel.com> Date: Mon, 4 Sep 2017 15:15:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170904055734.21354-3-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 2/4] examples: increase port_id range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 04 Sep 2017 14:15:48 -0000 Hi Zhiyong, On 4/9/2017 6:57 AM, Zhiyong Yang wrote: > Modify port_id related code in examples accordingly since port_id > definition in lib and pmd changes. > > Fix some original checkpatch issues and remove some unnecessary > cast at the same time. > > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com> > --- ---big snip--- I noticed that in /test/test/test_pmd_perf.c after applying the patch set, RTE_PORT_ALL is still 8-bit: -#define RTE_PORT_ALL (~(uint8_t)0x0) This probably needs to be: +#define RTE_PORT_ALL (~(portid_t)0x0) Regards, Dave.