From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9794EA00C2; Tue, 27 Sep 2022 11:58:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D50541133; Tue, 27 Sep 2022 11:58:07 +0200 (CEST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id CBF80410D0 for ; Tue, 27 Sep 2022 11:58:06 +0200 (CEST) Received: by mail-pg1-f176.google.com with SMTP id b5so8940607pgb.6 for ; Tue, 27 Sep 2022 02:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date; bh=81tJa0oHWDtKw3bKK1OeZOaKHvhAkoxmBVqYI+gKwlU=; b=P7RkhK5M+SiYB914Gvpg93UKnPfiPs5e6pbtTkHW1BihzCZW1D9D6jB6OiFGlbZ6t+ DV+4Jb/FTzMjesSYVI42liNNyHlBz/PMoF8dAP14QXCLXicOQNcshbb7r53UIFhYPoZ0 exNztTcTL4njvacIhgK3A17DYbHjG1DhwlaoLd0vFnECZN4E0RN3gixbFezgtBTmBvxF VLQL0aEzGsh1PG5XoOSBP12BJvrPdn4CxI9MtF5HoHNva3y3VS9lt3Au8Bc4LuSKHAET kyM648x7HrCnk25f8E6S/Q0DU8i4FmrSSsYVrHE/Y3FPLCpuR4QFia+x6ZR57vjqpS7T MKdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date; bh=81tJa0oHWDtKw3bKK1OeZOaKHvhAkoxmBVqYI+gKwlU=; b=RZi1fQr10pc6G1ofhfqhHJCyzqEH9vRzf7vmrNVg+fc/2zGpV5a/AbySlpWQnEf0Z5 dRaqvzQj9SohBP4b5eueGWecxEjatXwWUWq+X/JadVu3L+wfeZZm9UpV4JRXn38Wkhaf 2/wraAQfaPKQQyJnIFhyRmsM/5oX8EC4fad8qhFKjbedkO25HoUAT4CUGRr9F5XBjyXV hXZrCYqgdqI6LbTdWo0foeCJLDscyfGO084jtaYs7G5kx2R2DYC+WcNHVU9v2mlEa3LG jOr+SmoVpmjxHQjMQp7GNJUDD9DSabvY3UFtexrNK8HRW0ZJ/bKuRdRVoAgsDvDLb1t6 0vdw== X-Gm-Message-State: ACrzQf0UhrHipic6ZH2r+iSMUaar09MkyoSrliPl005V0vC1AhlDWSal 16nfN4YivovBDzYsHcMpkyeVTg== X-Google-Smtp-Source: AMsMyM77Y9JxY+3UnIiQSPge9bv/LZKyKbvUvMKvKJ7yEbKf9tE5Rr+GUcxzGpfNQ/YmoDhCoCPlAw== X-Received: by 2002:a05:6a00:24d2:b0:542:f6e3:e18d with SMTP id d18-20020a056a0024d200b00542f6e3e18dmr28333259pfv.36.1664272686042; Tue, 27 Sep 2022 02:58:06 -0700 (PDT) Received: from [100.64.100.6] ([45.128.198.19]) by smtp.gmail.com with ESMTPSA id d65-20020a623644000000b0053e7d3b8d6dsm1298142pfa.1.2022.09.27.02.57.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 02:58:05 -0700 (PDT) Subject: Re: [EXT] [PATCH v2 2/5] crypto/uadk: introduce uadk crypto driver To: Akhil Goyal , Declan Doherty , Fan Zhang , Ashish Gupta , Ray Kinsella Cc: "dev@dpdk.org" , "acc@openeuler.org" References: <20220923024023.15849-1-zhangfei.gao@linaro.org> <20220923024023.15849-3-zhangfei.gao@linaro.org> From: Zhangfei Gao Message-ID: Date: Tue, 27 Sep 2022 17:57:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2022/9/26 下午4:36, Akhil Goyal wrote: >> Introduce a new crypto PMD for hardware accelerators based on UADK [1]. >> >> UADK is a framework for user applications to access hardware accelerators. >> UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share >> the same page table between IOMMU and MMU. >> Thereby user application can directly use virtual address for device dma, >> which enhances the performance as well as easy usability. >> >> This patch adds the basic framework. >> >> [1] https://github.com/Linaro/uadk >> >> Test: >> sudo dpdk-test --vdev=crypto_uadk (--log-level=6) >> RTE>>cryptodev_uadk_autotest >> RTE>>quit > Remove this test info. It can be in your last patch where test app changes are introduced. > > >> Signed-off-by: Zhangfei Gao >> --- >> drivers/crypto/meson.build | 1 + >> drivers/crypto/uadk/meson.build | 36 +++ >> drivers/crypto/uadk/uadk_crypto_pmd.c | 450 ++++++++++++++++++++++++++ >> drivers/crypto/uadk/version.map | 3 + >> 4 files changed, 490 insertions(+) >> create mode 100644 drivers/crypto/uadk/meson.build >> create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c >> create mode 100644 drivers/crypto/uadk/version.map >> >> diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build >> index 147b8cf633..ee5377deff 100644 >> --- a/drivers/crypto/meson.build >> +++ b/drivers/crypto/meson.build >> @@ -18,6 +18,7 @@ drivers = [ >> 'octeontx', >> 'openssl', >> 'scheduler', >> + 'uadk', >> 'virtio', >> ] >> >> diff --git a/drivers/crypto/uadk/meson.build b/drivers/crypto/uadk/meson.build >> new file mode 100644 >> index 0000000000..a67c6c7ca5 >> --- /dev/null >> +++ b/drivers/crypto/uadk/meson.build >> @@ -0,0 +1,36 @@ >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright 2022-2023 Huawei Technologies Co.,Ltd. All rights reserved. >> +# Copyright 2022-2023 Linaro ltd. >> + >> +if not is_linux >> + build = false >> + reason = 'only supported on Linux' >> + subdir_done() >> +endif >> + >> +if arch_subdir != 'arm' or not dpdk_conf.get('RTE_ARCH_64') >> + build = false >> + reason = 'only supported on aarch64' >> + subdir_done() >> +endif >> + >> +sources = files( >> + 'uadk_crypto_pmd.c', >> +) >> + >> +deps += 'bus_vdev' >> +dep = cc.find_library('libwd_crypto', dirs: ['/usr/local/lib'], required: false) > I believe dirs is not required. You cannot assume that the lib is installed in /usr/local/lib/. > Check other PMDs which have such dependencies. Eg. Ipsec-mb Double checked, This is workable via setting env for building. export LIBRARY_PATH=/usr/local/lib Thanks