From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0DB9E1094 for ; Mon, 16 Jan 2017 18:19:27 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 16 Jan 2017 09:19:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,240,1477983600"; d="scan'208";a="1083648449" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga001.jf.intel.com with ESMTP; 16 Jan 2017 09:19:25 -0800 To: Adrien Mazarguil , Olivier Matz References: <1484153041-18034-1-git-send-email-olivier.matz@6wind.com> <20170116140323.GD3779@6wind.com> Cc: dev@dpdk.org, Matthieu Ternisien d'Ouville From: Ferruh Yigit Message-ID: Date: Mon, 16 Jan 2017 17:19:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170116140323.GD3779@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx: remove link update lock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 17:19:28 -0000 On 1/16/2017 2:03 PM, Adrien Mazarguil wrote: > On Wed, Jan 11, 2017 at 05:44:01PM +0100, Olivier Matz wrote: >> From: Matthieu Ternisien d'Ouville >> >> Retrieving link status information through the link update callback should >> be quick and non-blocking. >> >> Mellanox PMDs retrieve this information through ioctl() calls on the >> related kernel netdevice. This appears to take a long time to >> complete and may cause significant slowdowns in applications. >> >> While these system calls cannot be accelerated, removing the lock on the >> private structure allows applications to perform other control operations >> from separate threads in the meantime. This function remains safe without >> locking as it does not write the private structure, it is only used to >> retrieve the name of the netdevice. >> >> Signed-off-by: Matthieu Ternisien d'Ouville >> Signed-off-by: Olivier Matz >> --- >> drivers/net/mlx4/mlx4.c | 32 ++++++-------------------------- >> drivers/net/mlx5/mlx5.c | 2 +- >> drivers/net/mlx5/mlx5.h | 1 - >> drivers/net/mlx5/mlx5_ethdev.c | 30 ++++++------------------------ >> 4 files changed, 13 insertions(+), 52 deletions(-) > > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.