From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"techboard@dpdk.org" <techboard@dpdk.org>
Cc: dev@dpdk.org, Michel Machado <michel@digirati.com.br>,
Kevin Traynor <ktraynor@redhat.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Cody Doucette <doucette@bu.edu>,
Andre Nathan <andre@digirati.com.br>,
Qiaobin Fu <mengxiang0811@gmail.com>, nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
David Marchand <david.marchand@redhat.com>,
jerinj@marvell.com, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data
Date: Tue, 20 Oct 2020 15:32:05 +0100 [thread overview]
Message-ID: <ae9fd17e-79c5-920f-c221-19aa28a6a76f@intel.com> (raw)
In-Reply-To: <1622221.TErq07bq3z@thomas>
Hi,
On 20/10/2020 15:22, Thomas Monjalon wrote:
> 19/10/2020 16:53, David Marchand:
>> On Fri, Oct 16, 2020 at 12:54 AM Honnappa Nagarahalli
>> <Honnappa.Nagarahalli@arm.com> wrote:
>>>>> IMO, this is not a performance critical path and it is not a difficult solution to
>>>> store these values in the application. My suggestion is to skip adding the API
>>>> and store the values in the application.
>>>>> Vladimir, what's your opinion?
>>>>
>>>> Agree. Global vars or part of a global configuration could be used here.
>>> Thank you. I think we are fine to go ahead with merging this patch.
>>
>> I saw Honnappa and Kevin acks, are other techboard members aware and
>> okay with this change?
>
> This is an API change for better maintenance.
> I'm not sure the benefit is big enough,
> but the cost for the applications is said to be workable.
> Better to do it now than later, so
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> (at the condition it is added in release notes)
>
> What others think?
>
This changes LGTM (agree with Thomas about release notes).
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
--
Regards,
Vladimir
next prev parent reply other threads:[~2020-10-20 14:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 8:15 [dpdk-dev] [PATCH 0/2] LPM changes Ruifeng Wang
2020-09-07 8:15 ` [dpdk-dev] [PATCH 1/2] lpm: fix free of data structure Ruifeng Wang
2020-09-15 15:55 ` Bruce Richardson
2020-09-15 16:25 ` Medvedkin, Vladimir
2020-09-07 8:15 ` [dpdk-dev] [PATCH 2/2] lpm: hide internal data Ruifeng Wang
2020-09-15 16:02 ` Bruce Richardson
2020-09-15 16:28 ` Medvedkin, Vladimir
2020-09-16 3:17 ` Ruifeng Wang
2020-09-30 8:45 ` Kevin Traynor
2020-10-09 6:54 ` Ruifeng Wang
2020-10-13 13:53 ` Kevin Traynor
2020-10-13 14:58 ` Michel Machado
2020-10-13 15:41 ` Medvedkin, Vladimir
2020-10-13 17:46 ` Michel Machado
2020-10-13 19:06 ` Medvedkin, Vladimir
2020-10-13 19:48 ` Michel Machado
2020-10-14 13:10 ` Medvedkin, Vladimir
2020-10-14 23:57 ` Honnappa Nagarahalli
2020-10-15 13:39 ` Michel Machado
2020-10-15 17:38 ` Honnappa Nagarahalli
2020-10-15 19:30 ` Medvedkin, Vladimir
2020-10-15 22:54 ` Honnappa Nagarahalli
2020-10-16 11:39 ` Kevin Traynor
2020-10-16 13:55 ` Michel Machado
2020-10-19 14:53 ` David Marchand
2020-10-20 14:22 ` Thomas Monjalon
2020-10-20 14:32 ` Medvedkin, Vladimir [this message]
2020-10-19 17:53 ` Honnappa Nagarahalli
2020-09-15 14:41 ` [dpdk-dev] [PATCH 0/2] LPM changes David Marchand
2020-10-19 13:37 ` Kevin Traynor
2020-10-21 3:02 ` [dpdk-dev] [PATCH v2 " Ruifeng Wang
2020-10-21 3:02 ` [dpdk-dev] [PATCH v2 1/2] lpm: fix free of data structure Ruifeng Wang
2020-10-21 3:02 ` [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data Ruifeng Wang
2020-10-21 7:58 ` Thomas Monjalon
2020-10-21 8:15 ` Ruifeng Wang
2020-10-22 15:14 ` David Marchand
2020-10-23 6:13 ` Ruifeng Wang
2020-10-23 16:08 ` Medvedkin, Vladimir
2020-10-23 9:38 ` [dpdk-dev] [PATCH v3 0/2] LPM changes David Marchand
2020-10-23 9:38 ` [dpdk-dev] [PATCH v3 1/2] lpm: fix free of data structure David Marchand
2020-10-23 9:38 ` [dpdk-dev] [PATCH v3 2/2] lpm: hide internal data David Marchand
2020-10-26 8:26 ` [dpdk-dev] [PATCH v3 0/2] LPM changes David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9fd17e-79c5-920f-c221-19aa28a6a76f@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=andre@digirati.com.br \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=doucette@bu.edu \
--cc=jerinj@marvell.com \
--cc=ktraynor@redhat.com \
--cc=mengxiang0811@gmail.com \
--cc=michel@digirati.com.br \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).