From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79A66A04DC; Tue, 20 Oct 2020 16:32:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7A85AD12; Tue, 20 Oct 2020 16:32:17 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5D758A9C3; Tue, 20 Oct 2020 16:32:12 +0200 (CEST) IronPort-SDR: 7Ig5DxGeFFlAFJ0Er3lIpd0ZdyvQmRIfu6UdJD0s5+U4RrLnZPGMD0GHtFjTcgH+8gmIQvdKhH j2uResWMYp7Q== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="167306711" X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="167306711" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 07:32:10 -0700 IronPort-SDR: pCd9zNIZb7cEpzqKNZu2vlYtSTPEeryxJTF6ODbPjg8JOGTmFFf2uQTw/zRzQ9EWKnkqmF412q qFivtmGJu3Lg== X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="533081205" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.252.6.68]) ([10.252.6.68]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 07:32:07 -0700 To: Thomas Monjalon , "techboard@dpdk.org" Cc: dev@dpdk.org, Michel Machado , Kevin Traynor , Ruifeng Wang , Bruce Richardson , Cody Doucette , Andre Nathan , Qiaobin Fu , nd , Honnappa Nagarahalli , David Marchand , jerinj@marvell.com, stephen@networkplumber.org References: <20200907081518.46350-1-ruifeng.wang@arm.com> <1622221.TErq07bq3z@thomas> From: "Medvedkin, Vladimir" Message-ID: Date: Tue, 20 Oct 2020 15:32:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <1622221.TErq07bq3z@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 20/10/2020 15:22, Thomas Monjalon wrote: > 19/10/2020 16:53, David Marchand: >> On Fri, Oct 16, 2020 at 12:54 AM Honnappa Nagarahalli >> wrote: >>>>> IMO, this is not a performance critical path and it is not a difficult solution to >>>> store these values in the application. My suggestion is to skip adding the API >>>> and store the values in the application. >>>>> Vladimir, what's your opinion? >>>> >>>> Agree. Global vars or part of a global configuration could be used here. >>> Thank you. I think we are fine to go ahead with merging this patch. >> >> I saw Honnappa and Kevin acks, are other techboard members aware and >> okay with this change? > > This is an API change for better maintenance. > I'm not sure the benefit is big enough, > but the cost for the applications is said to be workable. > Better to do it now than later, so > > Acked-by: Thomas Monjalon > (at the condition it is added in release notes) > > What others think? > This changes LGTM (agree with Thomas about release notes). Acked-by: Vladimir Medvedkin > -- Regards, Vladimir