From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5552CA04B1; Wed, 23 Sep 2020 16:03:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 177CB1D931; Wed, 23 Sep 2020 16:03:50 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 811341D8FC for ; Wed, 23 Sep 2020 16:03:48 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200923140347euoutp01bb3850ca70fe66998a9b3e8dcee97926~3bqBrB4Im1385913859euoutp01N for ; Wed, 23 Sep 2020 14:03:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200923140347euoutp01bb3850ca70fe66998a9b3e8dcee97926~3bqBrB4Im1385913859euoutp01N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600869827; bh=SSKu3lLVBgNXf0QB3r8FbCCagdaQxykQeBvNb1hdP+A=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=aaAiS8zF8J6F77tUAk76sK6chntmZGntPyfoPpgezYiOKfyza9SKrbRbBbpIiWoXf 1fRgtNadis3x76vojkVsrSFTKY0N9k4YMLxEbBEG7PpRJ5hvSynfDeKNj9r+D5T7+5 aplLGdLxiCyvzELeo5+YCNFB/zzh7L/jw+w/ANJQ= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200923140347eucas1p1a7f84b8094aa2dcb7e027251d28956a5~3bqBgREdH0523705237eucas1p1W; Wed, 23 Sep 2020 14:03:47 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 7A.1B.06456.3C55B6F5; Wed, 23 Sep 2020 15:03:47 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200923140347eucas1p149b6bf67cf157d2ee87a867d12127a25~3bqBKHXb50523705237eucas1p1V; Wed, 23 Sep 2020 14:03:47 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200923140347eusmtrp1cdd191ae3e52a3d5dd6321fe53debba7~3bqBH43V82217422174eusmtrp1D; Wed, 23 Sep 2020 14:03:47 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-93-5f6b55c37f0a Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id BD.50.06314.3C55B6F5; Wed, 23 Sep 2020 15:03:47 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200923140346eusmtip2b4d4185d15e8e1cee2c390463ca1bab8~3bqApjyFg1089110891eusmtip2R; Wed, 23 Sep 2020 14:03:46 +0000 (GMT) To: David Hunt , dev@dpdk.org Cc: "\"'Lukasz Wojciechowski'\"," From: Lukasz Wojciechowski Message-ID: Date: Wed, 23 Sep 2020 16:03:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42LZduzned3DodnxBp8/KFn0TfrIZPHu03Ym i2c96xgdmD1+LVjK6rF4z0smj4Pv9jAFMEdx2aSk5mSWpRbp2yVwZcx4c4C54B1nxYQ3R9gb GF+wdzFyckgImEjMaJjG0sXIxSEksIJR4tP2X4wQzhdGicWnljNDOJ8ZJe5NmMMI0/J651+o luWMEufPnmGFcN4ySryb944NpEpYwF/ib/slFhBbRMBY4vG/XUwgNrOAi0TblodgNpuArcSR mV+Bmjk4eAXcJE4+iwEJswioSvT+6gBbJioQJ3Hs1COwMbwCghInZz5hASnnBGo9uLwSYqK8 RPPW2cwQtrjErSfzmSDu7GaXWPSSB8J2kXhy4CkzhC0s8er4Fqj3ZSROT+4B+0VCYBujxNXf PxkhnP2MEtd7V0BVWUsc/vebDWQxs4CmxPpd+hBhR4nNr6cyg4QlBPgkbrwVhLiBT2LStulQ YV6JjjYhiGo9iac9Uxlh1v5Z+4RlAqPSLCSPzULyzSwk38xC2LuAkWUVo3hqaXFuemqxYV5q uV5xYm5xaV66XnJ+7iZGYBo5/e/4px2MXy8lHWIU4GBU4uHl0M2OF2JNLCuuzD3EKMHBrCTC 63T2dJwQb0piZVVqUX58UWlOavEhRmkOFiVxXuNFL2OFBNITS1KzU1MLUotgskwcnFINjIr3 PxYukNvqtvFe+7UfPJdlJhVXHxZbsfWGy4soUbm1CsvecDT+DLMV4priH7+uJk/pEuPkeC3/ Bf7eMrdiBBUcdq099OlAGZ8ri+qONcflPSdPun+1aNHWHK9Hq0R+TjANWrHLWbIhLv9NwuaV jxPlrvyZbKD2xm3JtIfWAocDme7fid3iW63EUpyRaKjFXFScCACbPaXGHwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsVy+t/xe7qHQ7PjDf7M5LTom/SRyeLdp+1M Fs961jE6MHv8WrCU1WPxnpdMHgff7WEKYI7SsynKLy1JVcjILy6xVYo2tDDSM7S00DMysdQz NDaPtTIyVdK3s0lJzcksSy3St0vQy5jx5gBzwTvOiglvjrA3ML5g72Lk5JAQMJF4vfMvSxcj F4eQwFJGiTvfNrB1MXIAJWQkPlwSgKgRlvhzrYsNouY1o8SE7VdZQRLCAr4Siz/uZgOxRQSM JR7/28UEUdTBJHG+6QELSIJZwEWibctDJhCbTcBW4sjMr6wgC3gF3CROPosBCbMIqEr0/upg BLFFBeIkzvS8AJvJKyAocXLmExaQck6g1oPLKyEmmknM2/yQGcKWl2jeOhvKFpe49WQ+0wRG oVlIumchaZmFpGUWkpYFjCyrGEVSS4tz03OLDfWKE3OLS/PS9ZLzczcxAuNm27Gfm3cwXtoY fIhRgINRiYeXQzc7Xog1say4MvcQowQHs5IIr9PZ03FCvCmJlVWpRfnxRaU5qcWHGE2BfpvI LCWanA+M6bySeENTQ3MLS0NzY3NjMwslcd4OgYMxQgLpiSWp2ampBalFMH1MHJxSDYxV1wpu vb1TGGiy9PVzAdOUJR6pyySXvElamGirslX4/DfLNWeOPw8Lf7P1vf+W0szZq8r/i86aInVu wtH1hk1XTOe8+KFetkX2+tGGZW5Cts9tvrZ6vTxlcipi44b67ZlJYjd1/wReXmAzza4sUe2A qg2f7kXdiaKe8wT8Fm4/Vcraxzor0DhdiaU4I9FQi7moOBEAIa/LN7ECAAA= X-CMS-MailID: 20200923140347eucas1p149b6bf67cf157d2ee87a867d12127a25 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200923014717eucas1p18699ad84d206e786a84f20dab9b65c33 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200923014717eucas1p18699ad84d206e786a84f20dab9b65c33 References: <20200915193449.13310-1-l.wojciechow@partner.samsung.com> <20200923014713.16932-1-l.wojciechow@partner.samsung.com> Subject: Re: [dpdk-dev] [PATCH v2 0/8] fix distributor synchronization issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 23.09.2020 o 10:46, David Hunt pisze: > Hi Lukasz, > > > On 23/9/2020 2:47 AM, Lukasz Wojciechowski wrote: >> During review and verification of the patch created by Sarosh Arif: >> "test_distributor: prevent memory leakages from the pool" I found out >> that running distributor unit tests multiple times in a row causes >> fails. >> So I investigated all the issues I found. >> >> There are few synchronization issues that might cause deadlocks >> or corrupted data. They are fixed with this set of patches for both >> tests >> and librte_distributor library. >> >> --- >> v2: >> * assign NULL to freed mbufs in distributor test >> * fix handshake check on legacy single distributor >>       rte_distributor_return_pkt_single() >> * add patch 7 passing NULL to legacy API calls if no bufs are returned >> * add patch 8 fixing API documentation >> >> > > Please include any Acked-by or Tested-by tags from previous versions. I added them in v3. I'm very sorry for not including them in v2. > > Rgds, > Dave. > Best regards Lukasz > > > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com