From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F2DF41B8A; Tue, 31 Jan 2023 08:52:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2B5241138; Tue, 31 Jan 2023 08:52:23 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 57CAF40DFB; Tue, 31 Jan 2023 08:52:22 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 6F2BA5D; Tue, 31 Jan 2023 10:52:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 6F2BA5D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1675151541; bh=EkJREF2kxfksmPZ9b5GmqucVxPQFTbjWVNeP/97EynY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=T46Y7D1hrkVZQuo7UbgNDheNkN4bXBJ2vY0sN2iv4TFqiX7YXnmTHYtLux6gut2xT eenh+aTVcFizUnvukv1/bkKiR4ed50aC5l9A4IbS6ZKIeti1iqW9hKqETsLjAMc9W1 dM/6LWk0NxDG4eUjMrwrwqQhtNWYV9gt1F3WxkIg= Message-ID: Date: Tue, 31 Jan 2023 10:52:20 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] net/sfc: export pick transfer proxy callback to representors Content-Language: en-US To: Ivan Malov , dev@dpdk.org Cc: stable@dpdk.org, Andy Moreton , Viacheslav Galaktionov References: <20230131072444.6925-1-ivan.malov@arknetworks.am> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20230131072444.6925-1-ivan.malov@arknetworks.am> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/31/23 10:24, Ivan Malov wrote: > Currently, the "pick transfer proxy ethdev" callback is only > advertised for non-representor (in example, main PF) ethdevs. > That does not sit well with the original idea of this method, > which is to let applications discover the privileged port to > use for transfer flow management instead of any given ethdev. > Applications trying to leverage this API on sfc representors > receive an error and cannot configure transfer flow offloads. > > Fix the problem by exporting the method to representor ports. > > Fixes: 26706314d418 ("net/sfc: implement transfer proxy port callback") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Malov > Reviewed-by: Andy Moreton > Reviewed-by: Viacheslav Galaktionov > --- > drivers/net/sfc/sfc_flow.c | 4 ++++ > drivers/net/sfc/sfc_flow.h | 2 ++ > drivers/net/sfc/sfc_repr.c | 10 ++++++++++ > 3 files changed, 16 insertions(+) > > diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c > index fb59abd0b5..2937953959 100644 > --- a/drivers/net/sfc/sfc_flow.c > +++ b/drivers/net/sfc/sfc_flow.c > @@ -2806,6 +2806,10 @@ const struct rte_flow_ops sfc_flow_ops = { > .pick_transfer_proxy = sfc_flow_pick_transfer_proxy, > }; > > +const struct rte_flow_ops sfc_repr_flow_ops = { > + .pick_transfer_proxy = sfc_flow_pick_transfer_proxy, > +}; > + It would be nice to know it is tested in some way. As far as I can see it can't work since sfc_flow_pick_transfer_proxy() treats eth_dev->process_private as struct sfc_adapter_priv, but it is sfc_repr in the case of sfc representor ethdev. Am I missing something?