From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 366EA43CEC; Tue, 19 Mar 2024 18:43:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21F6440298; Tue, 19 Mar 2024 18:43:39 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2041.outbound.protection.outlook.com [40.107.94.41]) by mails.dpdk.org (Postfix) with ESMTP id A696C40041 for ; Tue, 19 Mar 2024 18:43:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HO3a5/ooxrh4iCi019mEWf+ncKqp7nvhkcEPqEFa4axTyZ/7c2KNN7GSM/1VPpxGV2Pf1rJTi1dZdM92JRQLuFyaq2a16f1u0x1ZoRMgscW7rB3aQTlAFiR1cygf1QcrDLnQT0b+AojKiwIY0oIM1qRtWGk/1egKZ3NDCSJSsTa6HSOJvaIaeqpR5jsJ1K2kTpYEjHM9WbPicahJkYuB7pwO8ccICgZYQUXq0D03R2gf5tQ3nYvTYrfbV5YkjjvCZIuhMApJKiFuvK0OyBg1P1AZPsx3rZaEKbv9nTCNqytqClcJY1RsnXBi20B5E/h1gLB+xA3tENuM91CcOkGEew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lkMZHz6gDewY+245j+9nv4E7nACCjRk7xaNVjtWUSzE=; b=E0cCFsX3UORy/ITXm8isLtriejkTJZsyHrjHuDznKfbHsRUPK2h517cPQ1PsN33Ayyz9wQOf2zykdnJDEr9neALJgUhq1LF3WjSbJRHKpGoVsawl3IvmYOhdFAgUXMa+uVsksbinTNkWjOu8qyQYQfxeYyNOzvpH5QB1Wb9pmlb+AakmP+eqIjOPk2L+vOq3N4aB3qV3I+aNL1lyjBSGDeTJSDTWCiCOCrBnz+3iGooLjfl7g483EILvBvZf/HRAg0sVH5vW7PZMopI9JgATjzwv5JlvuUgUgJKh9AWjjawH3A6Rh2ywaqqPyFgCNgdF9mz+e/TWztVs78kivQ4Y+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lkMZHz6gDewY+245j+9nv4E7nACCjRk7xaNVjtWUSzE=; b=zRS9lcsHrv63kNSDpIrp6yBX9KBOzeea5IXRmBCn2fNmKPSND4rkMWCKJfUXc7Je4NiSKK+4cKwqd4plV9sjI5Q9zwj2QlyZxHe/XErD90RgOYqbwe5Ems6FGrUhL+L4PKfhTtBbQMBWGLSmlQ/I6hYmkUOdk2QzE6qxo30P8LE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB5807.namprd12.prod.outlook.com (2603:10b6:510:1d3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27; Tue, 19 Mar 2024 17:43:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7386.025; Tue, 19 Mar 2024 17:43:34 +0000 Message-ID: Date: Tue, 19 Mar 2024 17:43:30 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: fix auto completion for indirect list action Content-Language: en-US From: Ferruh Yigit To: Shani Peretz , dev@dpdk.org Cc: mkashani@nvidia.com, Ori Kam , Aman Singh , Yuying Zhang , Gregory Etelson References: <20240318092109.87656-1-shperetz@nvidia.com> <62669854-8add-4fdd-b882-a63d78f0d6e8@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0008.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB5807:EE_ X-MS-Office365-Filtering-Correlation-Id: 088243bc-f6b5-4b3e-1746-08dc483c199b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e4Azg3M7V/+qSc6E/Z5rzut6ou1g9r65YtGp9O+syZUVvFWkscxQJnTWnyo+ZvJZV0eo52LArs/o6xnMwxuQIMsm00L/ztyyglOW3/Ii11ZvOND2K1aNpbKRjsvrPL4YeJSBM0yPbpG3Ia1dnJb4VtKA5zZk51HgN8VSKtPlIEoD7MUQ9/l4xXlyqOXvdkYYnCnr9gI8ZT/AjkZI9mtMvesG97ov9rjoFNDS1wPdvq1qnWOp0f27Osnqkvq/K9UxwDIQGq5Ze1aQhv705CTKV1PIORhlOo+Cd9J6AyEvhhF8xIY4RJ/azr/cYvHlUJKqj9i0qjLa7K7pdGXacUZbPLa4lVYAZkKnfZ29NIxXtNFl2I0a2rUJyx/LVOhZKCjAzK4ShpLHXiMlEfrWl34RZvz2+0Pz38lQPsIY3qwmuGncXNjnvCgAAlEFv12Sf6cEMylFWiuqVjrFsjL7d5qv0ddASFXkOpB+fYPtrtpvSg0Z6DlC7aTtVZHTx9C/OOhWoefdVX3RvHcFAGcBewsvXr3w6ODOXTiLSf7LFKu8VnKJ/1zNglXc8Wkbd97YImFoExDf1oRlIJJVqwnV59bRUqrMYVC7x4PuokQKbk9xPqk1+KKWqSnHSWbb5rdar9y7+taiYM6t4ZH+Pf5/H9bSPw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2tvRTJ3d3EyeG03ejRUYVA1UnBOd3FTVjIzdHAxRzZuaWNDMkJSb040eCtm?= =?utf-8?B?MEVyVjVEODlQWXQ0Vlc3WXpSbkpObE85dmY2Tkg0RndGWkVMSHlNZkhsMjlk?= =?utf-8?B?dklhZ3dRZjFOZXJmdFQ2bGF5cjlrRng5NUo5STVodE9sL1UwQlVJcFdGdkpN?= =?utf-8?B?NlBwMzF5L0FFdDZIdUVjSGdvamplN09CQWs3dEE1SG1hUC9wZkZBUHk3aHFB?= =?utf-8?B?RFVWekkrek1vbVJZNXdGRmVORjl3YWdGcTVVK0pDOXJkMTh5VVhwYldlczNx?= =?utf-8?B?OXRyY3h0L0MrcjhKTDhpcnVEYzN6QTFvN1pJdGlhaTdxQ2lwRElHMjlHa2Ja?= =?utf-8?B?ZExMYnl5Qzk3ZlZQdjM0Y1FjUEFYejVreWFFNS9RWElYUWxmRWw2cko0eE1o?= =?utf-8?B?L2ZiUDNsU0pUY29IM0Z3aVowREE5ZDl1RWswVUJuNzNjTVdTZWdlQUp4QUJI?= =?utf-8?B?WWI0MWZJN3JHaSt6eWZMWkN5QmlMYURiQjVNK1JWY0l6RllUREJtTEdLVlNM?= =?utf-8?B?eWttendhallsL3dENDJhLzNaRnFVSHlzZDBHeHFvMFlNb2J4QksxZ1FOUlJq?= =?utf-8?B?a2MvRVZMZ0pQYnp6bnA0YWZnQnZKNGlJUTE1clJ6eDJ4QzU5dGJDbEFhTUNW?= =?utf-8?B?SjA1Q0pub3pRaHJHTmQzcVZSWjUwTmZkaG9PVXJXK0MyNlVFcVFURXA0ai9Q?= =?utf-8?B?QjhKUDExU2V4VGpGSkpKM2tVN2R2T0ViVXk4aGNWSjRwL3NOeU4wYUk3M2pS?= =?utf-8?B?R3V6dEdsV2pkcVdjZ3AzRmdNdjlBNCtudks5SEMyV2txdWxDaGhJdEErd3d1?= =?utf-8?B?Q05peCt0Z3F6cUtRMkVMVi9YZHZ5R1JubkFjRy9RbGF0QXFLOU5HcU5sMkVD?= =?utf-8?B?dHhvTE1VUXZoZGpFYlBwZGJScmRKZDVMOHZuYjJ1YkVZZWJCREc4NFZJMDg1?= =?utf-8?B?S1p3RThRL001TUJBY3ZKdEdheUZjMlIrY3h0YnduTnlQSUduemhta0Nqdm1R?= =?utf-8?B?TzVHcEFFNlgvQ2FES04vU280bHlkeE5JMTZmOEREZ3h0ZlJzSWM4ODhaR1di?= =?utf-8?B?UkM2dWRPZzRsY01LbGlPOU0rVDA2R1MxcmtNbGdnSThoN2ZvdW9DMGJSRFJD?= =?utf-8?B?MmJXbHNtYWJsSzZCb0lVenBGRndRUTBZRDRhLzBGRTNZempqeTF0cEQrTldW?= =?utf-8?B?SUNWTjJubFBLWDk1T29RWVNycGlraXVsd25mS2U1aDAxOGkzaEFJWEk1VzIy?= =?utf-8?B?YUdZS3JaNWVpang3WW9oZGFZeEZpZzUrMWRQbVF5UERlRURUT2NCbVhRbnZL?= =?utf-8?B?YjV6TUExNFNjbmNsVHJvd0NlRUlxM01CNStUUzdFZktIbkY2ZHFkc1ZKalVq?= =?utf-8?B?a3BCR3AwKzFqcmNrZXdaU2dhMGZIWVlld0ZjUEFFZFN6bkpGM3RFeDU5WVph?= =?utf-8?B?NVFHU2paTmpTRUtBR0xwZFZ5bUkrMnlPNWcvL0U5RjFCWGVuckc2N1BxNTUw?= =?utf-8?B?bG00OGt3WnQrVE9SdGhmT1lLWFM2Q2o2YzNia085TUU2Qll5VjZVUnZGek83?= =?utf-8?B?ZFhYQVBsenE3bVpZZS96UjhOYmdJZzIya3lSMHhBQUVSZ1ZGTE56bCtFZk5T?= =?utf-8?B?QjdlRDBaenFKbzlCSmlpc0RKZk40QW1QZjRWbDZIWFFOa1dwQkRZRmVnTzlF?= =?utf-8?B?cFR3ZHp6VW5jOUFlb0FIOGRkWVJVZjJudXFPeG84UCs4cGd1NnV6ci9VUXNU?= =?utf-8?B?cXhaczh6TDdTVlhxaDhyaEJnWVNIYUtobFNpY2d1ekRTL05Ya1RsaEhuNGZP?= =?utf-8?B?ZU9qYlBoNW9UaHlGZVVwMDgyaHFIWHZwNUtBN2ZYRk5IVmI3ZUlVSmYwdHVx?= =?utf-8?B?cmx3SjVrdFhUcEJ0blNmVXFwRUJEOUY0RUkwMUpiN1ZKWUhNSXJnbjJyK2Jm?= =?utf-8?B?eElFSm56KzlNYXI3RHZwUmtKQjg5OXdoRFFmY3hRbHQxeVRMZmxQOVdMVisy?= =?utf-8?B?c3FCakJZQ1lOUE5sbmtHTEU0d3BvVGxUVEhYRGdPZHNUSFZUNU95T3NrZ1dB?= =?utf-8?B?WmlrL09kNmdpc3VPT0thR2UwK1lvZDNHNFBnT0puektiV2tWY3UwcE5ncSt1?= =?utf-8?Q?zd90NJLhm9qsfhn2Ltj/8a7F/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 088243bc-f6b5-4b3e-1746-08dc483c199b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 17:43:34.5913 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sGt5pXQ+aqubwvNjbeOetcJiSrbDVG81hIZCOgAY4lqVCQiK/yHEs8ARHwqyEqin X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5807 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/19/2024 3:29 PM, Ferruh Yigit wrote: > On 3/19/2024 2:51 PM, Ferruh Yigit wrote: >> On 3/18/2024 9:21 AM, Shani Peretz wrote: >>> In the process of auto completion of a command in testpmd, >>> the parser splits the command into tokens, where each token >>> represents an argument and defines a parsing function. >>> The parsing function of the indirect_list action argument was returning >>> before having the opportunity to handle the argument. >>> >> Hi Shani, >> >> I can see a few other handles follows the updated logic, but to >> understand more, was the problematic part following: >> ``` >> if (!action) >> return -1; >> ``` >> >> If so why 'action' can be NULL and why need to continue for this case, >> can you please help me understand? >> >> Also even if 'action' is NULL, function will return output of >> 'parse_int()', is this expected? >> > > I can verify the fix via debugging, > > it seems missing ".comp = comp_none" cause calling handler > (parse_indlst_id2ptr), and 'parse_indlst_id2ptr()' needs to be fixed to > parse correctly. > > I will proceed with patch since it is local to a specific flow command, > Tested-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.