From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE014A0563; Wed, 15 Apr 2020 16:37:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 36D791D73B; Wed, 15 Apr 2020 16:37:08 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 5031C1D732 for ; Wed, 15 Apr 2020 16:37:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586961426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cnq/iOSsEWwsAVnYkHumEyd0EFBpYwlDSOG3Mf2qqUE=; b=COxGZLuGOzrPxPQyf75y85Q8F+xBkW9i2l1mbPF1Eul6/W0u/BkKF1TQMbeNWxDhrwHQ2j XWzlZC/YXmlq/D+ICWyyLI608XAOtBnwS5+J42sPOrea5RwPPVCR1dcwy/2o/E0pLu3Wmz 26b7cWXt1J7sllGF4DoMCJtzBAlvq4c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-WIyUZhwTN5WcAHKCBevEmw-1; Wed, 15 Apr 2020 10:37:05 -0400 X-MC-Unique: WIyUZhwTN5WcAHKCBevEmw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 113CE8018B4; Wed, 15 Apr 2020 14:37:04 +0000 (UTC) Received: from [10.36.110.44] (unknown [10.36.110.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31C4E5C1D6; Wed, 15 Apr 2020 14:37:01 +0000 (UTC) To: Matan Azrad , dev@dpdk.org Cc: Viacheslav Ovsiienko , Shahaf Shuler References: <1585826793-28709-1-git-send-email-matan@mellanox.com> <1585826793-28709-2-git-send-email-matan@mellanox.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Wed, 15 Apr 2020 16:36:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1585826793-28709-2-git-send-email-matan@mellanox.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Matan, On 4/2/20 1:26 PM, Matan Azrad wrote: > The vDPA device offloads all the datapath of the vhost device to the HW > device. >=20 > In order to expose to the user traffic information this patch introduce > new API to get traffic statistics per virtio queue. >=20 > The statistics are taken directly from the vDPA driver managing the HW > device. >=20 > Signed-off-by: Matan Azrad > Acked-by: Viacheslav Ovsiienko > --- > doc/guides/rel_notes/release_20_05.rst | 4 +++ > doc/guides/vdpadevs/features/default.ini | 1 + > doc/guides/vdpadevs/features_overview.rst | 3 +++ > lib/librte_vhost/rte_vdpa.h | 45 +++++++++++++++++++++++++= +++++- > lib/librte_vhost/rte_vhost_version.map | 1 + > lib/librte_vhost/vdpa.c | 14 ++++++++++ > 6 files changed, 67 insertions(+), 1 deletion(-) ... > diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h > index 9a3deb3..d6cbf48 100644 > --- a/lib/librte_vhost/rte_vdpa.h > +++ b/lib/librte_vhost/rte_vdpa.h > @@ -37,6 +37,27 @@ struct rte_vdpa_dev_addr { > =09}; > }; > =20 > +struct rte_vdpa_queue_stats { > +=09/** Number of descriptors received by device */ > +=09uint64_t received_desc; > +=09/** Number of descriptors completed by the device */ > +=09uint64_t completed_desc; > +=09/** Number of bad descriptors received by device */ > +=09uint32_t bad_desc; > +=09/** > +=09 * Number of chained descriptors received that exceed the max allowed > +=09 * chain by device > +=09 */ > +=09uint32_t exceed_max_chain; > +=09/** > +=09 * Number of times device tried to read or write buffer that is not > +=09 * registered to the device > +=09 */ > +=09uint32_t invalid_buffer; > +=09/** Number of errors detected by the device */ > +=09uint32_t errors; > +}; > + I think doing it like that, we risk to keep the rte_vdpa_get_stats API always experimental, as every vendor will want to add their own counters and so break the ABI. How about implementing something similar to rte_eth_xstat? As these stats are for debugging purpose, it would give you much more flexibility in adding new counters as HW or firmwares evolves. What do you think? Thanks, Maxime > /** > * vdpa device operations > */ > @@ -73,8 +94,11 @@ struct rte_vdpa_dev_ops { > =09int (*get_notify_area)(int vid, int qid, > =09=09=09uint64_t *offset, uint64_t *size); > =20 > +=09/** Get statistics of the queue */ > +=09int (*get_stats)(int did, int qid, struct rte_vdpa_queue_stats *stats= ); > + > =09/** Reserved for future extension */ > -=09void *reserved[5]; > +=09void *reserved[4]; > }; > =20 > /** > @@ -200,4 +224,23 @@ struct rte_vdpa_device * > __rte_experimental > int > rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Get vDPA device queue statistics. > + * > + * @param did > + * device id > + * @param qid > + * queue id > + * @param stats > + * queue statistics pointer. > + * @return > + * 0 on success, non-zero on failure. > + */ > +__rte_experimental > +int > +rte_vdpa_get_stats(int did, uint16_t qid, struct rte_vdpa_queue_stats *s= tats); > #endif /* _RTE_VDPA_H_ */ > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rt= e_vhost_version.map > index 051d08c..c9dcff4 100644 > --- a/lib/librte_vhost/rte_vhost_version.map > +++ b/lib/librte_vhost/rte_vhost_version.map > @@ -38,6 +38,7 @@ EXPERIMENTAL { > =09rte_vdpa_find_device_id; > =09rte_vdpa_get_device; > =09rte_vdpa_get_device_num; > +=09rte_vdpa_get_stats; > =09rte_vhost_driver_attach_vdpa_device; > =09rte_vhost_driver_detach_vdpa_device; > =09rte_vhost_driver_get_vdpa_device_id; > diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c > index 2b86708..57900fc 100644 > --- a/lib/librte_vhost/vdpa.c > +++ b/lib/librte_vhost/vdpa.c > @@ -227,3 +227,17 @@ struct rte_vdpa_device * > =09=09free_ind_table(idesc); > =09return -1; > } > + > +int > +rte_vdpa_get_stats(int did, uint16_t qid, struct rte_vdpa_queue_stats *s= tats) > +{ > +=09struct rte_vdpa_device *vdpa_dev; > + > +=09vdpa_dev =3D rte_vdpa_get_device(did); > +=09if (!vdpa_dev) > +=09=09return -ENODEV; > + > +=09RTE_FUNC_PTR_OR_ERR_RET(vdpa_dev->ops->get_stats, -ENOTSUP); > + > +=09return vdpa_dev->ops->get_stats(did, qid, stats); > +} >=20