From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B18AAA04DC; Mon, 19 Oct 2020 15:38:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DF26CA64; Mon, 19 Oct 2020 15:38:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 6E173C91A for ; Mon, 19 Oct 2020 15:38:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603114688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IaSqUaoEMwiuzNza62XBXS3sCsqV9w2dS59b7L951G0=; b=M9GuEYozITTeRRlPvEKR1zCkX/ucgtlCFDMo733lHIBR5KxdRA3uyMyi0921mb1+UQUVC1 AlMZVUgWH75mjAncrUqechk4ZaHbVAU/DAm3Ax2MoC3tl9H7W+wyO2CNbFajAl1adnZh/q fGuuPU7JbtVySCIlHLb3qMXJQyCCOSA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-wQucJbHSPHGSyaUSctR2Ow-1; Mon, 19 Oct 2020 09:38:06 -0400 X-MC-Unique: wQucJbHSPHGSyaUSctR2Ow-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44CFB18A8220; Mon, 19 Oct 2020 13:38:04 +0000 (UTC) Received: from [10.33.36.223] (unknown [10.33.36.223]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7ADF610013C4; Mon, 19 Oct 2020 13:37:59 +0000 (UTC) To: David Marchand , Bruce Richardson , Vladimir Medvedkin Cc: dev , Honnappa Nagarahalli , nd , Ruifeng Wang References: <20200907081518.46350-1-ruifeng.wang@arm.com> From: Kevin Traynor Message-ID: Date: Mon, 19 Oct 2020 14:37:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/2] LPM changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15/09/2020 15:41, David Marchand wrote: > On Mon, Sep 7, 2020 at 10:15 AM Ruifeng Wang wrote: >> >> The rte_lpm structure is exported because lookup API is inlined. >> But most of the structure can be hidden. >> Discussion at: http://patches.dpdk.org/patch/72403/ >> This patch set aimed to hide the rte_lpm structure as much as possible. >> >> A data free issue was identified and fixed. >> >> Ruifeng Wang (2): >> lpm: fix free of data structure >> lpm: hide internal data >> >> lib/librte_lpm/rte_lpm.c | 154 +++++++++++++++++++++++---------------- >> lib/librte_lpm/rte_lpm.h | 7 -- >> 2 files changed, 92 insertions(+), 69 deletions(-) > > Cc: maintainers. > > Those changes look good to me. > Opinions? > > LGTM, Gatekeeper confirmed they can handle this change. Acked-by: Kevin Traynor > Thanks. >