From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2FA18A2F for ; Thu, 27 Apr 2017 16:28:07 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 27 Apr 2017 07:28:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,384,1488873600"; d="scan'208";a="94541728" Received: from fhiggins-mobl3.ger.corp.intel.com (HELO [10.252.24.226]) ([10.252.24.226]) by fmsmga005.fm.intel.com with ESMTP; 27 Apr 2017 07:28:06 -0700 To: wang wei , dev@dpdk.org References: <20170425063049.4705-1-lnykww@gmail.com> Cc: ferruh.yigit@intel.com From: Declan Doherty Message-ID: Date: Thu, 27 Apr 2017 15:28:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170425063049.4705-1-lnykww@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix updating the slave link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 14:28:08 -0000 On 25/04/2017 7:30 AM, wang wei wrote: > we need to update dev->data->dev_link before handling lsc event. > Otherwise it will still have the initial value after the startup of > the program before interrupt callback was executed. > > Signed-off-by: wang wei > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index c94071ffb..57b1012c4 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1435,9 +1435,11 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > } > > /* If lsc interrupt is set, check initial slave's link status */ > - if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) > + if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) { > + slave_eth_dev->dev_ops->link_update(slave_eth_dev, 0); > bond_ethdev_lsc_event_callback(slave_eth_dev->data->port_id, > RTE_ETH_EVENT_INTR_LSC, &bonded_eth_dev->data->port_id); > + } > > return 0; > } > Acked-by: Declan Doherty