From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9FF73A48E for ; Fri, 20 Apr 2018 16:40:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Apr 2018 07:40:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,301,1520924400"; d="scan'208";a="52334939" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.249.235.3]) ([10.249.235.3]) by orsmga002.jf.intel.com with ESMTP; 20 Apr 2018 07:40:27 -0700 To: Anatoly Burakov , dev@dpdk.org References: Cc: thomas@monjalon.net From: "Tan, Jianfeng" Message-ID: Date: Fri, 20 Apr 2018 22:40:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/3] Coverity fixes for DPDK IPC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 14:40:31 -0000 On 4/17/2018 11:46 PM, Anatoly Burakov wrote: > This patchset fixes a few Coverity issues introduced > when various parts of DPDK IPC were added, and explains > away other reported issues. > > Coverity issues fixed: > - 272595 - return without mutex unlock > - 272609 - fd leak > > Coverity issues intentionally not fixed: > - 260407 - strcpy into fixed size buffer > - Both src and dst strings are fixed size, so this is false > positive > - Hopefully will be silenced by replacing strcpy with strlcpy > - 272565 - strcpy into fixed size buffer > - Same as above > - 272582 - strcpy into fixed size buffer > - Same as above > - 268321 - tainted string > - Not an issue, we handle errors correctly > - 272593 - tainted string > - Same as above > - 272604 - tainted string > - Same as above > - 260410 - not checking return value of rte_thread_setname > - We intentionally don't care if it fails > - 272583 - return without mutex unlock > - Independently discovered and fixed [1] > > [1] http://dpdk.org/dev/patchwork/patch/38042/ > > Anatoly Burakov (3): > ipc: use strlcpy where applicable > ipc: fix return without mutex unlock > ipc: fix resource leak > > lib/librte_eal/common/eal_common_proc.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > For this series, Acked-by: Jianfeng Tan Thanks for fixing these issues.